This commit is contained in:
woodser
2019-07-27 14:07:57 -04:00
parent 2c7ddbc4bb
commit f7b1faad3f
3 changed files with 2 additions and 4 deletions
+1 -2
View File
@@ -79,7 +79,6 @@ namespace monero {
// ---------------------------- MONERO ACCOUNT ------------------------------
// TODO: ensure return object is not being unecessarily copied
boost::property_tree::ptree MoneroAccount::toPropertyTree() const {
boost::property_tree::ptree node;
if (index != boost::none) node.put("index", *index);
@@ -328,7 +327,7 @@ namespace monero {
}
bool MoneroTransferRequest::meetsCriteria(MoneroTransfer* transfer) const {
if (transfer == nullptr) throw runtime_error("transfer is null"); // TODO: port to java/js
if (transfer == nullptr) throw runtime_error("transfer is null");
if (txRequest != boost::none && (*txRequest)->transferRequest != boost::none) throw runtime_error("Transfer request's tx request cannot have a circular transfer request"); // TODO: could auto detect and handl this. port to java/js
// filter on common fields
-2
View File
@@ -292,8 +292,6 @@ namespace monero {
/**
* Configures a request to send/sweep funds or create a payment URI.
*
* TODO: allow setAddress(), setAmount() for default destination?
*/
struct MoneroSendRequest : public SerializableStruct {
vector<shared_ptr<MoneroDestination>> destinations;
+1
View File
@@ -1,4 +1,5 @@
HIGH PRIORITY
ensure model toPropertyTrees(), etc are not unecessarily copying return objects
sign/submit tx
cpp library readme with sample code
code todos