From f7b1faad3f6b0ee4c95720591a009c3e5fb01490 Mon Sep 17 00:00:00 2001 From: woodser Date: Sat, 27 Jul 2019 14:07:57 -0400 Subject: [PATCH] cleanup --- src/wallet/MoneroWalletModel.cpp | 3 +-- src/wallet/MoneroWalletModel.h | 2 -- todo.txt | 1 + 3 files changed, 2 insertions(+), 4 deletions(-) diff --git a/src/wallet/MoneroWalletModel.cpp b/src/wallet/MoneroWalletModel.cpp index 2e1d4ea..712f624 100644 --- a/src/wallet/MoneroWalletModel.cpp +++ b/src/wallet/MoneroWalletModel.cpp @@ -79,7 +79,6 @@ namespace monero { // ---------------------------- MONERO ACCOUNT ------------------------------ - // TODO: ensure return object is not being unecessarily copied boost::property_tree::ptree MoneroAccount::toPropertyTree() const { boost::property_tree::ptree node; if (index != boost::none) node.put("index", *index); @@ -328,7 +327,7 @@ namespace monero { } bool MoneroTransferRequest::meetsCriteria(MoneroTransfer* transfer) const { - if (transfer == nullptr) throw runtime_error("transfer is null"); // TODO: port to java/js + if (transfer == nullptr) throw runtime_error("transfer is null"); if (txRequest != boost::none && (*txRequest)->transferRequest != boost::none) throw runtime_error("Transfer request's tx request cannot have a circular transfer request"); // TODO: could auto detect and handl this. port to java/js // filter on common fields diff --git a/src/wallet/MoneroWalletModel.h b/src/wallet/MoneroWalletModel.h index 2601643..c603300 100644 --- a/src/wallet/MoneroWalletModel.h +++ b/src/wallet/MoneroWalletModel.h @@ -292,8 +292,6 @@ namespace monero { /** * Configures a request to send/sweep funds or create a payment URI. - * - * TODO: allow setAddress(), setAmount() for default destination? */ struct MoneroSendRequest : public SerializableStruct { vector> destinations; diff --git a/todo.txt b/todo.txt index 86a3232..8226037 100644 --- a/todo.txt +++ b/todo.txt @@ -1,4 +1,5 @@ HIGH PRIORITY +ensure model toPropertyTrees(), etc are not unecessarily copying return objects sign/submit tx cpp library readme with sample code code todos