todo: request args are now const

todo: code todos for jni release complete
This commit is contained in:
woodser
2019-07-30 11:33:26 -04:00
parent 70a8779e48
commit 90176ac248
2 changed files with 2 additions and 5 deletions
+2 -2
View File
@@ -1328,7 +1328,7 @@ namespace monero {
}
}
// filter txs that don't meet transfer req // TODO **: port this updated version to js
// filter txs that don't meet transfer req // TODO: port this updated version to js
req->transferRequest = transferReq;
vector<shared_ptr<MoneroTxWallet>> txsRequested;
vector<shared_ptr<MoneroTxWallet>>::iterator txIter = txs.begin();
@@ -1486,7 +1486,7 @@ namespace monero {
// sort transfers
sort(tx->incomingTransfers.begin(), tx->incomingTransfers.end(), incomingTransferBefore);
// collect outgoing transfer, erase if filtered TODO **: js does not erase unrequested data, port to js
// collect outgoing transfer, erase if filtered TODO: js does not erase unrequested data, port to js
if (tx->outgoingTransfer != boost::none && req->meetsCriteria(tx->outgoingTransfer.get().get())) transfers.push_back(tx->outgoingTransfer.get());
else tx->outgoingTransfer = boost::none;
-3
View File
@@ -1,7 +1,4 @@
HIGH PRIORITY
code todos
const tx request
query args should be constant
ensure model toPropertyTrees(), etc are not unecessarily copying return objects
gen documentation
sample code including readme