From 90176ac248a0a7e1181cee8c807ac78f650ddc02 Mon Sep 17 00:00:00 2001 From: woodser Date: Tue, 30 Jul 2019 11:33:26 -0400 Subject: [PATCH] todo: request args are now const todo: code todos for jni release complete --- src/wallet/MoneroWallet.cpp | 4 ++-- todo.txt | 3 --- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/src/wallet/MoneroWallet.cpp b/src/wallet/MoneroWallet.cpp index 7f9da26..b760545 100644 --- a/src/wallet/MoneroWallet.cpp +++ b/src/wallet/MoneroWallet.cpp @@ -1328,7 +1328,7 @@ namespace monero { } } - // filter txs that don't meet transfer req // TODO **: port this updated version to js + // filter txs that don't meet transfer req // TODO: port this updated version to js req->transferRequest = transferReq; vector> txsRequested; vector>::iterator txIter = txs.begin(); @@ -1486,7 +1486,7 @@ namespace monero { // sort transfers sort(tx->incomingTransfers.begin(), tx->incomingTransfers.end(), incomingTransferBefore); - // collect outgoing transfer, erase if filtered TODO **: js does not erase unrequested data, port to js + // collect outgoing transfer, erase if filtered TODO: js does not erase unrequested data, port to js if (tx->outgoingTransfer != boost::none && req->meetsCriteria(tx->outgoingTransfer.get().get())) transfers.push_back(tx->outgoingTransfer.get()); else tx->outgoingTransfer = boost::none; diff --git a/todo.txt b/todo.txt index 14701b4..19ce5ff 100644 --- a/todo.txt +++ b/todo.txt @@ -1,7 +1,4 @@ HIGH PRIORITY -code todos -const tx request -query args should be constant ensure model toPropertyTrees(), etc are not unecessarily copying return objects gen documentation sample code including readme