Commit Graph
6960 Commits
Author SHA1 Message Date
moneromooo-moneroandwowario eaaa1e5a35 rpc: fix build, ctx does not exist yet on this branch 2019-03-08 21:17:43 +03:00
moneromooo-moneroandwowario 1ff89b1364 rpc: make fill_pow restricted
It's slow work, so let's not expose it
2019-03-08 21:17:43 +03:00
cslashmandwowario 9acb635efd Fix computation of change address + Fix v11 fork
Always send TX public key when generating output destination keys: it may be an additional TX public key in case of subaddress; before we always use R.
Fix the commitment mask generation: It must be delegated to device as it implies the amount key.
Send MONERO_VERSION string in reset command to allow version compatibility check.
Some enhancement of debug log.
2019-03-08 21:17:43 +03:00
moneromooo-moneroandwowario 5fd8022721 wallet2: fix incorrect patch for determining fork rules
Half of the patch was correct, but half was introducing another bug,
where a wallet asking for a fork that the daemon does not know about
yet would decide to use those rules.
2019-03-08 21:17:42 +03:00
moneromoooandwowario 385f232f5e hardfork: fix fork determination for historical heights 2019-03-08 21:17:42 +03:00
moneromooo-moneroandwowario 41f7e77ca5 blockchain: fix off by one brought by the regtest mode fix 2019-03-08 21:17:42 +03:00
Riccardo Spagniandwowario fb4c29b960 update version to 0.14.0.1 2019-03-08 21:17:42 +03:00
moneromooo-moneroandwowario 8aee860157 wallet2: fix mishandling rct outputs in coinbase tx
Reported by cutcoin
2019-03-08 21:17:42 +03:00
moneromooo-moneroandwowario 1c745c3b04 blockchain: fix long term block weight for regtest mode 2019-03-08 21:17:42 +03:00
TheCharlatanandwowario 7e9ecf35dd cmake: ARCH_ID fixes for cross compilation 2019-03-08 21:17:41 +03:00
selstaandwowario b4a6c93d94 wallet api/device: set estimated restore height if none is provided 2019-03-08 21:17:41 +03:00
selstaandwowario eaa36e8f26 wallet api: don't truncate address in subaddress_account
Same behaviour as subaddress.cpp now.
2019-03-08 21:17:41 +03:00
moneromooo-moneroandwowario 1e5f2e4c58 core: fix adding new pre-hoh block when a tx is already in the pool 2019-03-08 21:17:41 +03:00
Riccardo Spagniandwowario 39875ebdd4 bump version, update readme to reflect, update checkpoints 2019-03-08 21:17:41 +03:00
Riccardo Spagniandwowario 72a1b05c13 update quick sync checkpoints and hash 2019-03-08 21:17:41 +03:00
Dusan Klinecandwowario 9fad3c060b wallet: fix payment ID decryption for construction data 2019-03-08 21:17:40 +03:00
moneromooo-moneroandwowario b117840c81 blockchain: remove buggy long term block weight cache
It seems to be buggy on reorgs, and prevents the use of
a blockchain with two nodes.
We'll speed this up again if/when the need arises.
2019-03-08 21:17:40 +03:00
moneromooo-moneroandwowario 0622741c03 blockchain: fix block template creation race
If two create_block_template are called at nearly the same time,
and a block is added at nearly the same time, this could happen:

- the blockchain top block is B0
- thread 1 enters create_block_template, takes blockchain lock
- thread 1 creates a fresh block referencing prev block B0
- thread 1 releases blockchain lock
- thread 0 adds a new block
- thread 0 enters create_block_template
- thread 0 updates block template
- thread 1 takes txpool lock and continues creating block template
- thread 1 overwrites block template with previous data
2019-03-08 21:17:40 +03:00
moneromooo-moneroandwowario 362ecad06c blockchain: fix long term weight addition on pop/init 2019-03-08 21:17:40 +03:00
stoffuandwowario b45b4e58f4 rpc: fix wrongly formatted JSON for pruned tx
Fix for #4399.
Also unifies code for serializing pruned tx to binary/json into one.

(Cherry-picked from #4586)
2019-03-08 21:17:40 +03:00
moneromooo-moneroandwowario 4bcb105e6c db_lmdb: fix missing mdb_dbi_close in migration
Fixed by hyc
2019-03-08 21:17:40 +03:00
moneromooo-moneroandwowario 7553fdcbb3 CMakeLists.txt: detect and use -pthread compiler flag
The cmake thread detection just ain't enough to always work
2019-03-08 21:17:40 +03:00
moneromooo-moneroandwowario 32745e0696 miner: fix build with boost 1.69 2019-03-08 21:17:39 +03:00
moneromooo-moneroandwowario 56b6e9a89f mlocker: fix access to global lock map after dtor on exit
as the lock, it now leaks
2019-03-08 21:17:39 +03:00
moneromooo-moneroandwowario b91d510669 mlocker: fix dtor ordering problem
leak the mutex instead, it's a one off
2019-03-08 21:17:39 +03:00
moneromooo-moneroandwowario 93c2e6f521 blockchain: fix m_long_term_block_weight_height initialization
Also check return of that function, it can now return error
2019-03-08 21:17:39 +03:00
moneromooo-moneroandwowario 0470ea5ac0 blockchain: forbid older BP rct versions from v11 2019-03-08 21:17:37 +03:00
moneromooo-moneroandwowario f94c615fc3 Fix v3/v4 db conversion 2019-03-08 21:15:52 +03:00
xiphonandwowario ebb1580493 slow-hash: some more big endian fixes 2019-03-08 21:15:52 +03:00
moneromooo-moneroandwowario d2abdff997 slow-hash: fix for big endian 2019-03-08 21:15:52 +03:00
Pol Mauriandwowario baf9984f32 Small function declaration cleanup in slow-hash.c
- These functions are declared twice in slow-hash.c. Remove one of the copies.
- The declarations have the wrong return type, should be void, not int.

Function definitions here: https://github.com/monero-project/monero/blob/1e74586ee99e4bd89626d2eb4d23883cd91f0f81/src/crypto/aesb.c#L151-L180
Test plan: make release-test
2019-03-08 21:15:52 +03:00
cslashmandwowario 356ea85da7 Add support for V10 protocol with BulletProofV2 and short amount. 2019-03-08 21:15:52 +03:00
cslashmandwowario e1b8e3d7b4 Fix dummy decryption in debug mode 2019-03-08 21:15:52 +03:00
cslashmandwowario d56c1d68f9 fix log namespace 2019-03-08 21:15:52 +03:00
cslashmandwowario 6314a4e78a New scheme key destination contrfol
Implies protocol version management.
2019-03-08 21:15:51 +03:00
Tom Smedingandwowario 02db718dfe cryptonote: Fix enum check in expand_transaction_2
This was noticed because GCC warned about using an enum value in a
boolean context.
2019-03-08 21:15:51 +03:00
moneromooo-moneroandwowario a315729e98 simplewallet: tell the user to complain to the recipient
for long payment ids
2019-03-08 21:15:51 +03:00
moneromooo-moneroandwowario 423cf4406d ringct: fix v1 ecdhInfo serialization
The change made for v2 broke v1, and we have no way to know which
version we're serializing here. However, since we don't actually
care about space savings in this case, we continue serialiazing
both mask and amount.
2019-03-08 21:15:51 +03:00
moneromooo-moneroandwowario 33a76e92f4 ringct: the commitment mask is now deterministic
saves space in the tx and is safe

Found by knaccc
2019-03-08 21:15:51 +03:00
moneromooo-moneroandwowario 7ad2500f68 ringct: encode 8 byte amount, saving 24 bytes per output
Found by knaccc
2019-03-08 21:15:51 +03:00
moneromooo-moneroandwowario 7057806c49 ringct: save 3 bytes on bulletproof size
Found by luigi1111
2019-03-08 21:15:51 +03:00
moneromooo-moneroandwowario b5c9aed261 add a bulletproof version, new bulletproof type, and rct config
This makes it easier to modify the bulletproof format
2019-03-08 21:15:50 +03:00
moneromooo-moneroandwowario 817be97f39 core: include a dummy encrypted payment id when no payment is used
For better transaction uniformity, even though this wastes space.
2019-03-08 21:15:50 +03:00
moneromooo-moneroandwowario 73574c7380 core, wallet: remember original text version of destination address 2019-03-08 21:15:50 +03:00
moneromooo-moneroandwowario 2a616c8b15 simplewallet: disable long payment ids by default
unless --long-payment-id-support is used
2019-03-08 21:15:50 +03:00
moneromooo-moneroandwowario 8fdc0d4cb3 blockchain: fix wrong hf version when popping multiple blocks
Since we keep track of the hf version in the db, we pick it up
from there instead of doing the full reorg call, which is quite
expensive
2019-03-08 21:15:50 +03:00
moneromooo-moneroandwowario 66d1424200 simplewallet: remove ability to transfer with detached short payment ids
It seemed like a good idea at the time
2019-03-08 21:15:50 +03:00
moneromooo-moneroandwowario 3974e40efa blockchain: fix block rate check for empty blockchains 2019-03-08 21:15:50 +03:00
Jethro Grassieandwowario ad6a732f24 ignore child process when exec 2019-03-08 21:15:49 +03:00
moneromooo-moneroandwowario abb4728cf7 wallet2: fix ring reuse breaking when using histogram 2019-03-08 21:15:49 +03:00