Commit Graph
1040 Commits
Author SHA1 Message Date
tobtoht c1f81042b5 Merge pull request #11019
5f767c6 cryptonote_basic: keep additional derivations aligned in key image helper (Cole Munz)

ACKs: selsta, jeffro256
2026-08-07 18:26:05 +00:00
Lee Clagett b8028e31ad Change p2p connection map from raw pointers to weak_ptrs 2026-08-05 15:00:34 -04:00
selsta 44493becb7 p2p, rpc: group public IPv6 connection limits by /64 2026-08-01 17:23:05 +02:00
Cole Munz 5f767c6e4e cryptonote_basic: keep additional derivations aligned in key image helper
generate_key_image_helper only appended to additional_recv_derivations when
generate_key_derivation succeeded. A tx pubkey that is not a valid point makes
that call fail, so every later derivation shifted down one slot.

is_out_to_acc_precomp indexes that vector by the output index, so once the
list is short the lookup either falls off the bounds check or reads the
derivation belonging to a different output. Either way the helper reports that
the output does not belong to the address, and the wallet cannot build a key
image for an output it owns. Anyone who can put a transaction in front of the
wallet chooses those pubkeys.

The main tx pubkey a few lines up already handles a failed derivation by
keeping its slot and padding with identity, and wallet2 does the same in the
three places it builds this list (wallet2.cpp:2393, :7887, :13397). Do it here
too.
2026-07-31 23:37:25 -05:00
tobtoht ae3931c1d9 Merge pull request #10799
9268681 p2p: reject IPv4-mapped IPv6 peers (selsta)

ACKs: jpk68, plowsof
2026-07-31 21:37:02 +00:00
tobtoht 842cfad3ef Merge pull request #10970
4ee81cf rpc: hide ZMQ request contents in restricted mode (selsta)

ACKs: vtnerd, jpk68
2026-07-31 15:31:25 +00:00
selsta 9268681a6f p2p: reject IPv4-mapped IPv6 peers 2026-07-31 00:45:08 +02:00
selsta b167cb8f9a tests: replace removed scope leave helper 2026-07-31 00:20:06 +02:00
tobtoht cca26ba11e Merge pull request #11008
5bd5405 unit_tests: avoid nonexistent TLD in DNSSEC test (selsta)
0201b67 Revert "tests: enable temporary libunbound debug logging" (selsta)

ACKs: jpk68, tobtoht
2026-07-30 21:47:39 +00:00
selsta 5a199af7a6 p2p: group outbound IPv6 peers by /32 2026-07-30 23:36:30 +02:00
tobtoht 43fd7fb8dd Merge pull request #10747
d2e6f9b p2p: fix IPv4 subnet arithmetic (Ap4sh)

ACKs: selsta, jpk68
2026-07-30 21:27:32 +00:00
tobtoht 68985e6b63 Merge pull request #10917
e123147 Fix stall issues with p2p (Lee Clagett)

ACKs: jpk68, selsta
2026-07-30 21:06:51 +00:00
selsta 5bd5405266 unit_tests: avoid nonexistent TLD in DNSSEC test 2026-07-30 23:00:43 +02:00
selsta 0201b677d7 Revert "tests: enable temporary libunbound debug logging"
This reverts commit af4eda80a8.
2026-07-30 23:00:03 +02:00
Lee Clagett e123147542 Fix stall issues with p2p 2026-07-29 10:28:29 -04:00
tobtoht 4bc3735dbe Merge pull request #10458
3a63ea3 net/i2p: support human-readable hostnames (jpk68)

ACKs: selsta, iamamyth
2026-07-29 06:35:51 +00:00
jpk68 3a63ea3001 net/i2p: support human-readable hostnames 2026-07-28 14:27:51 -04:00
selsta af4eda80a8 tests: enable temporary libunbound debug logging 2026-07-27 15:35:52 +02:00
selsta 4ee81cfb73 rpc: hide ZMQ request contents in restricted mode 2026-07-25 14:16:12 +02:00
tobtoht 42b78ee9bd Merge pull request #10694
a01b4c2 daemon: remove bootstrap mode (tobtoht)

ACKs: thomasbuilds, selsta
2026-07-22 20:03:46 +00:00
tobtoht a01b4c2a31 daemon: remove bootstrap mode 2026-07-22 20:38:20 +02:00
tobtoht e00908bc49 Merge pull request #10921
edea850 general: replace auto_scope_leave_caller with scope_guard (jeffro256)

ACKs: selsta, tobtoht
2026-07-22 16:31:31 +00:00
tobtoht e071951803 Merge pull request #10920
b106208 dns_utils: update default public DNS resolvers (selsta)

ACKs: tobtoht, jpk68
2026-07-21 15:56:32 +00:00
tobtoht c24db9b23d Merge pull request #10890
0b79679 wallet2: guard gamma picker against zero-output windows (selsta)

ACKs: jeffro256*, iamamyth
2026-07-16 13:37:30 +00:00
jeffro256 edea8505db general: replace auto_scope_leave_caller with scope_guard
And replace unused inclusions of misc_language.h
2026-07-15 19:54:58 -05:00
selsta b106208a3e dns_utils: update default public DNS resolvers 2026-07-16 00:49:48 +02:00
tobtoht 2af2b48c03 Merge pull request #10345
b61c750 crypto: ed25519 -> Wei conversion (j-berman)

ACKs: UkoeHB, jeffro256
2026-07-15 17:21:32 +00:00
selsta 0b7967907f wallet2: guard gamma picker against zero-output windows 2026-07-14 19:41:36 +02:00
selsta b3aca5f53f tests: fix epee connection lifetime race
The lifetime test waited only for the client-side socket count to
reach zero before reconnecting. Because server-side inbound connections
are tracked separately, they may still be tearing down asynchronously,
causing the next connection attempt to fail with ECONNRESET on macOS.

Wait for both client and server connection accounting to drain before
the next reconnect. Also use the error_code connect overload so failures
are reported by gtest instead of escaping as uncaught Boost exceptions.
2026-07-08 21:10:40 +02:00
j-berman b61c750029 crypto: ed25519 -> Wei conversion 2026-07-08 06:34:40 -07:00
tobtoht 19b303c9b5 Merge pull request #10844
eaf139a tests: fix Windows unit test failures (selsta)

ACKs: tobtoht, plowsof
2026-07-08 11:01:22 +00:00
tobtoht 1d2c866f3e Merge pull request #10843
be7a5ec epee: allow shared Windows file reads (selsta)

ACKs: tobtoht, plowsof
2026-07-08 11:00:42 +00:00
tobtoht a434e19138 Merge pull request #10808
b305c44 escape control characters in json string serialiser (alhudz)

ACKs: vtnerd*, selsta
2026-07-08 09:30:20 +00:00
alhudzand“rootvector2” b305c44fc1 escape control characters in json string serialiser 2026-07-08 13:02:50 +05:30
j-berman 79a996be02 crypto: torsion clearing for FCMP++ 2026-07-07 14:32:13 -07:00
tobtoht a7c93412fe Merge pull request #10839
dc45f67 cryptonote_basic: remove legacy address parser (Ap4sh)

ACKs: selsta, tobtoht
2026-07-06 16:46:50 +00:00
selstaandjeffro256 dc8bc028a6 cryptonote: scope 202612 PoW workaround
The block 202612 PoW workaround previously applied to any block at
height 202612. Restrict it to the object hashes of the known historical
mainnet, testnet, and stagenet block hashing blobs so new chains do not
inherit the fixed PoW hash, which would prevent sync or mining past that
height if their difficulty is higher.

Reported-by: DataHoarder
Co-authored-by: jeffro256 <jeffro256@tutanota.com>
2026-07-03 14:59:41 +02:00
tobtoht 23372d12f5 Merge pull request #10108
ede4d7f RingCT crypto: 6x faster zero commit (j-berman)

ACKs: UkoeHB, jeffro256
2026-07-03 11:57:32 +00:00
tobtoht dac3103348 Merge pull request #10111
4f2a8a4 crypto: fast fe_batch_invert using Montgomery's trick (j-berman)

ACKs: UkoeHB, jeffro256
2026-07-03 11:55:20 +00:00
tobtoht a9d9134f62 Merge pull request #10800
f4047ae cryptonote_basic: copy tx extra payment IDs (Ap4sh)

ACKs: jeffro256, selsta
2026-07-01 20:00:37 +00:00
Ap4sh d2e6f9bb57 p2p: fix IPv4 subnet arithmetic 2026-06-30 20:40:44 +02:00
selsta be7a5ecc4e epee: allow shared Windows file reads
Opening a file with a zero sharing mode makes read-only access exclusive
on Windows. Allow read and write sharing so callers can inspect files
that are already open, such as active log files.
2026-06-30 19:35:28 +02:00
selsta eaf139a25a tests: fix Windows unit test failures
Preserve line endings for test fixtures so file hashes remain stable
across platforms.

Temporarily release the wallet keys lock while inspecting the keys file,
then reacquire it and verify the lock state. This lets the test read the
file on Windows, where the lock prevents a concurrent read open.

Avoid passing possibly negative char values to std::isprint(), which is
undefined behavior except for EOF.
2026-06-30 18:39:11 +02:00
selsta a568ba39fa tests: avoid ephemeral p2p ports in node_server tests
48080 and 58080 are within common ephemeral port ranges, which can
make node_server tests intermittently fail to bind after recently
closed TCP connections used the same local source port.

Use fixed unit-test ports outside those ranges and keep the tests on
127.0.0.1 instead of relying on 127.0.0.2 being configured.
2026-06-30 13:41:59 +02:00
Ap4sh dc45f673c9 cryptonote_basic: remove legacy address parser 2026-06-30 12:20:41 +02:00
j-bermanandJeffro 4f2a8a4270 crypto: fast fe_batch_invert using Montgomery's trick
https://iacr.org/archive/pkc2004/29470042/29470042.pdf 2.2

Also includes:
- fe_equals function
- breaks out fe_from_bytes_vartime function

Co-authored-by: Jeffro <jeffro256@tutanota.com>
2026-06-29 12:41:39 -07:00
tobtoht 286a7c9c77 Merge pull request #10834
4a627d4 tests: check node_server race init and connect (selsta)

ACKs: tobtoht, plowsof
2026-06-29 18:24:57 +00:00
tobtoht 6eef935d2c Merge pull request #10810
07f7c75 http: parse server Content-Length strictly (alhudz)

ACKs: vtnerd, selsta
2026-06-29 11:42:27 +00:00
selsta 4a627d44fa tests: check node_server race init and connect 2026-06-28 19:24:36 +02:00
tobtoht 0a83a39883 Merge pull request #10792
02db831 Fix spelling typos (Thomas)

ACKs: tobtoht, jeffro256
2026-06-24 17:21:24 +00:00