tobtoht
c1f81042b5
Merge pull request #11019
...
5f767c6 cryptonote_basic: keep additional derivations aligned in key image helper (Cole Munz)
ACKs: selsta, jeffro256
2026-08-07 18:26:05 +00:00
tobtoht
a82b6d8a17
Merge pull request #11018
...
a646d9e wallet2: clamp export_outputs start to the number of transfers (Cole Munz)
ACKs: selsta, jpk68
2026-08-07 18:25:31 +00:00
tobtoht
f4015164a7
Merge pull request #10998
...
2648a4a device: report ledger state when no app is open (reservedbytes)
ACKs: selsta, jpk68
2026-08-07 18:24:53 +00:00
tobtoht
189af8ec0d
Merge pull request #7345
...
b8028e3 Change p2p connection map from raw pointers to weak_ptrs (Lee Clagett)
ACKs: jpk68, selsta
2026-08-07 18:22:28 +00:00
reservedbytes
2648a4a335
device: report ledger state when no app is open
2026-08-06 20:08:58 +00:00
tobtoht
c48c51ddd9
Merge pull request #11004
...
ac80a76 guix: remove distribution package from install docs (tobtoht)
ACKs: selsta, jpk68
2026-08-06 07:01:49 +00:00
tobtoht
84024e27bb
Merge pull request #10997
...
c6ef8d2 device: fix ledger status code reporting (reservedbytes)
ACKs: jeffro256*, jpk68, selsta
2026-08-06 06:59:17 +00:00
Lee Clagett
b8028e31ad
Change p2p connection map from raw pointers to weak_ptrs
2026-08-05 15:00:34 -04:00
tobtoht
1bf1dff4be
Merge pull request #11000
...
8e30662 wallet2: fix compiler warning (jpk68)
ACKs: jeffro256, selsta, tobtoht
2026-08-04 16:29:57 +00:00
tobtoht
4605a02bcf
Merge pull request #10991
...
e7278c0 cryptonote_core: remove dead code (Thomas)
ACKs: jpk68, selsta
2026-08-04 14:41:01 +00:00
tobtoht
ec78687d91
Merge pull request #10986
...
8d76584 p2p: remove dead code (Thomas)
ACKs: jpk68, selsta
2026-08-04 14:40:12 +00:00
tobtoht
215e16ef46
Merge pull request #10840
...
5a2bd89 txpool: re-relay txs that haven't been relayed and need to be (j-berman)
ACKs: selsta, vtnerd, jpk68
2026-08-04 05:19:05 +00:00
tobtoht
83405f127d
Merge pull request #10988
...
7162000 device_trezor: validate bridge response size before parsing (selsta)
ACKs: jpk68, tobtoht, SNeedlewoods
2026-08-02 16:18:14 +00:00
tobtoht
13a8b563ee
Merge pull request #10982
...
8d4f888 device_trezor: reject incompatible firmware versions (jpk68)
ACKs: selsta*, SChernykh*, tobtoht
2026-08-01 17:55:56 +00:00
jpk68
8d4f888132
device_trezor: reject incompatible firmware versions
2026-08-01 13:21:25 -04:00
tobtoht
e8dd781e19
Merge pull request #10812
...
44493be p2p, rpc: group public IPv6 connection limits by /64 (selsta)
ACKs: plowsof*, tobtoht
2026-08-01 16:12:29 +00:00
tobtoht
ce1e0164f5
Merge pull request #10984
...
27367b8 simplewallet: prompt for restore height when using generate-from-device (jpk68)
ACKs: SChernykh, selsta
2026-08-01 15:23:27 +00:00
selsta
44493becb7
p2p, rpc: group public IPv6 connection limits by /64
2026-08-01 17:23:05 +02:00
tobtoht
42f566231a
Merge pull request #10980
...
1bae55a p2p: stop buffered dispatch after fatal notifications (selsta)
ACKs: jpk68*, SChernykh
2026-08-01 15:20:17 +00:00
tobtoht
f4c1bfc134
Merge pull request #10979
...
e2a4f68 wallet2: check for overflow when calculating fee from weight (selsta)
ACKs: jpk68, tobtoht, SChernykh
2026-08-01 15:19:01 +00:00
tobtoht
322bdba1d9
Merge pull request #10978
...
6e35278 device_trezor: improve error message for view key export (jpk68)
ACKs: selsta, tobtoht
2026-08-01 15:17:31 +00:00
tobtoht
b6c9dc5113
Merge pull request #10977
...
013741b simplewallet: use more straightforward device message (jpk68)
ACKs: selsta, tobtoht
2026-08-01 15:15:59 +00:00
tobtoht
80b8dcf7be
Merge pull request #10976
...
029fa3d simplewallet: fix restore-date parameter when using generate-from-device (jpk68)
ACKs: selsta, tobtoht
2026-08-01 15:14:52 +00:00
tobtoht
3a127cd06e
Merge pull request #10945
...
8c04ffe blockchain_prune: use per-table LMDB stats for resize estimation (selsta)
ACKs: jeffro256, tobtoht
2026-08-01 15:12:13 +00:00
Cole Munz
a646d9e7c3
wallet2: clamp export_outputs start to the number of transfers
...
export_outputs() says start and count are allowed to go past the valid range,
and that nothing is returned when they do. The loop honours that, but offset
does not: with all=true it takes start unchecked, so a start past the end makes
m_transfers.size() - offset underflow and reserve() gets a value near SIZE_MAX.
vector::reserve throws std::length_error on that, which is where the
"vector::reserve" error in issue #8625 comes from.
Clamping offset also keeps the returned offset usable. import_outputs throws
when offset is past the total, so leaving offset at start would only move the
failure from export to import.
2026-07-31 23:41:03 -05:00
Cole Munz
5f767c6e4e
cryptonote_basic: keep additional derivations aligned in key image helper
...
generate_key_image_helper only appended to additional_recv_derivations when
generate_key_derivation succeeded. A tx pubkey that is not a valid point makes
that call fail, so every later derivation shifted down one slot.
is_out_to_acc_precomp indexes that vector by the output index, so once the
list is short the lookup either falls off the bounds check or reads the
derivation belonging to a different output. Either way the helper reports that
the output does not belong to the address, and the wallet cannot build a key
image for an output it owns. Anyone who can put a transaction in front of the
wallet chooses those pubkeys.
The main tx pubkey a few lines up already handles a failed derivation by
keeping its slot and padding with identity, and wallet2 does the same in the
three places it builds this list (wallet2.cpp:2393, :7887, :13397). Do it here
too.
2026-07-31 23:37:25 -05:00
reservedbytes
c6ef8d2caa
device: fix ledger status code reporting
2026-07-31 22:47:04 +00:00
tobtoht
ae3931c1d9
Merge pull request #10799
...
9268681 p2p: reject IPv4-mapped IPv6 peers (selsta)
ACKs: jpk68, plowsof
2026-07-31 21:37:02 +00:00
tobtoht
42c038f593
Merge pull request #9801
...
d99d15a guix: add rust (tobtoht)
ACKs: selsta, jpk68
2026-07-31 19:36:43 +00:00
tobtoht
d4db4cad38
Merge pull request #10972
...
57ae55e rpc: disable get_transaction_pool in restricted mode (selsta)
ACKs: jpk68, SChernykh
2026-07-31 15:32:38 +00:00
tobtoht
842cfad3ef
Merge pull request #10970
...
4ee81cf rpc: hide ZMQ request contents in restricted mode (selsta)
ACKs: vtnerd, jpk68
2026-07-31 15:31:25 +00:00
selsta
9268681a6f
p2p: reject IPv4-mapped IPv6 peers
2026-07-31 00:45:08 +02:00
tobtoht
0156263696
Merge pull request #11010
...
b167cb8 tests: replace removed scope leave helper (selsta)
ACKs: tobtoht
2026-07-30 22:35:07 +00:00
selsta
b167cb8f9a
tests: replace removed scope leave helper
2026-07-31 00:20:06 +02:00
tobtoht
cca26ba11e
Merge pull request #11008
...
5bd5405 unit_tests: avoid nonexistent TLD in DNSSEC test (selsta)
0201b67 Revert "tests: enable temporary libunbound debug logging" (selsta)
ACKs: jpk68, tobtoht
2026-07-30 21:47:39 +00:00
tobtoht
1e0edf188a
Merge pull request #10876
...
967d79f cmake: allow user to select compiler cache (jpk68)
ACKs: selsta, tobtoht
2026-07-30 21:40:08 +00:00
tobtoht
596c388ca9
Merge pull request #10884
...
5a199af p2p: group outbound IPv6 peers by /32 (selsta)
ACKs: plowsof*, jpk68
2026-07-30 21:38:39 +00:00
selsta
5a199af7a6
p2p: group outbound IPv6 peers by /32
2026-07-30 23:36:30 +02:00
tobtoht
a2c40926a9
Merge pull request #10956
...
04cb066 wallet_rpc_server: refresh immediately when auto_refresh is enabled (woodser)
ACKs: SNeedlewoods, jpk68, selsta
2026-07-30 21:29:29 +00:00
tobtoht
43fd7fb8dd
Merge pull request #10747
...
d2e6f9b p2p: fix IPv4 subnet arithmetic (Ap4sh)
ACKs: selsta, jpk68
2026-07-30 21:27:32 +00:00
tobtoht
68985e6b63
Merge pull request #10917
...
e123147 Fix stall issues with p2p (Lee Clagett)
ACKs: jpk68, selsta
2026-07-30 21:06:51 +00:00
selsta
5bd5405266
unit_tests: avoid nonexistent TLD in DNSSEC test
2026-07-30 23:00:43 +02:00
selsta
0201b677d7
Revert "tests: enable temporary libunbound debug logging"
...
This reverts commit af4eda80a8 .
2026-07-30 23:00:03 +02:00
tobtoht
3db83d5f4a
Merge pull request #10967
...
31d0854 depends: unbound: update to 1.25.2 (tobtoht)
ACKs: SNeedlewoods, plowsof, jpk68
2026-07-30 15:06:05 +00:00
tobtoht
ac80a76666
guix: remove distribution package from install docs
2026-07-30 12:24:42 +02:00
jpk68
8e30662486
wallet2: fix compiler warning
2026-07-29 14:14:00 -04:00
tobtoht
cca5817487
Merge pull request #10675
...
74e03c4 remove translations (tobtoht)
ACKs: selsta, thomasbuilds, jpk68
2026-07-29 17:54:11 +00:00
tobtoht
913cd4c243
Merge pull request #10960
...
8b012e4 Optimize hashing of generic types (SChernykh)
ACKs: vtnerd, selsta
2026-07-29 17:51:23 +00:00
tobtoht
a1addd0283
Merge pull request #10953
...
5a884c4 Fix TryAcquireSRWLockShared being implicitly defined and causing UB (SChernykh)
ACKs: tobtoht, selsta, jpk68
2026-07-29 15:43:27 +00:00
tobtoht
2b1fde5ae4
Merge pull request #10958
...
ee8f546 rpc: recover from oversized ZMQ requests (selsta)
ACKs: jpk68, vtnerd
2026-07-29 15:42:17 +00:00