github-wownero/wownero-cpp
1
0
Fork 0
mirror of https://github.com/wownero/wownero-cpp.git synced 2026-10-18 07:41:32 +02:00
Code Issues Packages Projects Releases Wiki Activity

monero_wallet.h request -> query terminology

Browse Source
This commit is contained in:
woodser
2019-12-01 08:41:53 -05:00
parent 3c4f68911e
commit f6d7d47d2c
2 changed files with 14 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/wallet/monero_wallet.h
+13 -13
View File
@@ -655,15 +655,15 @@ namespace monero {
* Get wallet transactions. Wallet transactions contain one or more
* transfers that are either incoming or outgoing to the wallet.
*
* Query results can be filtered by passing in a transaction request.
* Transactions must meet every criteria defined in the request in order to
* Query results can be filtered by passing in a transaction query.
* Transactions must meet every criteria defined in the query in order to
* be returned. All filtering is optional and no filtering is applied when
* not defined.
*
* @param request filters query results (optional)
* @return wallet transactions per the request
* @param query filters query results (optional)
* @return wallet transactions per the query
*/
vector<shared_ptr<monero_tx_wallet>> get_txs(const monero_tx_query& request) const;
vector<shared_ptr<monero_tx_wallet>> get_txs(const monero_tx_query& query) const;
// /**
// * Get all incoming and outgoing transfers to and from this wallet. An
@@ -713,14 +713,14 @@ namespace monero {
* are stored on the blockchain.
*
* Query results can be filtered by passing in a monero_transfer_query.
* Transfers must meet every criteria defined in the request in order to be
* Transfers must meet every criteria defined in the query in order to be
* returned. All filtering is optional and no filtering is applied when not
* defined.
*
* @param request filters query results (optional)
* @return wallet transfers per the request
* @param query filters query results (optional)
* @return wallet transfers per the query
*/
vector<shared_ptr<monero_transfer>> get_transfers(const monero_transfer_query& request) const;
vector<shared_ptr<monero_transfer>> get_transfers(const monero_transfer_query& query) const;
// /**
// * Get outputs created from previous transactions that belong to the wallet
@@ -737,13 +737,13 @@ namespace monero {
* transactions which are stored in blocks on the blockchain.
*
* Results can be configured by passing a monero_output_query. Outputs must
* meet every criteria defined in the request in order to be returned. All
* meet every criteria defined in the query in order to be returned. All
* filtering is optional and no filtering is applied when not defined.
*
* @param request specifies request options (optional)
* @return List<monero_output_wallet> are wallet outputs per the request
* @param query specifies query options (optional)
* @return wallet outputs per the query
*/
vector<shared_ptr<monero_output_wallet>> get_outputs(const monero_output_query& request) const;
vector<shared_ptr<monero_output_wallet>> get_outputs(const monero_output_query& query) const;
/**
* Export all outputs in hex format.
todo.txt
+1 -4
View File
@@ -1,10 +1,7 @@
TODO
monero_wallet.h request -> query
preserve rpc error codes, just throwing runtime_error now
gen_utils.h and monero_utils.h should not depend on monero_wallet.h
add to ecosystem?
monero_wallet.cpp move utilities in monero_namespace to be private
polish model: no boost::optional<shared_ptr>? no boost::optional<string>? etc
polish model: remove all boost::optional from model to be consistent with core?
ensure model toPropertyTrees(), etc are not unecessarily copying return objects
monero_wallet_listener should be a class?
way to use copy constructors instead of query copy(sp, sp) methods?