cleanup

src/daemon/MoneroDaemonModel.h

@@ -100,7 +100,7 @@ namespace monero {
    */
   struct MoneroRpcConnection {
     string uri;
-    string username;
+    string username;  // todo: these should be optional
     string password;
     //MoneroRpcConnection() : uri(""), username(""), password("")) {}
     MoneroRpcConnection(const string& uri = "", const string& username = "", const string& password = "") : uri(uri), username(username), password(password) {}

src/wallet/MoneroWallet.cpp

@@ -867,6 +867,7 @@ namespace monero {
   }
 
   shared_ptr<MoneroRpcConnection> MoneroWallet::getDaemonConnection() const {
+    cout << "MoneroWallet::getDaemonConnection()" << endl;
     if (wallet2->get_daemon_address().empty()) return nullptr;
     shared_ptr<MoneroRpcConnection> connection = shared_ptr<MoneroRpcConnection>(new MoneroRpcConnection());
     if (!wallet2->get_daemon_address().empty()) connection->uri = wallet2->get_daemon_address();

todo.txt

@@ -7,9 +7,6 @@ comb code todos
 
 MEDIUM PRIORITY
 onSyncProgress(startHeight, currentHeight, endHeight, percentDone, message)?
-remove warning jstring2string
-rename external-libs/monero to monero-core for clarity
-cppWalletHandle, cppListenerHandle string constants in MoneroWalletJni.cpp
 toPropertyTree() should take node as parameter; optimize memory elsewhere (move shared_ptrs, etc)
 enable debug logging
 model accessors/mutators/chaining?