github-wownero/wowlet
1
0
Fork 0
mirror of https://github.com/wownero/wowlet.git synced 2026-10-17 07:11:29 +02:00
Code Issues Packages Projects Releases Wiki Activity

cmake: don't link ICU/iconv on cross-builds (vestigial without system boost)

Browse Source 
feather.exe links ${ICU_LIBRARIES}, set by the monero submodule's static-build branch assuming depends ships ICU + libiconv. Feather's depends doesn't, and its depends boost is --without-icu, so nothing references ICU/iconv symbols — the mingw link failed on missing -licu*/-liconv. Clear ICU_LIBRARIES when CMAKE_CROSSCOMPILING; native (system boost, built with ICU) unchanged.
This commit is contained in:
jwinterm
2026-06-20 22:20:35 -04:00
parent f93b3f705e
commit c87d807443
1 changed files with 9 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/CMakeLists.txt
+9
View File
@@ -274,6 +274,15 @@ if (DEPENDS)
target_link_directories(feather PRIVATE "${LIB_DIR}")
endif()
# ICU_LIBRARIES is set by the monero/wownero submodule (its STATIC-build branch, ~CMakeLists.txt:1131:
# `set(ICU_LIBRARIES icuio ... iconv)`) assuming depends ships ICU + libiconv — true for monero's own
# depends, NOT feather's. And our cross-build's depends boost is --without-icu, so nothing references
# ICU/iconv symbols: the link is vestigial. Drop it when cross-compiling (else the mingw link fails on
# missing -licu*/-liconv). Native builds keep it — their system boost IS built against ICU.
if(CMAKE_CROSSCOMPILING)
set(ICU_LIBRARIES "")
endif()
target_link_libraries(feather PRIVATE
wallet_api
epee