github-such-software/wownerogue
1
0
Fork 0
mirror of https://github.com/Such-Software/wownerogue.git synced 2026-10-19 07:08:33 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix(ui): real right gutter so play-area focus outline shows on the right; Smirk flow

Browse Source 
Play area: add a 6px right gutter on .container (border-box) so the outward yellow focus outline isn't clipped by overflow:hidden at the viewport edge — the inset-outline attempt got clipped in Chromium. Revert to an outward outline (ui.js).

Smirk: on the NIP-98 path, only fall back to the legacy connect() when the wallet genuinely lacks signNostrEvent — a LOCKED or user-cancelled signNostrEvent now surfaces instead of triggering a second unlock prompt. (The unlock-popup-on-locked behavior itself is a wallet-build capability, added to smirk-monorepo 2026-07-09; builds before that throw LOCKED and get the friendly retry hint.)
This commit is contained in:
jwinterm
2026-07-10 09:11:07 -04:00
parent a05a10efd7
commit a243dd8fc6
3 changed files with 17 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
html/js/network/smirkAuth.js
+10 -4
View File
@@ -77,10 +77,16 @@ const SmirkAuth = {
verifyData = result.verifyData;
provenPublicKey = result.pubkey;
} catch (nip98Err) {
// Graceful fallback: if NIP-98 signing/verification fails
// (wallet threw, lacks the method mid-flow, etc.) fall back to
// the legacy path so login still works.
console.warn('Smirk NIP-98 auth failed, falling back to legacy:', nip98Err && nip98Err.message);
// Only fall back to the legacy path when the wallet genuinely can't do NIP-98
// (method missing / unsupported). For LOCKED (unlock the extension), USER_REJECTED
// (user closed the popup), or a real signing failure, SURFACE it — re-invoking
// connect() would just pop a second prompt. On a current Smirk build a locked
// signNostrEvent auto-opens the unlock popup and never reaches here.
const code = nip98Err && nip98Err.code;
const methodMissing = code === 'UNSUPPORTED' || code === 'METHOD_NOT_FOUND'
|| /not a function|is not supported|no such method|unsupported/i.test((nip98Err && nip98Err.message) || '');
if (!methodMissing) throw nip98Err;
console.warn('Smirk NIP-98 unsupported, falling back to legacy:', nip98Err && nip98Err.message);
const result = await this._verifyLegacy(socketId, challenge);
verifyData = result.verifyData;
provenPublicKey = result.pubkey;
html/js/ui/ui.js
+3 -4
View File
@@ -19,10 +19,9 @@ const UI = {
var chatInput = $('#chatInput');
if (document.activeElement === gameDisplay[0]) {
// Inset the outline (offset -2px) so it is drawn INSIDE the box — the play area is
// flush to the viewport's right edge and the container clips an outward outline there,
// which hid the border on the right side.
gameDisplay.css({ 'outline': '2px solid yellow', 'outline-offset': '-2px' });
// Outward outline; the .container now has a right gutter (padding-right) so the right
// segment isn't clipped by overflow:hidden. (Inset offset gets clipped in Chromium.)
gameDisplay.css({ 'outline': '2px solid yellow', 'outline-offset': '0' });
chatInput.css('outline', 'none');
} else if (document.activeElement === chatInput[0]) {
chatInput.css('outline', '2px solid cyan');
html/styles/stylesheet.css
+4
View File
@@ -73,6 +73,10 @@ body {
height: 100vh;
width: 100%;
max-width: 100vw;
box-sizing: border-box;
/* A few px of right gutter so the play area isn't flush to the viewport edge — otherwise
overflow:hidden clips the yellow focus outline on the right side. */
padding-right: 6px;
overflow: hidden;
gap: 1px;
background-color: var(--bg-panel);