github-such-software/hash-wallet
1
0
Fork 1
mirror of https://github.com/Such-Software/hash-wallet.git synced 2026-10-17 05:41:29 +02:00
Code Issues Packages Projects Releases Wiki Activity

Update RBF nsequence to 0xFFFFFFFD (#3077)

Browse Source 
Technically `0x1` will signal opt-in RBF (since 0x1 ≤ 0xFFFFFFFD); however it also sets a relative timelock of 1 block. This seems like an unintended bug. It also fingerprints cake wallet since `0x1` is an abnormal value. This is especially harmful in collaborative settings e.g payjoin. Most wallets set `nsequence = 0xFFFFFFFD` to opt into RBF or just use full rbf which seems to be gaining more adoption.
This commit is contained in:
Armin Sabouri
2026-03-13 23:42:41 +01:00
committed by GitHub
parent 9a6fd46e04
commit 4d61345f30
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
cw_bitcoin/lib/psbt/transaction_builder.dart
+1 -1
View File
@@ -25,7 +25,7 @@ class PSBTTransactionBuild {
psbt.setInputPreviousTxId(i, Uint8List.fromList(hex.decode(input.utxo.txHash).reversed.toList()));
psbt.setInputOutputIndex(i, input.utxo.vout);
psbt.setInputSequence(i, enableRBF ? 0x1 : 0xffffffff);
psbt.setInputSequence(i, enableRBF ? 0xfffffffd : 0xffffffff);
if (input.utxo.isSegwit()) {