v4.20.0 (#1759)

* new version

* fix android manifest [skip ci]

* fix sp scanning [skip ci]

android/app/src/main/AndroidManifestBase.xml

@@ -14,7 +14,7 @@
 <!--     required for API 18 - 30 -->
     <uses-permission android:name="android.permission.BLUETOOTH" android:maxSdkVersion="30" />
     <uses-permission android:name="android.permission.BLUETOOTH_ADMIN" android:maxSdkVersion="30" />
-    <uses-permission android:name="android.permission.ACCESS_FINE_LOCATION" android:maxSdkVersion="30" />
+    <uses-permission android:name="android.permission.ACCESS_FINE_LOCATION" />
 
 <!--     required for API <= 29 -->
     <uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE" android:maxSdkVersion="29" />

assets/text/Monerocom_Release_Notes.txt

@@ -1,4 +1,3 @@
-Monero enhancements for sending and address generation
-StealthEx
-LetsExchange
-Visual enhancements and bug fixes
+Monero enhancements
+Introducing StealthEx and LetxExchange
+Bug fixes

assets/text/Release_Notes.txt

@@ -1,9 +1,6 @@
-Add Litecoin MWEB
-Wallet groups (same seed, multiple wallets)
-Silent Payments enhancements
-Monero enhancements for sending and address generation
-StealthEx
-LetsExchange
-Replace-By-Fee improvements
-ERC20 tokens potential scam detection
-Visual enhancements and bug fixes
+Added Litecoin MWEB
+Added wallet groups
+Silent Payment enhancements for speed & reliability
+Monero enhancements
+Introducing StealthEx and LetxExchange
+Additional ERC20 tokens scam detection

cw_bitcoin/lib/electrum.dart

@@ -423,7 +423,7 @@ class ElectrumClient {
   BehaviorSubject<T>? subscribe<T>(
       {required String id, required String method, List<Object> params = const []}) {
     try {
-      if (socket == null || !isConnected) {
+      if (socket == null) {
         return null;
       }
       final subscription = BehaviorSubject<T>();
@@ -439,7 +439,7 @@ class ElectrumClient {
 
   Future<dynamic> call(
       {required String method, List<Object> params = const [], Function(int)? idCallback}) async {
-    if (socket == null || !isConnected) {
+    if (socket == null) {
       return null;
     }
     final completer = Completer<dynamic>();
@@ -455,7 +455,7 @@ class ElectrumClient {
   Future<dynamic> callWithTimeout(
       {required String method, List<Object> params = const [], int timeout = 5000}) async {
     try {
-      if (socket == null || !isConnected) {
+      if (socket == null) {
         return null;
       }
       final completer = Completer<dynamic>();

cw_bitcoin/lib/litecoin_wallet.dart

@@ -7,7 +7,6 @@ import 'package:crypto/crypto.dart';
 import 'package:cw_bitcoin/bitcoin_transaction_credentials.dart';
 import 'package:cw_core/cake_hive.dart';
 import 'package:cw_core/mweb_utxo.dart';
-import 'package:cw_core/unspent_coin_type.dart';
 import 'package:cw_mweb/mwebd.pbgrpc.dart';
 import 'package:fixnum/fixnum.dart';
 import 'package:bip39/bip39.dart' as bip39;
@@ -425,7 +424,6 @@ abstract class LitecoinWalletBase extends ElectrumWallet with Store {
     bool? usingElectrs,
   }) async {
     _syncTimer?.cancel();
-    int oldHeight = walletInfo.restoreHeight;
     await walletInfo.updateRestoreHeight(height);
 
     // go through mwebUtxos and clear any that are above the new restore height:

cw_core/lib/wallet_addresses.dart

@@ -23,7 +23,7 @@ abstract class WalletAddresses {
     return _localAddress ?? address;
   }
 
-  String get primaryAddress;
+  String get primaryAddress => address;
 
   String? _localAddress;
 

lib/src/screens/dashboard/pages/balance_page.dart

@@ -1061,7 +1061,7 @@ class BalanceRowWidget extends StatelessWidget {
                             ),
                           ),
                         ),
-                        SizedBox(width: 32),
+                        SizedBox(width: 24),
                         Expanded(
                           child: Semantics(
                             label: S.of(context).litecoin_mweb_pegout,

scripts/android/app_env.sh

@@ -16,14 +16,14 @@ APP_ANDROID_TYPE=$1
 
 MONERO_COM_NAME="Monero.com"
 MONERO_COM_VERSION="1.17.0"
-MONERO_COM_BUILD_NUMBER=102
+MONERO_COM_BUILD_NUMBER=103
 MONERO_COM_BUNDLE_ID="com.monero.app"
 MONERO_COM_PACKAGE="com.monero.app"
 MONERO_COM_SCHEME="monero.com"
 
 CAKEWALLET_NAME="Cake Wallet"
 CAKEWALLET_VERSION="4.20.0"
-CAKEWALLET_BUILD_NUMBER=230
+CAKEWALLET_BUILD_NUMBER=232
 CAKEWALLET_BUNDLE_ID="com.cakewallet.cake_wallet"
 CAKEWALLET_PACKAGE="com.cakewallet.cake_wallet"
 CAKEWALLET_SCHEME="cakewallet"

scripts/ios/app_env.sh

@@ -14,12 +14,12 @@ APP_IOS_TYPE=$1
 
 MONERO_COM_NAME="Monero.com"
 MONERO_COM_VERSION="1.17.0"
-MONERO_COM_BUILD_NUMBER=100
+MONERO_COM_BUILD_NUMBER=101
 MONERO_COM_BUNDLE_ID="com.cakewallet.monero"
 
 CAKEWALLET_NAME="Cake Wallet"
 CAKEWALLET_VERSION="4.20.0"
-CAKEWALLET_BUILD_NUMBER=269
+CAKEWALLET_BUILD_NUMBER=276
 CAKEWALLET_BUNDLE_ID="com.fotolockr.cakewallet"
 
 HAVEN_NAME="Haven"

scripts/linux/app_env.sh

@@ -15,7 +15,7 @@ fi
 
 CAKEWALLET_NAME="Cake Wallet"
 CAKEWALLET_VERSION="1.10.0"
-CAKEWALLET_BUILD_NUMBER=35
+CAKEWALLET_BUILD_NUMBER=36
 
 if ! [[ " ${TYPES[*]} " =~ " ${APP_LINUX_TYPE} " ]]; then
     echo "Wrong app type."

scripts/macos/app_env.sh

@@ -17,12 +17,12 @@ fi
 
 MONERO_COM_NAME="Monero.com"
 MONERO_COM_VERSION="1.7.0"
-MONERO_COM_BUILD_NUMBER=33
+MONERO_COM_BUILD_NUMBER=34
 MONERO_COM_BUNDLE_ID="com.cakewallet.monero"
 
 CAKEWALLET_NAME="Cake Wallet"
 CAKEWALLET_VERSION="1.13.0"
-CAKEWALLET_BUILD_NUMBER=90
+CAKEWALLET_BUILD_NUMBER=92
 CAKEWALLET_BUNDLE_ID="com.fotolockr.cakewallet"
 
 if ! [[ " ${TYPES[*]} " =~ " ${APP_MACOS_TYPE} " ]]; then