PEP8 fixes

modoboa/extensions/postfix_autoreply/__init__.py

@@ -7,23 +7,27 @@ functionality into Postfix.
 
 """
 import sys
+
 from django.utils.translation import ugettext_lazy
-from modoboa.lib import events, parameters
+
 from modoboa.core.extensions import ModoExtension, exts_pool
 from modoboa.extensions.postfix_autoreply.models import (
     Transport, Alias
 )
+from modoboa.lib import events, parameters
 
 
 class PostfixAutoreply(ModoExtension):
+
     """
     Auto-reply (vacation) functionality using Postfix.
-    
+
     """
     name = "postfix_autoreply"
     label = "Postfix autoreply"
     version = "1.0"
-    description = ugettext_lazy("Auto-reply (vacation) functionality using Postfix")
+    description = ugettext_lazy(
+        "Auto-reply (vacation) functionality using Postfix")
 
     def init(self):
         from modoboa.extensions.admin.models import Domain
@@ -45,10 +49,14 @@ class PostfixAutoreply(ModoExtension):
                     onMailboxCreated(None, mb)
 
     def load(self):
-        from modoboa.extensions.postfix_autoreply.app_settings import ParametersForm
-        parameters.register(ParametersForm, ugettext_lazy("Automatic replies"))
+        from modoboa.extensions.postfix_autoreply.app_settings import (
+            ParametersForm
+        )
+        parameters.register(
+            ParametersForm, ugettext_lazy("Automatic replies"))
         from modoboa.extensions.postfix_autoreply import general_callbacks
-        if 'modoboa.extensions.postfix_autoreply.general_callbacks' in sys.modules:
+        modname = "modoboa.extensions.postfix_autoreply.general_callbacks"
+        if modname in sys.modules:
             reload(general_callbacks)
 
     def destroy(self):

modoboa/extensions/postfix_autoreply/app_settings.py

@@ -1,8 +1,12 @@
 # coding: utf-8
-from django.utils.translation import ugettext_lazy
+
+"""Custom settings."""
+
 from django import forms
-from modoboa.lib.parameters import AdminParametersForm
+from django.utils.translation import ugettext_lazy
+
 from modoboa.lib.form_utils import SeparatorField
+from modoboa.lib.parameters import AdminParametersForm
 
 
 class ParametersForm(AdminParametersForm):
@@ -13,7 +17,9 @@ class ParametersForm(AdminParametersForm):
     autoreplies_timeout = forms.IntegerField(
         label=ugettext_lazy("Automatic reply timeout"),
         initial=86400,
-        help_text=ugettext_lazy("Timeout in seconds between two auto-replies to the same recipient"),
+        help_text=ugettext_lazy(
+            "Timeout in seconds between two auto-replies to the same recipient"
+        ),
         widget=forms.TextInput(attrs={"class": "form-control"})
     )
 
@@ -21,7 +27,8 @@ class ParametersForm(AdminParametersForm):
         label=ugettext_lazy("Default subject"),
         initial=ugettext_lazy("I'm off"),
         help_text=ugettext_lazy(
-            "Default subject used when an auto-reply message is created automatically"
+            "Default subject used when an auto-reply message is created "
+            "automatically"
         ),
         widget=forms.TextInput(attrs={"class": "form-control"})
     )

modoboa/extensions/postfix_autoreply/forms.py

@@ -1,11 +1,16 @@
 # coding: utf-8
+
+"""Custom forms."""
+
 from django import forms
-from django.utils.translation import ugettext as _, ugettext_lazy
 from django.utils import timezone
+from django.utils.translation import ugettext as _, ugettext_lazy
+
 from .models import ARmessage
 
 
 class ARmessageForm(forms.ModelForm):
+
     fromdate = forms.DateTimeField(
         label=ugettext_lazy('From'),
         required=False,
@@ -23,15 +28,15 @@ class ARmessageForm(forms.ModelForm):
         )
     )
     subject = forms.CharField(
-            widget=forms.TextInput(
-                    attrs={'class': 'form-control'}
-                )
+        widget=forms.TextInput(
+            attrs={'class': 'form-control'}
+        )
     )
     content = forms.CharField(
-                widget=forms.Textarea(
-                        attrs={'class': 'form-control'}
-                    )
+        widget=forms.Textarea(
+            attrs={'class': 'form-control'}
         )
+    )
 
     class Meta:
         model = ARmessage
@@ -67,13 +72,14 @@ class ARmessageForm(forms.ModelForm):
         else:
             self.cleaned_data['fromdate'] = timezone.now()
         if self.cleaned_data["untildate"] is not None:
-            if self.cleaned_data["untildate"] < timezone.now():
+            untildate = self.cleaned_data["untildate"]
+            if untildate < timezone.now():
                 self._errors["untildate"] = self.error_class(
                     [_("This date is over")])
-                del self.cleaned_data['untildate']
-            elif 'fromdate' in self.cleaned_data and \
-                    self.cleaned_data['untildate'] < self.cleaned_data['fromdate']:
+                del self.cleaned_data["untildate"]
+            elif "fromdate" in self.cleaned_data and \
+                    untildate < self.cleaned_data["fromdate"]:
                 self._errors["untildate"] = \
                     self.error_class([_("Must be greater than start date")])
-                del self.cleaned_data['untildate']
+                del self.cleaned_data["untildate"]
         return self.cleaned_data

modoboa/extensions/postfix_autoreply/general_callbacks.py

@@ -1,8 +1,11 @@
+"""Event callbacks."""
+
 from django.utils import timezone
 from django.utils.translation import ugettext_lazy
-from modoboa.lib import events, parameters
-from modoboa.extensions.postfix_autoreply.models import Transport, Alias
+
 from .models import ARmessage
+from modoboa.extensions.postfix_autoreply.models import Transport, Alias
+from modoboa.lib import events, parameters
 
 
 @events.observe("ExtraUprefsJS")
@@ -45,8 +48,11 @@ def onDomainModified(domain):
         return
     Transport.objects.filter(domain="autoreply.%s" % domain.oldname) \
         .update(domain="autoreply.%s" % domain.name)
-    for al in Alias.objects.filter(full_address__contains="@%s" % domain.oldname):
-        new_address = al.full_address.replace("@%s" % domain.oldname, "@%s" % domain.name)
+    for al in Alias.objects.filter(
+            full_address__contains="@%s" % domain.oldname):
+        new_address = al.full_address.replace(
+            "@%s" % domain.oldname,
+            "@%s" % domain.name)
         al.full_address = new_address
         al.autoreply_address = "%s@autoreply.%s" % (new_address, domain.name)
         al.save()

modoboa/extensions/postfix_autoreply/management/commands/autoreply.py

@@ -18,7 +18,7 @@ def send_autoreply(sender, mailbox, armessage):
     if armessage.fromdate > timezone.now():
         return
     if armessage.untildate is not None \
-        and armessage.untildate < timezone.now():
+            and armessage.untildate < timezone.now():
         armessage.enabled = False
         armessage.save()
         return
@@ -51,7 +51,8 @@ class Command(BaseCommand, CloseConnectionMixin):
 
     def handle(self, *args, **options):
         if len(args) < 2:
-            raise CommandError("usage: ./manage.py autoreply <sender> <recipient ...>")
+            raise CommandError(
+                "usage: ./manage.py autoreply <sender> <recipient ...>")
 
         sender = args[0]
         for fulladdress in args[1:]:

modoboa/extensions/postfix_autoreply/tests.py

@@ -82,7 +82,6 @@ class EventsTestCase(ExtTestCase):
             ARmessage.objects.get(
                 mbox__address='user', mbox__domain__name='test.com')
 
-
     def test_modify_mailbox_event(self):
         values = {
             'username': "leon@test.com",

pylintrc

@@ -0,0 +1,329 @@
+[MASTER]
+
+# Specify a configuration file.
+#rcfile=
+
+# Python code to execute, usually for sys.path manipulation such as
+# pygtk.require().
+#init-hook=
+
+# Profiled execution.
+profile=no
+
+# Add files or directories to the blacklist. They should be base names, not
+# paths.
+ignore=CVS,migrations
+
+# Pickle collected data for later comparisons.
+persistent=yes
+
+# List of plugins (as comma separated values of python modules names) to load,
+# usually to register additional checkers.
+load-plugins=
+
+[MESSAGES CONTROL]
+
+# Enable the message, report, category or checker with the given id(s). You can
+# either give multiple identifier separated by comma (,) or put this option
+# multiple time. See also the "--disable" option for examples.
+#enable=
+
+# Disable the message, report, category or checker with the given id(s). You
+# can either give multiple identifiers separated by comma (,) or put this
+# option multiple times (only on the command line, not in the configuration
+# file where it should appear only once).You can also use "--disable=all" to
+# disable everything first and then reenable specific checks. For example, if
+# you want to run only the similarities checker, you can use "--disable=all
+# --enable=similarities". If you want to run only the classes checker, but have
+# no Warning level messages displayed, use"--disable=all --enable=classes
+# --disable=W"
+disable=no-init,no-member,locally-disabled,too-few-public-methods,too-many-public-methods,too-many-ancestors
+
+
+[REPORTS]
+
+# Set the output format. Available formats are text, parseable, colorized, msvs
+# (visual studio) and html. You can also give a reporter class, eg
+# mypackage.mymodule.MyReporterClass.
+output-format=text
+
+# Put messages in a separate file for each module / package specified on the
+# command line instead of printing them on stdout. Reports (if any) will be
+# written in a file name "pylint_global.[txt|html]".
+files-output=no
+
+# Tells whether to display a full report or only the messages
+reports=yes
+
+# Python expression which should return a note less than 10 (10 is the highest
+# note). You have access to the variables errors warning, statement which
+# respectively contain the number of errors / warnings messages and the total
+# number of statements analyzed. This is used by the global evaluation report
+# (RP0004).
+evaluation=10.0 - ((float(5 * error + warning + refactor + convention) / statement) * 10)
+
+# Add a comment according to your evaluation note. This is used by the global
+# evaluation report (RP0004).
+comment=no
+
+# Template used to display messages. This is a python new-style format string
+# used to format the message information. See doc for all details
+#msg-template=
+
+
+[LOGGING]
+
+# Logging modules to check that the string format arguments are in logging
+# function parameter format
+logging-modules=logging
+
+
+[FORMAT]
+
+# Maximum number of characters on a single line.
+max-line-length=80
+
+# Regexp for a line that is allowed to be longer than the limit.
+ignore-long-lines=^\s*(# )?<?https?://\S+>?$
+
+# Allow the body of an if to be on the same line as the test if there is no
+# else.
+single-line-if-stmt=no
+
+# List of optional constructs for which whitespace checking is disabled
+no-space-check=trailing-comma,dict-separator
+
+# Maximum number of lines in a module
+max-module-lines=1000
+
+# String used as indentation unit. This is usually " " (4 spaces) or "\t" (1
+# tab).
+indent-string='    '
+
+# Number of spaces of indent required inside a hanging or continued line.
+indent-after-paren=4
+
+
+[SIMILARITIES]
+
+# Minimum lines number of a similarity.
+min-similarity-lines=4
+
+# Ignore comments when computing similarities.
+ignore-comments=yes
+
+# Ignore docstrings when computing similarities.
+ignore-docstrings=yes
+
+# Ignore imports when computing similarities.
+ignore-imports=no
+
+
+[MISCELLANEOUS]
+
+# List of note tags to take in consideration, separated by a comma.
+notes=FIXME,XXX,TODO
+
+
+[BASIC]
+
+# Required attributes for module, separated by a comma
+required-attributes=
+
+# List of builtins function names that should not be used, separated by a comma
+bad-functions=map,filter,apply,input,file
+
+# Good variable names which should always be accepted, separated by a comma
+good-names=i,j,k,ex,Run,_,tz,logger,pk,qs
+
+# Bad variable names which should always be refused, separated by a comma
+bad-names=foo,bar,baz,toto,tutu,tata
+
+# Colon-delimited sets of names that determine each other's naming style when
+# the name regexes allow several styles.
+name-group=
+
+# Include a hint for the correct naming format with invalid-name
+include-naming-hint=no
+
+# Regular expression matching correct function names
+function-rgx=[a-z_][a-z0-9_]{2,30}$
+
+# Naming hint for function names
+function-name-hint=[a-z_][a-z0-9_]{2,30}$
+
+# Regular expression matching correct variable names
+variable-rgx=[a-z_][a-z0-9_]{2,30}$
+
+# Naming hint for variable names
+variable-name-hint=[a-z_][a-z0-9_]{2,30}$
+
+# Regular expression matching correct constant names
+const-rgx=(([A-Z_][A-Z0-9_]*)|(__.*__))$
+
+# Naming hint for constant names
+const-name-hint=(([A-Z_][A-Z0-9_]*)|(__.*__))$
+
+# Regular expression matching correct attribute names
+attr-rgx=[a-z_][a-z0-9_]{2,30}$
+
+# Naming hint for attribute names
+attr-name-hint=[a-z_][a-z0-9_]{2,30}$
+
+# Regular expression matching correct argument names
+argument-rgx=[a-z_][a-z0-9_]{2,30}$
+
+# Naming hint for argument names
+argument-name-hint=[a-z_][a-z0-9_]{2,30}$
+
+# Regular expression matching correct class attribute names
+class-attribute-rgx=([A-Za-z_][A-Za-z0-9_]{2,30}|(__.*__))$
+
+# Naming hint for class attribute names
+class-attribute-name-hint=([A-Za-z_][A-Za-z0-9_]{2,30}|(__.*__))$
+
+# Regular expression matching correct inline iteration names
+inlinevar-rgx=[A-Za-z_][A-Za-z0-9_]*$
+
+# Naming hint for inline iteration names
+inlinevar-name-hint=[A-Za-z_][A-Za-z0-9_]*$
+
+# Regular expression matching correct class names
+class-rgx=[A-Z_][a-zA-Z0-9]+$
+
+# Naming hint for class names
+class-name-hint=[A-Z_][a-zA-Z0-9]+$
+
+# Regular expression matching correct module names
+module-rgx=(([a-z_][a-z0-9_]*)|([A-Z][a-zA-Z0-9]+))$
+
+# Naming hint for module names
+module-name-hint=(([a-z_][a-z0-9_]*)|([A-Z][a-zA-Z0-9]+))$
+
+# Regular expression matching correct method names
+method-rgx=[a-z_][a-z0-9_]{2,30}$
+
+# Naming hint for method names
+method-name-hint=[a-z_][a-z0-9_]{2,30}$
+
+# Regular expression which should only match function or class names that do
+# not require a docstring.
+no-docstring-rgx=__.*__
+
+# Minimum line length for functions/classes that require docstrings, shorter
+# ones are exempt.
+docstring-min-length=-1
+
+
+[TYPECHECK]
+
+# Tells whether missing members accessed in mixin class should be ignored. A
+# mixin class is detected if its name ends with "mixin" (case insensitive).
+ignore-mixin-members=yes
+
+# List of module names for which member attributes should not be checked
+# (useful for modules/projects where namespaces are manipulated during runtime
+# and thus existing member attributes cannot be deduced by static analysis
+ignored-modules=
+
+# List of classes names for which member attributes should not be checked
+# (useful for classes with attributes dynamically set).
+ignored-classes=SQLObject
+
+# When zope mode is activated, add a predefined set of Zope acquired attributes
+# to generated-members.
+zope=no
+
+# List of members which are set dynamically and missed by pylint inference
+# system, and so shouldn't trigger E0201 when accessed. Python regular
+# expressions are accepted.
+generated-members=REQUEST,acl_users,aq_parent
+
+
+[VARIABLES]
+
+# Tells whether we should check for unused import in __init__ files.
+init-import=no
+
+# A regular expression matching the name of dummy variables (i.e. expectedly
+# not used).
+dummy-variables-rgx=_$|dummy
+
+# List of additional names supposed to be defined in builtins. Remember that
+# you should avoid to define new builtins when possible.
+additional-builtins=
+
+
+[DESIGN]
+
+# Maximum number of arguments for function / method
+max-args=5
+
+# Argument names that match this expression will be ignored. Default to name
+# with leading underscore
+ignored-argument-names=_.*
+
+# Maximum number of locals for function / method body
+max-locals=15
+
+# Maximum number of return / yield for function / method body
+max-returns=6
+
+# Maximum number of branch for function / method body
+max-branches=12
+
+# Maximum number of statements in function / method body
+max-statements=50
+
+# Maximum number of parents for a class (see R0901).
+max-parents=7
+
+# Maximum number of attributes for a class (see R0902).
+max-attributes=7
+
+# Minimum number of public methods for a class (see R0903).
+min-public-methods=2
+
+# Maximum number of public methods for a class (see R0904).
+max-public-methods=20
+
+
+[CLASSES]
+
+# List of interface methods to ignore, separated by a comma. This is used for
+# instance to not check methods defines in Zope's Interface base class.
+ignore-iface-methods=isImplementedBy,deferred,extends,names,namesAndDescriptions,queryDescriptionFor,getBases,getDescriptionFor,getDoc,getName,getTaggedValue,getTaggedValueTags,isEqualOrExtendedBy,setTaggedValue,isImplementedByInstancesOf,adaptWith,is_implemented_by
+
+# List of method names used to declare (i.e. assign) instance attributes.
+defining-attr-methods=__init__,__new__,setUp
+
+# List of valid names for the first argument in a class method.
+valid-classmethod-first-arg=cls
+
+# List of valid names for the first argument in a metaclass class method.
+valid-metaclass-classmethod-first-arg=mcs
+
+
+[IMPORTS]
+
+# Deprecated modules which should not be used, separated by a comma
+deprecated-modules=regsub,TERMIOS,Bastion,rexec
+
+# Create a graph of every (i.e. internal and external) dependencies in the
+# given file (report RP0402 must not be disabled)
+import-graph=
+
+# Create a graph of external dependencies in the given file (report RP0402 must
+# not be disabled)
+ext-import-graph=
+
+# Create a graph of internal dependencies in the given file (report RP0402 must
+# not be disabled)
+int-import-graph=
+
+
+[EXCEPTIONS]
+
+# Exceptions that will emit a warning when being caught. Defaults to
+# "Exception"
+overgeneral-exceptions=Exception