Fixed wrong exception handling

This commit is contained in:
Antoine Nguyen
2023-12-21 18:17:54 +01:00
parent d3398cc51f
commit 0d5e8b2607
2 changed files with 4 additions and 2 deletions
+3 -1
View File
@@ -471,8 +471,10 @@ class AliasSerializer(serializers.ModelSerializer):
try:
local_part, self.domain = admin_models.validate_alias_address(
value, self.context["request"].user, instance=self.instance)
except (AliasExists, ValidationError) as err:
except ValidationError as err:
raise serializers.ValidationError(err)
except AliasExists:
raise serializers.ValidationError(_("This alias already exists"))
return value.lower()
def create(self, validated_data):
+1 -1
View File
@@ -535,7 +535,7 @@ class AliasViewSetTestCase(ModoAPITestCase):
data = {"address": "alias@test.com"}
resp = self.client.post(url, data, format="json")
self.assertEqual(resp.status_code, 409)
self.assertEqual(resp.status_code, 400)
al_id = models.Alias.objects.get(address="alias@test.com").pk
self.assertEqual(resp.json()["id"], al_id)