github-jwinterm/grin-wallet
1
0
Fork 0
mirror of https://github.com/jwinterm/grin-wallet.git synced 2026-10-17 07:11:36 +02:00
Code Issues Packages Projects Releases Wiki Activity

Contracts: reject a slate that already has all participants

Browse Source 
add_keys added our participant info without checking the slate wasn't already
full, so a tampered slate could exceed num_participants. Block adding when the
participant set is already full and we aren't already in it (re-adding our own
info stays idempotent).

Addresses PR #754 review (slate.rs).
This commit is contained in:
jwinterm
2026-06-07 17:00:50 -04:00
parent 9bf11fbc8d
commit 7982f17926
1 changed files with 14 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
libwallet/src/contract/slate.rs
+14 -2
View File
@@ -17,7 +17,7 @@
use crate::grin_core::libtx::build;
use crate::grin_core::libtx::proof::ProofBuilder;
use crate::grin_keychain::Keychain;
use crate::grin_util::secp::key::SecretKey;
use crate::grin_util::secp::key::{PublicKey, SecretKey};
use crate::slate::{Slate, SlateState};
use crate::types::{Context, NodeClient, WalletBackend};
use crate::Error;
@@ -255,6 +255,18 @@ where
K: Keychain,
{
debug!("contract::slate::add_keys => called");
// TODO: Is this safe from manipulation?
// Guard against a tampered slate that already carries the full participant set.
// Re-adding our own info is idempotent, so only block when we are not already in it.
let our_pub_key = PublicKey::from_secret_key(keychain.secp(), &context.sec_key)?;
let already_ours = slate
.participant_data
.iter()
.any(|p| p.public_blind_excess == our_pub_key);
if !already_ours && slate.participant_data.len() >= slate.num_participants as usize {
return Err(Error::GenericError(format!(
"Slate already has the expected {} participant(s)",
slate.num_participants
)));
}
slate.add_participant_info(keychain, context, None)
}