Builds/hash-wallet
1
0
Fork 0
forked from github-such-software/hash-wallet
Code Pull Requests Actions Activity

Windows CI: mirror monero/wownero DLLs under lib-prefixed names #35

Merged
such-gitea merged 1 commits from github-such-software/hash-wallet:dev into dev 2026-05-20 20:13:47 -04:00
Conversation 0 Commits 1 Files Changed 1 +20 -4
such-gitea commented 2026-05-20 20:13:42 -04:00
Owner
Copy Link

cw_monero + cw_wownero use package:monero's Dart FFI loader (mrcyjanek's
package), which expects DLLs named:
libmonero_wallet2_api_c.dll
libwownero_wallet2_api_c.dll
But windows/CMakeLists.txt's install rules RENAME to a different layout:
monero_libwallet2_api_c.dll
wownero_libwallet2_api_c.dll
This naming-convention mismatch causes hash_wallet.exe to crash at
wallet-create time:
Failed to load dynamic library 'libwownero_wallet2_api_c.dll':
The specified module could not be found.

Post-build step that creates the lib-prefixed copies. Defensive — keeps
both names so any upstream code that expects either layout still works.

Issue Number (if Applicable): Fixes #

Description

Please include a summary of the changes and which issue is fixed / feature is added.

Pull Request - Checklist

  • Initial Manual Tests Passed
  • Double check modified code and verify it with the feature/task requirements
  • Format code
  • Look for code duplication
  • Clear naming for variables and methods
  • Manual tests in accessibility mode (TalkBack on Android) passed
cw_monero + cw_wownero use package:monero's Dart FFI loader (mrcyjanek's package), which expects DLLs named: libmonero_wallet2_api_c.dll libwownero_wallet2_api_c.dll But windows/CMakeLists.txt's install rules RENAME to a different layout: monero_libwallet2_api_c.dll wownero_libwallet2_api_c.dll This naming-convention mismatch causes hash_wallet.exe to crash at wallet-create time: Failed to load dynamic library 'libwownero_wallet2_api_c.dll': The specified module could not be found. Post-build step that creates the lib-prefixed copies. Defensive — keeps both names so any upstream code that expects either layout still works. Issue Number (if Applicable): Fixes # # Description Please include a summary of the changes and which issue is fixed / feature is added. # Pull Request - Checklist - [ ] Initial Manual Tests Passed - [ ] Double check modified code and verify it with the feature/task requirements - [ ] Format code - [ ] Look for code duplication - [ ] Clear naming for variables and methods - [ ] Manual tests in accessibility mode (TalkBack on Android) passed
such-gitea added 1 commit 2026-05-20 20:13:42 -04:00
Windows CI: mirror monero/wownero DLLs under lib-prefixed names cfc619cbc8 
cw_monero + cw_wownero use package:monero's Dart FFI loader (mrcyjanek's
package), which expects DLLs named:
  libmonero_wallet2_api_c.dll
  libwownero_wallet2_api_c.dll
But windows/CMakeLists.txt's install rules RENAME to a different layout:
  monero_libwallet2_api_c.dll
  wownero_libwallet2_api_c.dll
This naming-convention mismatch causes hash_wallet.exe to crash at
wallet-create time:
  Failed to load dynamic library 'libwownero_wallet2_api_c.dll':
  The specified module could not be found.

Post-build step that creates the lib-prefixed copies. Defensive — keeps
both names so any upstream code that expects either layout still works.
such-gitea merged commit ed19fdfd2b into dev 2026-05-20 20:13:47 -04:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
such-gitea
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Builds/hash-wallet#35
Delete Branch "github-such-software/hash-wallet:dev"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?