Builds/hash-wallet
1
0
Fork 0
forked from github-such-software/hash-wallet
Code Pull Requests Actions Activity

Windows CI: source MinGW runtime DLLs from Git Bash, not monero_c bundle #32

Merged
such-gitea merged 1 commits from github-such-software/hash-wallet:dev into dev 2026-05-20 18:58:05 -04:00
Conversation 0 Commits 1 Files Changed 1 +18 -7
such-gitea commented 2026-05-20 18:58:01 -04:00
Owner
Copy Link

MrCyjaneK's monero_c release-bundle.zip ships only the wallet libs +
import libs:
libmonero_wallet2_api_c.dll{,.a}
libwownero_wallet2_api_c.dll{,.a}
The MinGW runtime DLLs the wallet libs are dynamically linked against
(libssp-0.dll, libwinpthread-1.dll) are NOT in the bundle. The previous
staging step failed with "libssp-0.dll not in bundle".

Git for Windows bundles MinGW-w64 and ships those exact DLLs at
C:\Program Files\Git\mingw64\bin. Same x86_64-w64-mingw32 ABI used to
build the wallet libs, so ABI-compatible. Fall back to that location
(or MSYS2 /mingw64/bin/ if present) when the monero_c bundle lacks them.

Issue Number (if Applicable): Fixes #

Description

Please include a summary of the changes and which issue is fixed / feature is added.

Pull Request - Checklist

  • Initial Manual Tests Passed
  • Double check modified code and verify it with the feature/task requirements
  • Format code
  • Look for code duplication
  • Clear naming for variables and methods
  • Manual tests in accessibility mode (TalkBack on Android) passed
MrCyjaneK's monero_c release-bundle.zip ships only the wallet libs + import libs: libmonero_wallet2_api_c.dll{,.a} libwownero_wallet2_api_c.dll{,.a} The MinGW runtime DLLs the wallet libs are dynamically linked against (libssp-0.dll, libwinpthread-1.dll) are NOT in the bundle. The previous staging step failed with "libssp-0.dll not in bundle". Git for Windows bundles MinGW-w64 and ships those exact DLLs at C:\Program Files\Git\mingw64\bin\. Same x86_64-w64-mingw32 ABI used to build the wallet libs, so ABI-compatible. Fall back to that location (or MSYS2 /mingw64/bin/ if present) when the monero_c bundle lacks them. Issue Number (if Applicable): Fixes # # Description Please include a summary of the changes and which issue is fixed / feature is added. # Pull Request - Checklist - [ ] Initial Manual Tests Passed - [ ] Double check modified code and verify it with the feature/task requirements - [ ] Format code - [ ] Look for code duplication - [ ] Clear naming for variables and methods - [ ] Manual tests in accessibility mode (TalkBack on Android) passed
such-gitea added 1 commit 2026-05-20 18:58:01 -04:00
Windows CI: source MinGW runtime DLLs from Git Bash, not monero_c bundle 41c41118d5 
MrCyjaneK's monero_c release-bundle.zip ships only the wallet libs +
import libs:
  libmonero_wallet2_api_c.dll{,.a}
  libwownero_wallet2_api_c.dll{,.a}
The MinGW runtime DLLs the wallet libs are dynamically linked against
(libssp-0.dll, libwinpthread-1.dll) are NOT in the bundle. The previous
staging step failed with "libssp-0.dll not in bundle".

Git for Windows bundles MinGW-w64 and ships those exact DLLs at
C:\Program Files\Git\mingw64\bin\. Same x86_64-w64-mingw32 ABI used to
build the wallet libs, so ABI-compatible. Fall back to that location
(or MSYS2 /mingw64/bin/ if present) when the monero_c bundle lacks them.
such-gitea merged commit c4f19736af into dev 2026-05-20 18:58:05 -04:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
such-gitea
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Builds/hash-wallet#32
Delete Branch "github-such-software/hash-wallet:dev"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?