Builds/hash-wallet
1
0
Fork 0
forked from github-such-software/hash-wallet
Code Pull Requests Actions Activity

dev #31

Merged
such-gitea merged 2 commits from github-such-software/hash-wallet:dev into dev 2026-05-20 18:46:06 -04:00
Conversation 0 Commits 2 Files Changed 1 +52 -4
such-gitea commented 2026-05-20 18:46:01 -04:00
Owner
Copy Link

Issue Number (if Applicable): Fixes #

Description

Please include a summary of the changes and which issue is fixed / feature is added.

Pull Request - Checklist

  • Initial Manual Tests Passed
  • Double check modified code and verify it with the feature/task requirements
  • Format code
  • Look for code duplication
  • Clear naming for variables and methods
  • Manual tests in accessibility mode (TalkBack on Android) passed
Issue Number (if Applicable): Fixes # # Description Please include a summary of the changes and which issue is fixed / feature is added. # Pull Request - Checklist - [ ] Initial Manual Tests Passed - [ ] Double check modified code and verify it with the feature/task requirements - [ ] Format code - [ ] Look for code duplication - [ ] Clear naming for variables and methods - [ ] Manual tests in accessibility mode (TalkBack on Android) passed
such-gitea added 2 commits 2026-05-20 18:46:01 -04:00
Windows CI: stage monero/wownero DLLs into Release dir after build 1242690835 
The monero_c v0.18.4.6-RC1-2-gbc8d*a0 release bundle ships pre-built
MinGW Windows DLLs at x86_64-w64-mingw32/libmonero_wallet2_api_c.dll +
libwownero_wallet2_api_c.dll. cw_monero / cw_wownero load them at
runtime via Dart FFI DynamicLibrary.open, so they don't need to link at
flutter build windows time — but they DO need to be in the Windows DLL
search path when hash_wallet.exe runs. Easiest: drop them next to the
.exe in the Release dir before we zip.

Copy under both naming conventions (lib<coin>_wallet2_api_c.dll and
<coin>_libwallet2_api_c.dll) since the Dart-side libPath constant in
package:monero may or may not include the `lib` prefix depending on
build flavor. ~30 MB cost.
Windows CI: stage monero_c bundle into upstream cross-compile layout 11c11098e1 
windows/CMakeLists.txt (lines 84-94) install rules expect monero_c DLLs
at the layout that scripts/windows/build_all.sh produces when cross-
compiling on Linux:
  scripts/monero_c/release/<coin>/<triple>_<basename>.dll
But we use MrCyjaneK's prebuilt release bundle which lays files out as:
  scripts/monero_c/release/<TAG>/<triple>/lib<coin>_wallet2_api_c.dll

Restage the bundle into the cross-compile-style layout before
flutter build windows runs. CMake's install() RENAMEs the staged files
to the final monero_libwallet2_api_c.dll / wownero_libwallet2_api_c.dll
names in the Release dir — no post-build copy needed, so the previous
"Stage monero/wownero DLLs into Release dir" step is removed.

Also includes libssp-0.dll + libwinpthread-1.dll (MinGW runtime DLLs
the wallet libs depend on at load time), staged from the same bundle.
such-gitea merged commit ade520432d into dev 2026-05-20 18:46:06 -04:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
such-gitea
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Builds/hash-wallet#31
Delete Branch "github-such-software/hash-wallet:dev"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?