Builds/hash-wallet
1
0
Fork 0
forked from github-such-software/hash-wallet
Code Pull Requests Actions Activity

Windows CI: configure git identity before any submodule ops #30

Merged
such-gitea merged 1 commits from github-such-software/hash-wallet:dev into dev 2026-05-20 15:27:25 -04:00
Conversation 0 Commits 1 Files Changed 1 +13
such-gitea commented 2026-05-20 15:27:19 -04:00
Owner
Copy Link

scripts/monero_c/apply_patches.sh (run by prepare_moneroc.sh) does
git-commit-equivalents that fail when the user.email + user.name aren't
set. The runner service runs as LocalSystem, which has no global git
config — git rejects with:

fatal: unable to auto-detect email address
(got 'SYSTEM@DESKTOP-IIM2FS2.(none)')

Add a "Configure git identity + safe.directory" step right after
checkout, mirroring the Android workflow's "Configure git inside the
container" step. Also pre-empt git's safe.directory check, since the
checkout dir owner may not match the LocalSystem identity.

Issue Number (if Applicable): Fixes #

Description

Please include a summary of the changes and which issue is fixed / feature is added.

Pull Request - Checklist

  • Initial Manual Tests Passed
  • Double check modified code and verify it with the feature/task requirements
  • Format code
  • Look for code duplication
  • Clear naming for variables and methods
  • Manual tests in accessibility mode (TalkBack on Android) passed
scripts/monero_c/apply_patches.sh (run by prepare_moneroc.sh) does git-commit-equivalents that fail when the user.email + user.name aren't set. The runner service runs as LocalSystem, which has no global git config — git rejects with: fatal: unable to auto-detect email address (got 'SYSTEM@DESKTOP-IIM2FS2.(none)') Add a "Configure git identity + safe.directory" step right after checkout, mirroring the Android workflow's "Configure git inside the container" step. Also pre-empt git's safe.directory check, since the checkout dir owner may not match the LocalSystem identity. Issue Number (if Applicable): Fixes # # Description Please include a summary of the changes and which issue is fixed / feature is added. # Pull Request - Checklist - [ ] Initial Manual Tests Passed - [ ] Double check modified code and verify it with the feature/task requirements - [ ] Format code - [ ] Look for code duplication - [ ] Clear naming for variables and methods - [ ] Manual tests in accessibility mode (TalkBack on Android) passed
such-gitea added 1 commit 2026-05-20 15:27:20 -04:00
Windows CI: configure git identity before any submodule ops 75325a2f24 
scripts/monero_c/apply_patches.sh (run by prepare_moneroc.sh) does
git-commit-equivalents that fail when the user.email + user.name aren't
set. The runner service runs as LocalSystem, which has no global git
config — git rejects with:

  fatal: unable to auto-detect email address
  (got 'SYSTEM@DESKTOP-IIM2FS2.(none)')

Add a "Configure git identity + safe.directory" step right after
checkout, mirroring the Android workflow's "Configure git inside the
container" step. Also pre-empt git's safe.directory check, since the
checkout dir owner may not match the LocalSystem identity.
such-gitea merged commit ab22c8c602 into dev 2026-05-20 15:27:25 -04:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
such-gitea
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Builds/hash-wallet#30
Delete Branch "github-such-software/hash-wallet:dev"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?