Builds/hash-wallet
1
0
Fork 0
forked from github-such-software/hash-wallet
Code Pull Requests Actions Activity

Windows CI: use explicit Git Bash path instead of shell: bash #27

Merged
such-gitea merged 1 commits from github-such-software/hash-wallet:dev into dev 2026-05-20 13:22:48 -04:00
Conversation 0 Commits 1 Files Changed 1 +7 -4
such-gitea commented 2026-05-20 13:22:43 -04:00
Owner
Copy Link

shell: bash on the Windows runner resolves via PATH to
C:\Windows\System32\bash.exe — that's WSL's bash. WSL refuses to launch
under LocalSystem (which our NSSM-managed act_runner service runs as):

Running WSL as local system is not supported.
Error code: Bash/WSL_E_LOCAL_SYSTEM_NOT_SUPPORTED

GitHub's hosted windows-latest avoids this by putting Git Bash earlier in
PATH. Tried the same on our runner (prepending C:\Program Files\Git\bin)
but the service's PATH didn't reflect the change post-restart. Rather
than fight Windows env propagation, just point shell at Git Bash
directly. Deterministic, no PATH dependency.

Issue Number (if Applicable): Fixes #

Description

Please include a summary of the changes and which issue is fixed / feature is added.

Pull Request - Checklist

  • Initial Manual Tests Passed
  • Double check modified code and verify it with the feature/task requirements
  • Format code
  • Look for code duplication
  • Clear naming for variables and methods
  • Manual tests in accessibility mode (TalkBack on Android) passed
`shell: bash` on the Windows runner resolves via PATH to C:\Windows\System32\bash.exe — that's WSL's bash. WSL refuses to launch under LocalSystem (which our NSSM-managed act_runner service runs as): Running WSL as local system is not supported. Error code: Bash/WSL_E_LOCAL_SYSTEM_NOT_SUPPORTED GitHub's hosted windows-latest avoids this by putting Git Bash earlier in PATH. Tried the same on our runner (prepending C:\Program Files\Git\bin) but the service's PATH didn't reflect the change post-restart. Rather than fight Windows env propagation, just point shell at Git Bash directly. Deterministic, no PATH dependency. Issue Number (if Applicable): Fixes # # Description Please include a summary of the changes and which issue is fixed / feature is added. # Pull Request - Checklist - [ ] Initial Manual Tests Passed - [ ] Double check modified code and verify it with the feature/task requirements - [ ] Format code - [ ] Look for code duplication - [ ] Clear naming for variables and methods - [ ] Manual tests in accessibility mode (TalkBack on Android) passed
such-gitea added 1 commit 2026-05-20 13:22:44 -04:00
Windows CI: use explicit Git Bash path instead of shell: bash 87636d9442 
`shell: bash` on the Windows runner resolves via PATH to
C:\Windows\System32\bash.exe — that's WSL's bash. WSL refuses to launch
under LocalSystem (which our NSSM-managed act_runner service runs as):

  Running WSL as local system is not supported.
  Error code: Bash/WSL_E_LOCAL_SYSTEM_NOT_SUPPORTED

GitHub's hosted windows-latest avoids this by putting Git Bash earlier in
PATH. Tried the same on our runner (prepending C:\Program Files\Git\bin)
but the service's PATH didn't reflect the change post-restart. Rather
than fight Windows env propagation, just point shell at Git Bash
directly. Deterministic, no PATH dependency.
such-gitea merged commit 04c2d2b379 into dev 2026-05-20 13:22:48 -04:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
such-gitea
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Builds/hash-wallet#27
Delete Branch "github-such-software/hash-wallet:dev"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?