Builds/hash-wallet
1
0
Fork 0
forked from github-such-software/hash-wallet
Code Pull Requests Actions Activity

Fix orphan references after shitcoin nuke (build round 2) #12

Merged
such-gitea merged 1 commits from github-such-software/hash-wallet:dev into dev 2026-05-17 19:21:19 -04:00
Conversation 0 Commits 1 Files Changed 8 +2 -205
such-gitea commented 2026-05-17 19:21:11 -04:00
Owner
Copy Link

Stragglers that weren't in any agent's batch but referenced the removed
identifiers:

  • tool/configure.dart: stripped 'backupSeeds(Box)'
    abstract method from generateWownero's emitted template + the
    haven_seed_store.dart import. CI regenerates lib/wownero/wownero.dart
    from this template each build, so the previous lib/wownero/wownero.dart
    cleanup got reverted on rebuild. This is the actual fix.
  • lib/core/trade_monitor.dart + lib/view_model/trade_details_view_model.dart:
    removed JupiterExchangeProvider import + ExchangeProviderDescription.jupiter
    switch cases (provider + URL builder).
  • lib/src/screens/dashboard/dashboard_page.dart: deleted _showHavenPopup
    helper + its call site + the haven_wallet_removal_popup import.
  • lib/src/widgets/haven_wallet_removal_popup.dart: deleted (no callers).
  • lib/src/screens/dashboard/pages/balance/crypto_balance_widget.dart:
    removed the zcash 'missing funds' InfoCard and the decred 'syncing'
    InfoCard widgets, plus their _dismissZcash and _rescanInternalChangeZcash
    handlers.
  • lib/src/screens/settings/connection_sync_page.dart: removed the TronGrid
    history toggle row.
  • lib/src/widgets/bottom_sheet/payment_confirmation_bottom_sheet.dart:
    _isTokenSelectionFlow now only checks evmNetworkSelection (was also
    branching on solana/tronTokenSelection enum values that no longer exist).

Generated .g.dart files for dashboard_view_model and connection_sync_view_model
still reference removed methods (rescanInternalChangeZcash, dismissZcash,
canUseTronGrid, setUseTronGrid). Those will be regenerated by build_runner
on next CI run and the methods will fall out — no manual fix needed.

Issue Number (if Applicable): Fixes #

Description

Please include a summary of the changes and which issue is fixed / feature is added.

Pull Request - Checklist

  • Initial Manual Tests Passed
  • Double check modified code and verify it with the feature/task requirements
  • Format code
  • Look for code duplication
  • Clear naming for variables and methods
  • Manual tests in accessibility mode (TalkBack on Android) passed
Stragglers that weren't in any agent's batch but referenced the removed identifiers: - tool/configure.dart: stripped 'backupSeeds(Box<HavenSeedStore>)' abstract method from generateWownero's emitted template + the haven_seed_store.dart import. CI regenerates lib/wownero/wownero.dart from this template each build, so the previous lib/wownero/wownero.dart cleanup got reverted on rebuild. This is the actual fix. - lib/core/trade_monitor.dart + lib/view_model/trade_details_view_model.dart: removed JupiterExchangeProvider import + ExchangeProviderDescription.jupiter switch cases (provider + URL builder). - lib/src/screens/dashboard/dashboard_page.dart: deleted _showHavenPopup helper + its call site + the haven_wallet_removal_popup import. - lib/src/widgets/haven_wallet_removal_popup.dart: deleted (no callers). - lib/src/screens/dashboard/pages/balance/crypto_balance_widget.dart: removed the zcash 'missing funds' InfoCard and the decred 'syncing' InfoCard widgets, plus their _dismissZcash and _rescanInternalChangeZcash handlers. - lib/src/screens/settings/connection_sync_page.dart: removed the TronGrid history toggle row. - lib/src/widgets/bottom_sheet/payment_confirmation_bottom_sheet.dart: _isTokenSelectionFlow now only checks evmNetworkSelection (was also branching on solana/tronTokenSelection enum values that no longer exist). Generated .g.dart files for dashboard_view_model and connection_sync_view_model still reference removed methods (rescanInternalChangeZcash, dismissZcash, canUseTronGrid, setUseTronGrid). Those will be regenerated by build_runner on next CI run and the methods will fall out — no manual fix needed. Issue Number (if Applicable): Fixes # # Description Please include a summary of the changes and which issue is fixed / feature is added. # Pull Request - Checklist - [ ] Initial Manual Tests Passed - [ ] Double check modified code and verify it with the feature/task requirements - [ ] Format code - [ ] Look for code duplication - [ ] Clear naming for variables and methods - [ ] Manual tests in accessibility mode (TalkBack on Android) passed
such-gitea added 1 commit 2026-05-17 19:21:11 -04:00
Fix orphan references after shitcoin nuke (build round 2)
All checks were successful
Hash Wallet Linux build / build (pull_request) Successful in 9m45s
Details
f1fffddf90 
Stragglers that weren't in any agent's batch but referenced the removed
identifiers:

- tool/configure.dart: stripped 'backupSeeds(Box<HavenSeedStore>)'
  abstract method from generateWownero's emitted template + the
  haven_seed_store.dart import. CI regenerates lib/wownero/wownero.dart
  from this template each build, so the previous lib/wownero/wownero.dart
  cleanup got reverted on rebuild. This is the actual fix.
- lib/core/trade_monitor.dart + lib/view_model/trade_details_view_model.dart:
  removed JupiterExchangeProvider import + ExchangeProviderDescription.jupiter
  switch cases (provider + URL builder).
- lib/src/screens/dashboard/dashboard_page.dart: deleted _showHavenPopup
  helper + its call site + the haven_wallet_removal_popup import.
- lib/src/widgets/haven_wallet_removal_popup.dart: deleted (no callers).
- lib/src/screens/dashboard/pages/balance/crypto_balance_widget.dart:
  removed the zcash 'missing funds' InfoCard and the decred 'syncing'
  InfoCard widgets, plus their _dismissZcash and _rescanInternalChangeZcash
  handlers.
- lib/src/screens/settings/connection_sync_page.dart: removed the TronGrid
  history toggle row.
- lib/src/widgets/bottom_sheet/payment_confirmation_bottom_sheet.dart:
  _isTokenSelectionFlow now only checks evmNetworkSelection (was also
  branching on solana/tronTokenSelection enum values that no longer exist).

Generated .g.dart files for dashboard_view_model and connection_sync_view_model
still reference removed methods (rescanInternalChangeZcash, dismissZcash,
canUseTronGrid, setUseTronGrid). Those will be regenerated by build_runner
on next CI run and the methods will fall out — no manual fix needed.
such-gitea merged commit 2867836992 into dev 2026-05-17 19:21:19 -04:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
such-gitea
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Builds/hash-wallet#12
Delete Branch "github-such-software/hash-wallet:dev"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?