Commit Graph
7823 Commits
Author SHA1 Message Date
selstaandsuch-gitea ed8fc0a8fd p2p: restore safe sync mode when target height drops
(cherry picked from commit 12098ff5d66d86d73360d28c548c350f6e7b64c8)
2026-10-04 18:50:21 -04:00
selstaandsuch-gitea e9aa147fb3 wallet2: guard optimized coinbase refresh against empty vout
(cherry picked from commit ef7a86c99f7c58c361c3c0ddf5687a165c22ce7a)
2026-10-04 18:50:20 -04:00
selstaandsuch-gitea 06fa8be413 wallet2: reject non-monotonic rct output distributions
(cherry picked from commit b99d15f08d80a8cad6dee88628192ba0411544fb)
2026-10-04 18:50:20 -04:00
selstaandsuch-gitea 16045bb71d net: cap aggregate ZMQ receive size
(cherry picked from commit 4f6652f356f804403f46ecbbb8b90c1c03abbc64)
2026-10-04 18:50:20 -04:00
selstaandsuch-gitea 77fed902b3 wallet2: store multisig nonce erasure before returning signed txset
(cherry picked from commit d6f0a4d211cc419095e778a39a83d65000e47bf6)
2026-10-04 18:50:20 -04:00
woodserandsuch-gitea 314bad4880 fix typo in hashchain bounds error
(cherry picked from commit ad72a6c25342bc1694a787ba583e44beebea75e9)
2026-10-04 18:50:20 -04:00
SChernykhandsuch-gitea 8efb829f2c Miner: fixed thread 0 always mining with secure JIT (worse performance)
(cherry picked from commit 0859397f21457d42635d8c638558ed503ff65fa0)
2026-10-04 18:50:20 -04:00
SChernykhandsuch-gitea aded798c27 Fix: check hwdev.generate_output_ephemeral_keys result
If it fails, out_eph_public_key and view_tag remain uninitialized.

(cherry picked from commit 2de5e8227f356c31784e249ca5317e7faf4ba969)
2026-10-04 18:50:20 -04:00
SChernykhandsuch-gitea eb71cc9633 Blockchain: fix wrong block_weight in handle_get_objects
- When there are missing IDs, blocks.size() != arg.blocks.size(), so arg.blocks can't be indexed by `i` - the indices will be wrong, the wrong weight will be returned to some peer and this peer will ban our node.

Use `bl.second` instead of `arg.blocks[i]`. Also it saves one DB query per returned block.

(cherry picked from commit 3d856f4825283e66a7ebbe9ac32e3f864bc906e2)
2026-10-04 18:50:20 -04:00
SChernykhandsuch-gitea d894ac3ba6 tx_pool: fix use-after-free in prune()
- txid was a reference to an item which was later deleted in remove_tx_from_transient_lists(), and txid was used after that

(cherry picked from commit ab6a1c8a3da2b252599fcb72c16f26fa56ba4cc8)
2026-10-04 18:50:20 -04:00
SChernykhandsuch-gitea 8ffd095a90 Multisig tx builder: fix incomplete memory wipe
(cherry picked from commit 00a444b1167119a8a6d5c133d8e32240249b76f9)
2026-10-04 18:50:20 -04:00
selstaandsuch-gitea 08cc86ab88 net: canonicalize Tor/I2P hosts during deserialization
(cherry picked from commit 93d792e63c85baec6f8a3b8f9bbad3f803dd3a7e)
2026-10-04 18:50:20 -04:00
SChernykhandsuch-gitea 78fc142418 wallet2: fix double unlock of a lock
(cherry picked from commit 2b97e3ae049cc872c29b6994304a1e65d8338caa)
2026-10-04 18:50:20 -04:00
selstaandsuch-gitea d171742ed6 p2p: close zone connections before stopping net servers
(cherry picked from commit b7ca9e73f23cfb0ce1e795b2074ad12af56b04e3)
2026-10-04 18:50:20 -04:00
selstaandsuch-gitea 1e17dc299a p2p: make stop signal idempotent
(cherry picked from commit ec60113e09d9fc985b1c35fe1c579ef73c067d91)
2026-10-04 18:50:20 -04:00
SChernykhandsuch-gitea d5bbcefc87 Fixed dangling iterator in is_remote_host_allowed
- m_blocked_subnets.erase(it) either moves it to the next entry, or sets it to m_blocked_subnets.end() in which case the MCLOG_CYAN will access invalid data

(cherry picked from commit e354264e0c046454dc01f71eeb3fe8098e248ec6)
2026-10-04 18:50:20 -04:00
selstaandsuch-gitea f8052081f3 net: canonicalize Tor and I2P hostnames
(cherry picked from commit 7d339778135c44370199f5c84e8c90b3d60f6717)
2026-10-04 18:50:20 -04:00
selstaandsuch-gitea 9ee36bbac3 serialization: handle EOF at varint boundary
(cherry picked from commit 7a7c42ffba1da6bd3f7bfd5a09ef9ae7275537a6)
2026-10-04 18:50:19 -04:00
selstaandsuch-gitea 72da5948b6 wallet2: clear m_additional_tx_keys during bg sync
(cherry picked from commit 4b00f47d43d784447904d777f220a525044a3374)
2026-10-04 18:50:19 -04:00
selstaandsuch-gitea 8967c814b3 wallet_rpc_server: remove unused finalize_multisig endpoint
(cherry picked from commit 6d36b1980d9b827117e293b3ca8a6b509b592b1a)
2026-10-04 18:50:19 -04:00
jeffro256andsuch-gitea 109c08f189 daemon: fix print_cn command when 0 connections
Deferencing the result of `std::max_element()` when `res.connections` has 0 elements leads to UB, and segfaults in practice.

Co-authored-by: iamamyth <user@example.com>
(cherry picked from commit 7c543c82205c3522510e8da616edc795922ce9f3)
2026-10-04 18:50:19 -04:00
Guillaume Le Vaillantandsuch-gitea 83793218ce Show IPv6 addresses in connection list
(cherry picked from commit 528cbac17a6c372d1698c82e30df0fdfc78a5ccc)
2026-10-04 18:50:19 -04:00
selstaandsuch-gitea 2b502bb25b rpc: restrict get_alt_blocks_hashes
(cherry picked from commit 7de175802a48caa7b96e516138de6cdc914bdc76)
2026-10-04 18:50:19 -04:00
selstaandsuch-gitea d94591b63e daemonizer: avoid unsafe pidfile truncation
(cherry picked from commit 4167923ee21cba06f311bebab29206b1f894b067)
2026-10-04 18:50:19 -04:00
jeffro256andsuch-gitea 2ef8b04e33 wallet: fix RPC describe transfer source entry
(cherry picked from commit 8bcbeafb97d4a67b5d8d08695e115a3a9b5e1829)
2026-10-04 18:50:19 -04:00
selstaandsuch-gitea f201dc06dc wallet_rpc_server: preserve payment ID when editing address book
(cherry picked from commit 6db72c40e1764b04ab149114025da5fa7a1da7b6)
2026-10-04 18:50:19 -04:00
selstaandsuch-gitea d7c41d7ace rpc: reject invalid JSON-RPC ids in ZMQ requests
(cherry picked from commit a16f514c67e95cec4946dc83dbad04ed1baad023)
2026-10-04 18:50:19 -04:00
ComputeryPonyandsuch-gitea f46a8ae974 crypto: implement CTHR_THREAD_CLOSE to avoid leaking memory
(cherry picked from commit dede3a5d7198b675afd480a4c9aa9715746e3dae)
2026-10-04 18:50:19 -04:00
greatjourney589andsuch-gitea c3e982f2ad zmq: apply restricted-mode privacy filtering to get_transaction_pool
Add an include_sensitive parameter to tx_memory_pool::get_pool_for_rpc
(and its core passthrough), mirroring the include_sensitive_data
parameter on the HTTP analog get_transactions_and_spent_keys_info.
When false, receive_time and last_relayed_time are zeroed using the
same masking already applied on the HTTP path.

The ZMQ handler in daemon_handler.cpp passes !m_restricted, so
--restricted-zmq-rpc callers now receive the same privacy-filtered view
as restricted HTTP callers instead of the unfiltered timing metadata
they previously got. Stem-phase txs continue to be excluded regardless
(relay_category::broadcasted filter unchanged).

Refs #10529.

(cherry picked from commit 878c781764e62d8616ae49a42baf05366a1d7336)
2026-10-04 18:50:19 -04:00
selstaandsuch-gitea f9253a9ec0 wallet_rpc_server: add missing trusted daemon check
(cherry picked from commit 7e70e0fb9359507bc1cd7e75eb73d82a9001d005)
2026-10-04 18:50:19 -04:00
selstaandsuch-gitea 3e3351ad24 zmq: switch to RapidJSON iterative parsing
(cherry picked from commit 9b46f84008ff807211f5ebb5f480e0610c5f54b9)
2026-10-04 18:50:19 -04:00
wowario fbe80518cb update checkpoints 2026-05-15 02:30:12 +03:00
j-bermanandjwinterm bef90c1467 daemon: on exit, stop the payload handler before closing cxns
(cherry picked from commit 3a45f2b9ac9a22b081cbb9f26f90bc649fa229d8)
2026-05-06 10:52:37 -04:00
selstaandjwinterm 2846749f11 daemon: clarify limitations of restricted ZMQ RPC in help text
(cherry picked from commit 0b7c34520c0d218021b7941ebbc2faf0e2b58c2f)
2026-05-06 10:52:37 -04:00
selstaandjwinterm 4db19d46ea zmq: add restricted checks to GetInfo
(cherry picked from commit f31bb18174950237ea6ed083614c37a04d33b46e)
2026-05-06 10:52:37 -04:00
selstaandjwinterm e8c2387c24 wallet2: reject duplicate outputs in reserve proofs
(cherry picked from commit 2827d7fe84ad4102dd9f3284eb98da8f0d66266d)
2026-05-06 10:52:36 -04:00
selstaandjwinterm cc821f5bd8 cryptonote_core: restore separate fakechain data dir for core_tests
(cherry picked from commit 05cc8bc477007af8d392b450e20ae6c4c40a5a43)
2026-05-06 10:52:36 -04:00
tobtohtandjwinterm 36bbd1a2c7 wallet2: throw if reserve proof can't be parsed
(cherry picked from commit f855ffe87ddc593b286ad02f84b24b804872773a)
2026-05-06 10:52:36 -04:00
selstaandjwinterm 0bf3b9f441 wallet2: ensure daemon returns correct tx for spend proof
(cherry picked from commit 04eeb3ba1fc2ed0239eb10e885136d86b7e98ad0)
2026-05-06 10:52:36 -04:00
Lee Clagettandjwinterm da7acc3d72 Improve unpack reserve handling
(cherry picked from commit 54229196bd11913ef0ac2c44b9f090cf619d29d8)
2026-05-06 10:52:36 -04:00
jeffro256andjwinterm f857e2dc8c cryptonote_core: add change address sanity check
Prevents silly mistakes where wrong change address is passed

Release versions uses boost::optional instead of std::optional

(cherry picked from commit 44412d3574fcd7bdb6d0fcfb6c4ffc61c2d338d9)
2026-05-06 10:52:36 -04:00
Jeetrajandjwinterm 4f4ef45514 zmq: add missing restricted rpc check for get_block_headers_by_height
(cherry picked from commit a4efa1585e15b0f2fc54bc466e95fe7161788eb7)
2026-05-06 10:52:36 -04:00
tobtohtandjwinterm 620ff4c515 daemon: remove miniupnp
(cherry picked from commit 987e6d29133a493914a19b660051ca634fbed1d6)
2026-05-06 10:52:36 -04:00
tobtohtandjwinterm 24f0dec2d3 trezor: replace use of boost::is_base_of with std::is_base_of
(cherry picked from commit 919d247f7c62779a78df10e235811a24b0d0ecfd)
2026-05-05 18:20:53 -04:00
selstaandjwinterm 21b51550e5 wallet2: remove deprecated txs_as_hex
also add missing underflow check

(cherry picked from commit 54abe12f94abe5c0ca2e8ae63e3fea2d8cd41c9a)
2026-05-05 18:20:53 -04:00
j-bermanandjwinterm b15d060d19 tx_pool: notify txpool event when stem bumps to fluff
(cherry picked from commit 7d5e4842a4876d1b9a60ceddd412c3e168770036)
2026-05-05 18:20:53 -04:00
selstaandjwinterm 07ab9bf66c zmq: add more missing restricted rpc checks
(cherry picked from commit 6e51bdcd8ef233814d81c2b953fa82f13cbbd442)
2026-05-05 18:20:53 -04:00
Lee Clagettandjwinterm d420c943c1 Fix ZMQ-PUB reporting of mempool txes that were initially in stem phase
(cherry picked from commit 73f1eaaed6defa6fc25fc7e74b51679e365cb7e5)
2026-05-05 18:20:53 -04:00
jeffro256andjwinterm 49983ee687 blockchain_utilities: fix --data-dir option
(cherry picked from commit 8a20fd2bc84d74917381fb50362b4d1a385256bd)
2026-05-05 18:20:53 -04:00
j-bermanandjwinterm 22818719d4 cryptonote_protocol: cleanup_handle_incoming_blocks on scope exit
(cherry picked from commit ac96d8ad3709dee5c375642c3cd8f3b8348bb0cc)
2026-05-05 18:20:53 -04:00