Commit Graph
566 Commits
Author SHA1 Message Date
moneromooo-moneroandwowario c8cd83030c storages: overridable limits for loading portable_storage from binary 2021-01-08 08:48:00 +03:00
Lee Clagettandwowario fcac2ad95d Restrict duplicate keys in epee binary format 2021-01-07 09:13:27 +03:00
moneromooo-moneroandwowario f8e05b3003 epee: also limit number of strings in portable_storage
They require at least 24 bytes
2021-01-07 09:12:33 +03:00
moneromooo-moneroandwowario f02e91ef83 add a max levin packet size by command type 2021-01-04 09:46:18 +03:00
moneromooo-moneroandwowario 9289bd9493 portable_storage: better sanity checking 2021-01-04 09:43:15 +03:00
SChernykhandwowario 5de14c44ec Fixed issues found by static analysis
- rolling_median: tried to free uninitialized pointer in a constructor
- net_node.inl: erase-remove idiom was used incorrectly. remove_if doesn't actually remove elements, see http://cpp.sh/6fcjv
- bulletproofs.cc: call to sizeof() instead of vector.size(), luckily it only impacts performance and not code logic there
2021-01-02 11:02:20 +03:00
Lee Clagettandwowario 6a2abebb94 Restrict duplicate keys in epee binary format 2021-01-02 10:59:36 +03:00
xiphonandwowario 6675069dcf portable_storage: forbid unnamed sections 2021-01-02 10:59:22 +03:00
moneromoooandwowario 6375b913d9 portable_storage: check object limit where appropriate
also fix pedantic off by one in check
2021-01-02 10:58:54 +03:00
Lee Clagettandwowario b4206cea5a Add aggressive restrictions to pre-handshake p2p buffer limit 2021-01-02 10:57:50 +03:00
moneromooo-moneroandwowario 58404d389c portable_storage: remove array element limit
some people don't want it
2021-01-02 10:57:01 +03:00
anonandwowario 1ec6d5ccda ssl: buffered handshake detection 2021-01-02 10:56:49 +03:00
moneromooo-moneroandwowario 6de11d0718 epee: fix some issues using connections after shutdown 2021-01-02 10:56:31 +03:00
moneromooo-moneroandwowario 63381702d8 portable_storage: remove overly aggressive cutoff 2021-01-02 10:56:06 +03:00
moneromooo-moneroandwowario a7e3955772 portable_storage: add some sanity checks on data size
especially when allocated size is >> serialized data size
2021-01-02 10:55:24 +03:00
Lee Clagettandwowario 8088f8d894 Fix byte_stream::put_n 2021-01-02 10:43:02 +03:00
Lee Clagettandwowario 0b8bf308ce Change epee binary output from std::stringstream to byte_stream 2020-12-11 07:46:14 +03:00
Lee Clagettandwowario a3033e741b Change to more efficient allocation strategy in byte_stream 2020-12-11 07:45:41 +03:00
moneromooo-moneroandwowario 6815ddd270 epee: tighten the URL parsing regexp a little
fixes massive amounts of time spent on pathological inputs

Found by OSS-Fuzz
2020-12-04 09:38:42 +03:00
Lee Clagett b641e0a2c0 Add clear method to byte_stream 2020-08-17 21:30:34 -04:00
Alexander Blair 43a4fd9e16 Merge pull request #6736
05ad4fa39 epee: further defending against exceptions in command handlers (moneromooo-monero)
2020-08-16 12:56:35 -07:00
Alexander Blair d73b1b6560 Merge pull request #6727
13eee1d6a rpc: reject wrong sized txid (moneromooo-monero)
92e6b7df2 easylogging++: fix crash with reentrant logging (moneromooo-monero)
6dd95d530 epee: guard against exceptions in RPC handlers (moneromooo-monero)
90016ad74 blockchain: guard against exceptions in add_new_block/children (moneromooo-monero)
2020-08-16 12:55:25 -07:00
Alexander Blair 7db379cc82 Merge pull request #6720
86abf558c epee: Remove unused functions in local_ip.h (Jean Pierre Dudey)
2020-08-16 12:54:17 -07:00
Alexander Blair 10ad0d7eb2 Merge pull request #6718
85efc88c1 Fix overflow issue in epee:misc_utils::rolling_median_t and median(), with unit test (koe)
2020-08-16 12:53:50 -07:00
Alexander Blair 01b512f3a9 Merge pull request #6716
76c16822d wallet2_api: implement runtime proxy configuration (xiphon)
2020-08-16 12:52:21 -07:00
moneromooo-monero 05ad4fa397 epee: further defending against exceptions in command handlers 2020-08-02 00:22:47 +00:00
moneromooo-monero 6dd95d5308 epee: guard against exceptions in RPC handlers 2020-07-30 22:52:12 +00:00
rbrunner7 fb31167b12 Wallet, daemon: From 'help_advanced' back to 'help', and new 'apropos' command 2020-07-24 07:12:11 +02:00
koe 85efc88c1e Fix overflow issue in epee:misc_utils::rolling_median_t and median(), with unit test 2020-07-23 03:36:05 -05:00
Jean Pierre Dudey 86abf558cb epee: Remove unused functions in local_ip.h
Signed-off-by: Jean Pierre Dudey <me@jeandudey.tech>
2020-07-22 19:06:01 -05:00
xiphon 76c16822d0 wallet2_api: implement runtime proxy configuration 2020-07-20 13:45:12 +00:00
Alexander Blair 3ba6c7fd30 Merge pull request #6516
8656a8c9f remove double includes (sumogr)
2020-07-19 03:34:28 -07:00
Alexander Blair a0d179e528 Merge pull request #6512
5ef0607da Update copyright year to 2020 (SomaticFanatic)
2020-07-19 03:32:59 -07:00
moneromooo-monero 3721d5688f epee: fix array underflow in unicode parsing
Reported by minerscan

Also independently found by OSS-Fuzz just recently
2020-06-21 18:22:16 +00:00
luigi1111 e27604ff10 Merge pull request #6539
85164a8 epee: use memwipe rather than memset for md5 secrets (moneromooo-monero)
2020-06-08 14:09:22 -05:00
Lee Clagett 7aeb503547 Fix boost <1.60 compilation and fix boost 1.73+ warnings 2020-05-31 21:18:11 -04:00
moneromooo-monero 85164a8daf epee: use memwipe rather than memset for md5 secrets
That's used by HTTP auth now
2020-05-16 18:12:55 +00:00
selsta f35ced6d7f build: fix boost 1.73 compatibility 2020-05-14 22:57:53 +02:00
sumogr 8656a8c9ff remove double includes 2020-05-11 13:53:17 +00:00
SomaticFanatic 5ef0607da6 Update copyright year to 2020
Update copyright year to 2020
2020-05-06 22:36:54 -04:00
Lee Clagett c26c93019a Add byte_stream for zero-copy serialization, and add support in ZMQ-JSON. 2020-04-11 04:12:11 +00:00
luigi1111 c9b800a787 Merge pull request #6446
e509ede trezor: adapt to new passphrase mechanism (ph4r05)
2020-05-01 15:32:52 -05:00
Dusan Klinec e509ede2aa trezor: adapt to new passphrase mechanism
- choice where to enter passphrase is now made on the host
- use wipeable string in the comm stack
- wipe passphrase memory
- protocol optimizations, prepare for new firmware version
- minor fixes and improvements
- tests fixes, HF12 support
2020-04-27 18:17:56 +02:00
luigi1111 cfc0f4a7fa Merge pull request #6351
81c5943 Remove temporary std::string creation in some hex->bin calls (vtnerd)
5fcc23a Move hex->bin conversion to monero copyright files and with less includes (vtnerd)
3387f0e Reduce template bloat in hex->bin for ZMQ json (vtnerd)
2020-04-04 12:55:02 -05:00
luigi1111 c4f75fe898 Merge pull request #6339
c61abf8 remove empty statements (shopglobal)
2020-04-04 12:47:31 -05:00
Lee Clagett da99157462 Use byte_slice for sending zmq messages - removes data copy within zmq 2020-04-03 01:56:17 +00:00
woodser 87d75584e8 Allow wallet2.h to run in WebAssembly
- Add abstract_http_client.h which http_client.h extends.
- Replace simple_http_client with abstract_http_client in wallet2,
message_store, message_transporter, and node_rpc_proxy.
- Import and export wallet data in wallet2.
- Use #if defined __EMSCRIPTEN__ directives to skip incompatible code.
2020-04-15 13:22:46 -04:00
moneromooo-monero 21fe6a289b p2p: fix frequent weak_ptr exception on connection
When a handshake fails, it can fail due to timeout or destroyed
connection, in which case the connection will be, or already is,
closed, and we don't want to do it twice.
Additionally, when closing a connection directly from the top
level code, ensure the connection is gone from the m_connects
list so it won't be used again.

AFAICT this is now clean in netstat, /proc/PID/fd and print_cn.

This fixes a noisy (but harmless) exception.
2020-03-31 20:29:41 +00:00
luigi1111 6c7d928f19 Merge pull request #6336
760ecf2 console_handler: do not let exception past the dor (moneromooo-monero)
09c8111 threadpool: lock mutex in create (moneromooo-monero)
e377977 tx_pool: catch theoretical error in get_block_reward (moneromooo-monero)
2020-03-31 15:14:12 -05:00
luigi1111 48b244dcd4 Merge pull request #6311
5002a03 Explicitly define copy assignment operator (omartijn)
2020-03-31 15:13:35 -05:00