Commit Graph
1164 Commits
Author SHA1 Message Date
tobtoht cee436892f Merge pull request #11235
f8e2a87 cryptonote_basic: serialization checks (j-berman)

ACKs: plowsof, selsta*, jpk68
2026-09-10 13:30:16 +00:00
tobtoht f8910c0264 Merge pull request #11231
6f42318 simplewallet: remove redundant space in prompt (jpk68)

ACKs: tobtoht, selsta
2026-09-10 13:29:06 +00:00
j-berman f8e2a8709d cryptonote_basic: serialization checks 2026-09-09 18:20:50 -07:00
tobtoht 7672d4f8e1 Merge pull request #11230
0855930 simplewallet: rename duplicate amount headers for clarity (reemuru)

ACKs: jpk68, selsta
2026-09-09 20:18:14 +00:00
tobtoht 9972aecd54 Merge pull request #11212
c7f77c2 simplewallet: hide reached confirmation threshold (Samy)

ACKs: jpk68, selsta
2026-09-09 20:09:49 +00:00
tobtoht afa16e098a Merge pull request #11209
e96e9e6 simplewallet: quote notes in transfer exports (Samy)

ACKs: jpk68, selsta
2026-09-09 20:09:11 +00:00
tobtoht 3d3920d748 Merge pull request #10875
773e307 simplewallet: reject donations when not on mainnet (jpk68)

ACKs: SNeedlewoods*, thomasbuilds, selsta
2026-09-03 13:34:56 +00:00
jpk68 6f4231887d simplewallet: remove redundant space in prompt 2026-09-01 17:20:41 -04:00
reemuruandSamy 085593040e simplewallet: rename duplicate amount headers for clarity
There are duplicate 'amount' headers when using export_transfers all. Column five represents the transaction total while column eleven represents the amount transferred per destination.

Rename the columns without changing their order or values.

(cherry picked from commit 30ab49d5cb5f7d5b089d20919cf4f02b063f2e6b)
2026-09-01 20:24:54 +02:00
tobtoht 396c4d837c Merge pull request #11170
fd86262 simplewallet: suggest hw_reconnect on refresh (Samy)

ACKs: jpk68, selsta
2026-08-31 18:18:15 +00:00
tobtoht 5b85e2d70a Merge pull request #11121
ddf0786 simplewallet: fix crash in sweep commands when address is omitted (jpk68)

ACKs: selsta, SNeedlewoods
2026-08-31 18:17:47 +00:00
Samy c7f77c2649 simplewallet: hide reached confirmation threshold 2026-08-30 18:23:50 +02:00
Samy e96e9e66ff simplewallet: quote notes in transfer exports 2026-08-30 00:23:54 +02:00
tobtoht 9f31349249 Merge pull request #11163
6a4e1d9 simplewallet: fix show_transfer confirmations (Samy)

ACKs: jpk68, selsta
2026-08-27 17:58:40 +00:00
tobtoht 2ff2e154d9 Merge pull request #11124
881e7a7 simplewallet: update error message (jpk68)

ACKs: SNeedlewoods, thomasbuilds, selsta
2026-08-25 19:19:14 +00:00
tobtoht ba8d3d679a Merge pull request #11125
478812d simplewallet: add missing guards/locks for multisig commands (jpk68)

ACKs: selsta*, SNeedlewoods
2026-08-25 06:39:39 +00:00
jpk68 478812d554 simplewallet: add missing guards/locks for multisig commands 2026-08-24 10:42:43 -04:00
jpk68 881e7a71c2 simplewallet: update error message 2026-08-24 10:33:05 -04:00
tobtoht 08c4451c36 Merge pull request #11136
e03c6a2 simplewallet: allow closing wallet when locked due to inactivity (jpk68)

ACKs: selsta, SNeedlewoods
2026-08-23 20:18:00 +00:00
tobtoht 9d526382e5 Merge pull request #11119
d66d420 simplewallet: don't exit when unable to get restore date (jpk68)

ACKs: selsta, SNeedlewoods
2026-08-23 07:41:01 +00:00
Samy fd86262a85 simplewallet: suggest hw_reconnect on refresh 2026-08-22 18:58:19 +02:00
Samy 6a4e1d9178 simplewallet: fix show_transfer confirmations 2026-08-20 14:38:57 +02:00
tobtoht 7d615a62e0 Merge pull request #11098
6bc69dd simplewallet: don't ignore misplaced index= in sweep commands (jpk68)

ACKs: selsta, SNeedlewoods
2026-08-18 21:52:27 +00:00
jpk68 e03c6a2009 simplewallet: allow closing wallet when locked due to inactivity 2026-08-17 20:12:32 -04:00
jpk68 d66d420d5c simplewallet: don't exit when unable to get restore date 2026-08-16 15:48:41 -04:00
tobtoht e171a2daa2 Merge pull request #11073
5cc215d wallet: respect --no-dns for OpenAlias (Samy)

ACKs: jpk68, SNeedlewoods, selsta
2026-08-16 15:20:41 +00:00
jpk68 ddf0786ef7 simplewallet: fix crash in sweep commands when address is omitted 2026-08-15 14:31:19 -04:00
tobtoht 699f82e370 Merge pull request #11070
616613c simplewallet: add clear command (Thomas)

ACKs: jpk68, SNeedlewoods, selsta
2026-08-14 14:47:49 +00:00
jpk68 6bc69dd575 simplewallet: don't ignore misplaced index= in sweep commands 2026-08-12 12:42:35 -04:00
tobtoht e2c7405ba4 Merge pull request #11061
f98077b wallet: fix split transaction change address display (selsta)

ACKs: jpk68, SNeedlewoods
2026-08-12 13:31:58 +00:00
tobtoht be5f1c5173 Merge pull request #10983
ae8291f wallet: display private view keys for hardware wallets (jpk68)

ACKs: SChernykh*, selsta
2026-08-11 21:25:21 +00:00
tobtoht c23227c0fa Merge pull request #11040
23d86a9 simplewallet: show error for timed-out hardware wallets (jpk68)

ACKs: thomasbuilds, selsta
2026-08-11 21:20:23 +00:00
tobtoht 65d26ba347 Merge pull request #10878
cb88c71 src: remove unused headers (jpk68)

ACKs: thomasbuilds, selsta
2026-08-11 21:17:36 +00:00
jpk68 773e30705f simplewallet: reject donations when not on mainnet 2026-08-11 13:48:50 -04:00
jpk68 23d86a96bc simplewallet: show error for timed-out hardware wallets 2026-08-10 13:35:39 -04:00
tobtoht 0f7a96c0fe Merge pull request #11039
9bd5f7e simplewallet: tweak description of donate command (jpk68)

ACKs: selsta, tobtoht
2026-08-09 18:41:58 +00:00
Samy 5cc215d5f9 wallet: respect --no-dns for OpenAlias 2026-08-09 18:43:55 +02:00
Thomas 616613c157 simplewallet: add clear command
Clears the console screen, as one would expect from a shell.
tools::clear_screen() already existed, but its only caller was the
wallet lock screen; this exposes it as a command.

PAUSE_READLINE() is used because readline substitutes its own streambuf
for std::cout's while running, so without it the escape sequences would
be routed through readline_buffer::sync() and interleaved with prompt
redraws.
2026-08-08 14:17:57 +05:00
tobtoht 87f8b6d022 Merge pull request #11026
9f57fa7 simplewallet: indicate default choice in yes/no prompts (bsandham)

ACKs: SNeedlewoods, jpk68, selsta
2026-08-07 18:34:04 +00:00
tobtoht b7706939fa Merge pull request #11020
e26eab8 simplewallet: use the swept account for index=all in sweep_main (Cole Munz)

ACKs: selsta, jpk68
2026-08-07 18:26:36 +00:00
selsta f98077b7ad wallet: fix split transaction change address display
Display the first non-zero change address after verifying that all
effective change uses the same address. Foreign change is already
rejected during signing, so this only fixes misleading display.

Reported by xmrack and the MAGIC Monero Fund.
2026-08-06 16:59:22 +02:00
jpk68 cb88c71ecd src: remove unused headers 2026-08-06 10:17:54 -04:00
jpk68 9bd5f7ee00 simplewallet: tweak description of donate command 2026-08-03 20:05:02 -04:00
jpk68 ae8291f9d6 wallet: display private view keys for hardware wallets 2026-08-03 19:35:55 -04:00
bsandham 9f57fa7a6a simplewallet: indicate default choice in yes/no prompts 2026-08-02 18:14:23 +01:00
tobtoht ce1e0164f5 Merge pull request #10984
27367b8 simplewallet: prompt for restore height when using generate-from-device (jpk68)

ACKs: SChernykh, selsta
2026-08-01 15:23:27 +00:00
tobtoht b6c9dc5113 Merge pull request #10977
013741b simplewallet: use more straightforward device message (jpk68)

ACKs: selsta, tobtoht
2026-08-01 15:15:59 +00:00
tobtoht 80b8dcf7be Merge pull request #10976
029fa3d simplewallet: fix restore-date parameter when using generate-from-device (jpk68)

ACKs: selsta, tobtoht
2026-08-01 15:14:52 +00:00
Cole Munz e26eab8ca7 simplewallet: use the swept account for index=all in sweep_main
sweep_main() takes the account to sweep as a parameter, but the index=all
expansion still counts subaddresses on m_current_subaddress_account. sweep_all
and sweep_below pass the current account, so sweep_account is the one command
that ends up with the wrong set.

When the current account has fewer subaddresses than the account being swept,
the set is too small and outputs in the higher minor indices never make it into
the sweep. If none of the target's unlocked outputs land in that range,
create_transactions_all throws "No unlocked balance in the specified
subaddress(es)" for an account that plainly has a balance.

27d551d12f added the account parameter and pointed create_transactions_all at
it, but left this loop on the old field. The RPC path already does it the right
way, with get_num_subaddresses(req.account_index).
2026-07-31 23:43:43 -05:00
tobtoht dfc36e278b Merge pull request #10949
54acdd1 simplewallet: validate get_outs response size (selsta)

ACKs: plowsof, SNeedlewoods, jpk68
2026-07-28 15:45:30 +00:00