+3
a9145f9d38
FCMP++/Carrot mega commit [9/14/26]
...
Co-authored-by: jeffro256 <jeffro256@tutanota.com >
Co-authored-by: Luke Parker <lukeparker5132@gmail.com >
Co-authored-by: Lee *!* Clagett <code@leeclagett.com >
Co-authored-by: SyntheticBird45 <someoneelse.is_on.github.rio7x@simplelogin.com >
Co-authored-by: jeetrex17 <jeetrex@tutamail.com >
Co-authored-by: UkoeHB <ukoehb@users.noreply.github.com >
Co-authored-by: MrCyjaneK
Co-authored-by: tobtoht
Co-authored-by: selsta
Co-authored-by: Thomas <thomas.giudici@proton.me >
Co-authored-by: navidR
Co-authored-by: Boog900 <boog900@tutanota.com >
2026-09-17 18:33:24 -07:00
tobtoht
cee436892f
Merge pull request #11235
...
f8e2a87 cryptonote_basic: serialization checks (j-berman)
ACKs: plowsof, selsta*, jpk68
2026-09-10 13:30:16 +00:00
j-berman
f8e2a8709d
cryptonote_basic: serialization checks
2026-09-09 18:20:50 -07:00
tobtoht
8bbd915f59
Merge pull request #11223
...
70ac701 cryptonote_basic: cache prunable hash for pruned txs (Samy)
ACKs: jpk68, selsta
2026-09-09 20:14:57 +00:00
tobtoht
350c0bde2c
Merge pull request #11206
...
2fe7534 Add checks in cryptonote serialization routine (Lee *!* Clagett)
ACKs: jpk68, j-berman, selsta, plowsof
2026-09-09 20:07:40 +00:00
jeffro256
c7a2d4f66a
crypto: reduce crypto.h header weight
2026-09-07 21:32:29 -05:00
Samy
70ac70101a
cryptonote_basic: cache prunable hash for pruned txs
2026-09-01 02:52:19 +02:00
tobtoht
5cde0ac62a
Merge pull request #11174
...
ce7a081 miner: allow zero background mining sleep (Samy)
ACKs: jpk68, selsta
2026-08-31 18:21:04 +00:00
Lee *!* Clagett
2fe7534434
Add checks in cryptonote serialization routine
2026-08-30 17:32:53 -04:00
tobtoht
78fb311ebb
Merge pull request #10605
...
59702e0 rpc: speedup block&tx RPC calls (jeffro256)
ACKs: thomasbuilds*, selsta, jpk68
2026-08-28 07:58:16 +00:00
jeffro256
59702e0275
rpc: speedup block&tx RPC calls
...
In RPC calls `get_blocks.bin` and `get_transactions`:
1. Skip deserializing then re-serializing tx blobs
2. Provide full unpruned transaction from mempool in `get_transactions` when `!req.prune`
3. Change `on_get_transactions()` response sort time from O(N^2) to O(N)
4. Generally improve memory usage and lookups in `on_get_transactions()`
Reviewed-by: selsta <selsta@sent.at >
Reviewed-by: j-berman <justinberman@protonmail.com >
Reviewed-by: jpk68 <jpk68@tutanota.com >
2026-08-27 15:08:57 -05:00
tobtoht
52ece983c1
Merge pull request #11142
...
c1df77c cryptonote_basic: remove dead code (Thomas)
ACKs: jpk68, UkoeHB
2026-08-25 16:42:23 +00:00
tobtoht
3f319be339
Merge pull request #10872
...
7dd01b6 cryptonote_basic: copy difficulty hash words (Samy)
ACKs: selsta, jpk68
2026-08-25 06:37:56 +00:00
Samy
ce7a081f82
miner: allow zero background mining sleep
2026-08-23 15:43:37 +02:00
Thomas
c1df77c81a
cryptonote_basic: remove dead code
2026-08-20 20:43:23 +02:00
tobtoht
e171a2daa2
Merge pull request #11073
...
5cc215d wallet: respect --no-dns for OpenAlias (Samy)
ACKs: jpk68, SNeedlewoods, selsta
2026-08-16 15:20:41 +00:00
j-berman
236ca60be0
cryptonote_basic: parse_and_validate_tx param to check max size
...
Simple API to check max blob size before parsing. This is useful
when reading blobs from untrusted sources.
@selsta pointed out that coinbase txs can technically be larger
than get_max_tx_size(), otherwise we could enforce it on all txs.
2026-08-13 09:12:10 -07:00
tobtoht
ed0363031c
Merge pull request #11067
...
bfe6990 cryptonote_basic: sanity check on key offsets (j-berman)
ACKs: jpk68*, SNeedlewoods, thomasbuilds, jeffro256
2026-08-13 13:03:22 +00:00
Samy
5cc215d5f9
wallet: respect --no-dns for OpenAlias
2026-08-09 18:43:55 +02:00
j-berman
bfe699082e
cryptonote_basic: sanity check on key offsets
...
Nice early check on allowed n key offsets per tx based on the
guaranteed ceiling for the entire chain.
2026-08-07 14:25:58 -07:00
Cole Munz
5f767c6e4e
cryptonote_basic: keep additional derivations aligned in key image helper
...
generate_key_image_helper only appended to additional_recv_derivations when
generate_key_derivation succeeded. A tx pubkey that is not a valid point makes
that call fail, so every later derivation shifted down one slot.
is_out_to_acc_precomp indexes that vector by the output index, so once the
list is short the lookup either falls off the bounds check or reads the
derivation belonging to a different output. Either way the helper reports that
the output does not belong to the address, and the wallet cannot build a key
image for an output it owns. Anyone who can put a transaction in front of the
wallet chooses those pubkeys.
The main tx pubkey a few lines up already handles a failed derivation by
keeping its slot and padding with identity, and wallet2 does the same in the
three places it builds this list (wallet2.cpp:2393, :7887, :13397). Do it here
too.
2026-07-31 23:37:25 -05:00
jeffro256
edea8505db
general: replace auto_scope_leave_caller with scope_guard
...
And replace unused inclusions of misc_language.h
2026-07-15 19:54:58 -05:00
Samy
7dd01b69d3
cryptonote_basic: copy difficulty hash words
2026-07-11 02:17:33 +02:00
tobtoht
d6aa5ce38f
Merge pull request #10851
...
7eb70c7 chore: remove msvc remnants (jpk68)
ACKs: selsta, tobtoht
2026-07-08 09:26:40 +00:00
tobtoht
a7c93412fe
Merge pull request #10839
...
dc45f67 cryptonote_basic: remove legacy address parser (Ap4sh)
ACKs: selsta, tobtoht
2026-07-06 16:46:50 +00:00
selsta and jeffro256
dc8bc028a6
cryptonote: scope 202612 PoW workaround
...
The block 202612 PoW workaround previously applied to any block at
height 202612. Restrict it to the object hashes of the known historical
mainnet, testnet, and stagenet block hashing blobs so new chains do not
inherit the fixed PoW hash, which would prevent sync or mining past that
height if their difficulty is higher.
Reported-by: DataHoarder
Co-authored-by: jeffro256 <jeffro256@tutanota.com >
2026-07-03 14:59:41 +02:00
tobtoht
381fce8dde
Merge pull request #10828
...
fecef76 Fix spelling typos in comments and string literals (Thomas)
ACKs: tobtoht, selsta
2026-07-02 13:18:56 +00:00
tobtoht
a9d9134f62
Merge pull request #10800
...
f4047ae cryptonote_basic: copy tx extra payment IDs (Ap4sh)
ACKs: jeffro256, selsta
2026-07-01 20:00:37 +00:00
Ap4sh
dc45f673c9
cryptonote_basic: remove legacy address parser
2026-06-30 12:20:41 +02:00
jpk68
7eb70c7858
chore: remove msvc remnants
2026-06-29 21:29:19 -04:00
tobtoht
7f982b8c9d
Merge pull request #10803
...
d7e2399 cryptonote_basic: remove unused function (jpk68)
ACKs: selsta, tobtoht
2026-06-27 12:02:08 +00:00
Thomas
fecef767c9
Fix spelling typos in comments and string literals
2026-06-27 09:53:48 +02:00
Ap4sh
f4047aeb41
cryptonote_basic: copy tx extra payment IDs
2026-06-21 16:41:13 +02:00
jpk68
d7e23999d9
cryptonote_basic: remove unused function
2026-06-16 21:34:48 -04:00
tobtoht
9854fbd420
Merge pull request #10742
...
248792a Miner: fixed thread 0 always mining with secure JIT (worse performance) (SChernykh)
ACKs: selsta, tobtoht
2026-06-15 14:44:11 +00:00
tobtoht
d5b226d295
Merge pull request #10566
...
6460917 serialization: avoid blob memcpy of secret_key vector (selsta)
ACKs: vtnerd, tobtoht
2026-06-13 10:14:19 +00:00
SChernykh
248792a4be
Miner: fixed thread 0 always mining with secure JIT (worse performance)
2026-06-08 19:35:10 +02:00
jpk68
5b34e138d6
src: fix formatting of copyright comments
2026-05-25 20:08:02 -04:00
Thomas
2c327aa325
fix spelling in comments and docs
2026-05-13 21:20:05 +02:00
selsta
6460917cab
serialization: avoid blob memcpy of secret_key vector
2026-05-09 23:42:51 +02:00
tobtoht
90fc50c371
cmake: only link Boost Chrono where needed
2026-05-06 21:24:14 +02:00
j-berman
94089a8788
cryptonote_basic: pruned hash return bool
2026-04-21 12:04:31 -07:00
tobtoht
2404f1bc92
Merge pull request #10220
...
2eed71e cryptonote_basic: fix add_extra_nonce_to_tx_extra() length (jeffro256)
2026-03-01 11:27:03 +00:00
jeffro256
2eed71e575
cryptonote_basic: fix add_extra_nonce_to_tx_extra() length
...
Reviewed-by: selsta <selsta@sent.at >
Reviewed-by: SChernykh
2026-02-24 17:13:37 -06:00
jeffro256
6a99c22cbc
rpc: return error gracefully on cryptonight v1 check
2026-01-31 10:14:05 -06:00
tobtoht
74dd968cd9
Merge pull request #10039
...
488bf71 cryptonote_basic: add overload for get_block_longhash() (jeffro256)
2026-01-29 15:43:22 +00:00
jeffro256
ca27d519df
cryptonote_basic: remove redundant call to get_transaction_hash() in overload
...
Issue noticed by DataHoarder.
2025-10-05 16:47:57 -05:00
jeffro256
488bf71925
cryptonote_basic: add overload for get_block_longhash()
2025-09-07 09:58:20 -05:00
tobtoht
da2c15b76e
Merge pull request #10026
...
613ee85 cryptonote_basic: remove state_idle in connection_context (jeffro256)
2025-08-21 16:22:13 +00:00
tobtoht
a8b5ae6dd2
Merge pull request #9919
...
06b74ae ringct & cryptonote_basic: detangle dependencies (jeffro256)
2025-08-21 16:18:14 +00:00