Commit Graph
8630 Commits
Author SHA1 Message Date
jeffro256 53ff15b0d6 Blockchain: improve check_block_timestamp() overloads 2026-08-11 11:32:15 -05:00
tobtoht d8c8cc310c Merge pull request #11048
a47a436 p2p: update peer's height on new block & widen window for relay (j-berman)

ACKs: selsta, Boog900
2026-08-10 15:47:20 +00:00
tobtoht bdd3ac6e9d Merge pull request #10855
04c6da4 wallet: copy parsed crypto fields (Ap4sh)

ACKs: selsta, tobtoht
2026-08-10 13:44:42 +00:00
tobtoht bbcce5c765 Merge pull request #11047
576af29 device_trezor: update protobuf definitions (jpk68)

ACKs: tobtoht, selsta
2026-08-10 13:23:28 +00:00
tobtoht d006bd463f Merge pull request #11049
20db2e7 blockchain: if block is known invalid, fail block verification (j-berman)

ACKs: jeffro256, selsta
2026-08-10 13:21:48 +00:00
tobtoht 642871f052 Merge pull request #11050
ce14fdc cryptonote_core: rm unnecessary db reads before block relay (j-berman)

ACKs: jeffro256, selsta, jpk68
2026-08-10 13:20:51 +00:00
tobtoht f412232c0f Merge pull request #10930
26a2379 rpc: speed up mempool lookup in get_transactions (jpk68)

ACKs: thomasbuilds*, selsta
2026-08-09 22:01:19 +00:00
tobtoht b2588ef742 Merge pull request #10883
9477d0c wallet: initialize URI parse outputs (Samy)

ACKs: selsta, jpk68
2026-08-09 22:00:24 +00:00
tobtoht 0f7a96c0fe Merge pull request #11039
9bd5f7e simplewallet: tweak description of donate command (jpk68)

ACKs: selsta, tobtoht
2026-08-09 18:41:58 +00:00
tobtoht 936ac869b6 Merge pull request #11042
e38cfe6 device_ledger: fix some comments (jpk68)

ACKs: thomasbuilds, selsta
2026-08-09 18:40:00 +00:00
jpk68 26a2379469 rpc: speed up mempool lookup in get_transactions 2026-08-09 13:32:03 -04:00
tobtoht ab3cb76bfb Merge pull request #11029
e6d0d1e cryptonote_protocol: avoid copying block span in add_blocks (jpk68)

ACKs: selsta, tobtoht
2026-08-08 13:29:53 +00:00
tobtoht 664dae8223 Merge pull request #11030
493af98 wallet2: fix faulty bounds check (jpk68)

ACKs: selsta, jeffro256
2026-08-08 13:26:50 +00:00
jpk68 e38cfe6683 device_ledger: fix some comments 2026-08-07 15:35:54 -04:00
tobtoht 87f8b6d022 Merge pull request #11026
9f57fa7 simplewallet: indicate default choice in yes/no prompts (bsandham)

ACKs: SNeedlewoods, jpk68, selsta
2026-08-07 18:34:04 +00:00
tobtoht 3634d19bb0 Merge pull request #11022
d8b40e3 device: implement default device locking (woodser)

ACKs: jpk68, selsta
2026-08-07 18:27:17 +00:00
tobtoht b7706939fa Merge pull request #11020
e26eab8 simplewallet: use the swept account for index=all in sweep_main (Cole Munz)

ACKs: selsta, jpk68
2026-08-07 18:26:36 +00:00
tobtoht c1f81042b5 Merge pull request #11019
5f767c6 cryptonote_basic: keep additional derivations aligned in key image helper (Cole Munz)

ACKs: selsta, jeffro256
2026-08-07 18:26:05 +00:00
tobtoht a82b6d8a17 Merge pull request #11018
a646d9e wallet2: clamp export_outputs start to the number of transfers (Cole Munz)

ACKs: selsta, jpk68
2026-08-07 18:25:31 +00:00
reservedbytes 2648a4a335 device: report ledger state when no app is open 2026-08-06 20:08:58 +00:00
j-berman a47a43651c p2p: update peer's height on new block & widen window for relay
- We select peers to relay to based on their latest known sync height.
- This change:
A) makes sure to update the peer's latest known sync height upon
validating the peer's newly relayed blocks.
B) Allows for a wider window so that if we haven't yet received the
peer's block or finished validating it, then the peer can still be
a valid candidate to receive our new txs.
2026-08-06 09:16:28 -07:00
tobtoht 84024e27bb Merge pull request #10997
c6ef8d2 device: fix ledger status code reporting (reservedbytes)

ACKs: jeffro256*, jpk68, selsta
2026-08-06 06:59:17 +00:00
j-berman ce14fdc0ea cryptonote_core: rm unnecessary db reads before block relay 2026-08-04 14:01:43 -07:00
j-berman 20db2e7162 blockchain: if block is known invalid, fail block verification 2026-08-04 13:57:57 -07:00
jpk68 576af29b16 device_trezor: update protobuf definitions 2026-08-04 16:06:29 -04:00
tobtoht 1bf1dff4be Merge pull request #11000
8e30662 wallet2: fix compiler warning (jpk68)

ACKs: jeffro256, selsta, tobtoht
2026-08-04 16:29:57 +00:00
tobtoht 4605a02bcf Merge pull request #10991
e7278c0 cryptonote_core: remove dead code (Thomas)

ACKs: jpk68, selsta
2026-08-04 14:41:01 +00:00
tobtoht ec78687d91 Merge pull request #10986
8d76584 p2p: remove dead code (Thomas)

ACKs: jpk68, selsta
2026-08-04 14:40:12 +00:00
tobtoht 215e16ef46 Merge pull request #10840
5a2bd89 txpool: re-relay txs that haven't been relayed and need to be (j-berman)

ACKs: selsta, vtnerd, jpk68
2026-08-04 05:19:05 +00:00
jpk68 9bd5f7ee00 simplewallet: tweak description of donate command 2026-08-03 20:05:02 -04:00
woodser d8b40e3898 device: implement default device locking 2026-08-02 15:11:25 -04:00
jpk68 493af98614 wallet2: fix faulty bounds check 2026-08-02 13:14:24 -04:00
bsandham 9f57fa7a6a simplewallet: indicate default choice in yes/no prompts 2026-08-02 18:14:23 +01:00
jpk68 e6d0d1e722 cryptonote_protocol: avoid copying block span in add_blocks 2026-08-02 12:54:37 -04:00
tobtoht 83405f127d Merge pull request #10988
7162000 device_trezor: validate bridge response size before parsing (selsta)

ACKs: jpk68, tobtoht, SNeedlewoods
2026-08-02 16:18:14 +00:00
jpk68 8d4f888132 device_trezor: reject incompatible firmware versions 2026-08-01 13:21:25 -04:00
tobtoht e8dd781e19 Merge pull request #10812
44493be p2p, rpc: group public IPv6 connection limits by /64 (selsta)

ACKs: plowsof*, tobtoht
2026-08-01 16:12:29 +00:00
tobtoht ce1e0164f5 Merge pull request #10984
27367b8 simplewallet: prompt for restore height when using generate-from-device (jpk68)

ACKs: SChernykh, selsta
2026-08-01 15:23:27 +00:00
selsta 44493becb7 p2p, rpc: group public IPv6 connection limits by /64 2026-08-01 17:23:05 +02:00
tobtoht 42f566231a Merge pull request #10980
1bae55a p2p: stop buffered dispatch after fatal notifications (selsta)

ACKs: jpk68*, SChernykh
2026-08-01 15:20:17 +00:00
tobtoht f4c1bfc134 Merge pull request #10979
e2a4f68 wallet2: check for overflow when calculating fee from weight (selsta)

ACKs: jpk68, tobtoht, SChernykh
2026-08-01 15:19:01 +00:00
tobtoht 322bdba1d9 Merge pull request #10978
6e35278 device_trezor: improve error message for view key export (jpk68)

ACKs: selsta, tobtoht
2026-08-01 15:17:31 +00:00
tobtoht b6c9dc5113 Merge pull request #10977
013741b simplewallet: use more straightforward device message (jpk68)

ACKs: selsta, tobtoht
2026-08-01 15:15:59 +00:00
tobtoht 80b8dcf7be Merge pull request #10976
029fa3d simplewallet: fix restore-date parameter when using generate-from-device (jpk68)

ACKs: selsta, tobtoht
2026-08-01 15:14:52 +00:00
tobtoht 3a127cd06e Merge pull request #10945
8c04ffe blockchain_prune: use per-table LMDB stats for resize estimation (selsta)

ACKs: jeffro256, tobtoht
2026-08-01 15:12:13 +00:00
Cole Munz e26eab8ca7 simplewallet: use the swept account for index=all in sweep_main
sweep_main() takes the account to sweep as a parameter, but the index=all
expansion still counts subaddresses on m_current_subaddress_account. sweep_all
and sweep_below pass the current account, so sweep_account is the one command
that ends up with the wrong set.

When the current account has fewer subaddresses than the account being swept,
the set is too small and outputs in the higher minor indices never make it into
the sweep. If none of the target's unlocked outputs land in that range,
create_transactions_all throws "No unlocked balance in the specified
subaddress(es)" for an account that plainly has a balance.

27d551d12f added the account parameter and pointed create_transactions_all at
it, but left this loop on the old field. The RPC path already does it the right
way, with get_num_subaddresses(req.account_index).
2026-07-31 23:43:43 -05:00
Cole Munz a646d9e7c3 wallet2: clamp export_outputs start to the number of transfers
export_outputs() says start and count are allowed to go past the valid range,
and that nothing is returned when they do. The loop honours that, but offset
does not: with all=true it takes start unchecked, so a start past the end makes
m_transfers.size() - offset underflow and reserve() gets a value near SIZE_MAX.
vector::reserve throws std::length_error on that, which is where the
"vector::reserve" error in issue #8625 comes from.

Clamping offset also keeps the returned offset usable. import_outputs throws
when offset is past the total, so leaving offset at start would only move the
failure from export to import.
2026-07-31 23:41:03 -05:00
Cole Munz 5f767c6e4e cryptonote_basic: keep additional derivations aligned in key image helper
generate_key_image_helper only appended to additional_recv_derivations when
generate_key_derivation succeeded. A tx pubkey that is not a valid point makes
that call fail, so every later derivation shifted down one slot.

is_out_to_acc_precomp indexes that vector by the output index, so once the
list is short the lookup either falls off the bounds check or reads the
derivation belonging to a different output. Either way the helper reports that
the output does not belong to the address, and the wallet cannot build a key
image for an output it owns. Anyone who can put a transaction in front of the
wallet chooses those pubkeys.

The main tx pubkey a few lines up already handles a failed derivation by
keeping its slot and padding with identity, and wallet2 does the same in the
three places it builds this list (wallet2.cpp:2393, :7887, :13397). Do it here
too.
2026-07-31 23:37:25 -05:00
reservedbytes c6ef8d2caa device: fix ledger status code reporting 2026-07-31 22:47:04 +00:00
tobtoht ae3931c1d9 Merge pull request #10799
9268681 p2p: reject IPv4-mapped IPv6 peers (selsta)

ACKs: jpk68, plowsof
2026-07-31 21:37:02 +00:00