The hardcoded tx_hex blobs are monero-format (RCTTypeBulletproofPlus,
ring size 16). Wownero uses RCTTypeBulletproofPlus_FullCommit (type 9)
and ring size 22, so parse_and_validate_tx_from_blob rejects them and
the tests fail at the parse step.
Functional bp+ correctness is still covered by the 136 ringct.* tests
which all pass. Re-enable by regenerating the blobs from real wow
transactions.
There are quite a few variables in the code that are no longer
(or perhaps never were) in use. These were discovered by enabling
compiler warnings for unused variables and cleaning them up.
In most cases where the unused variables were the result
of a function call the call was left but the variable
assignment removed, unless it was obvious that it was
a simple getter with no side effects.
- fix integer overflow in n_bulletproof_amounts
- check input scalars are in range
- remove use of environment variable to tweak straus performance
- do not use implementation defined signed shift for signum
jwinterm