common: remove dead code

Each symbol below has no references anywhere in the tree (src/, contrib/,
tests/), and none on the in-flight FCMP++ (fcmp++-stage-new) or CARROT
(carrot_impl) integration branches; the full build still links cleanly.
Per-symbol history is given so the "why is this unused" is auditable (hashes
are ancestors of HEAD).

command_line:
- parse_command_line template: boost wrapper used by the connectivity tool and
  wallet from the 2014 import; the last caller was removed in b8a08f199 (2017,
  "wallet: fix --log-file not working"). Not boost's own
  boost::program_options::parse_command_line, a different function still in use.

download:
- download_finished / download_error: dead on arrival - added 63f0e074e (2017,
  "download: async API") but never wired to any caller.

perf_timer:
- set_performance_timer_log_level: dead on arrival - added 74dfdb0b3 (2016),
  never called. It was the only writer of performance_timer_log_level, which is
  therefore never reassigned and stays at its default (el::Level::Info).

Note: the unused PERF_TIMER_L / PERF_TIMER_UNIT_L macros are deliberately left
in place - the FCMP++ wallet-scanning work (fcmp++-stage-new, wallet2.cpp) uses
PERF_TIMER_L, so removing them would break that branch on rebase.
This commit is contained in:
Thomas
2026-06-30 21:11:20 +02:00
parent 8701fc98a2
commit fa91ae4644
5 changed files with 0 additions and 42 deletions
-13
View File
@@ -219,19 +219,6 @@ namespace command_line
description.add_options()(arg.name, boost::program_options::bool_switch(), arg.description);
}
template<typename charT>
boost::program_options::basic_parsed_options<charT> parse_command_line(int argc, const charT* const argv[],
const boost::program_options::options_description& desc, bool allow_unregistered = false)
{
auto parser = boost::program_options::command_line_parser(argc, argv);
parser.options(desc);
if (allow_unregistered)
{
parser.allow_unregistered();
}
return parser.run();
}
template<typename F>
bool handle_error_helper(const boost::program_options::options_description& desc, F parser)
{