p2p: use a bool for send()

Identified by @selsta

Callers can otherwise misinterpret int -1 as truthy success,
e.g. see make_payload_send_txs

contrib/epee/include/net/levin_protocol_handler_async.h

@@ -111,7 +111,7 @@ public:
   template<class callback_t>
   int invoke_async(int command, message_writer in_msg, boost::uuids::uuid connection_id, const callback_t &cb, std::chrono::milliseconds timeout = LEVIN_DEFAULT_TIMEOUT_PRECONFIGURED);
 
-  int send(epee::byte_slice message, const boost::uuids::uuid& connection_id);
+  bool send(epee::byte_slice message, const boost::uuids::uuid& connection_id);
   bool close(boost::uuids::uuid connection_id, const bool wait_for_shutdown);
   bool request_callback(boost::uuids::uuid connection_id);
   template<class callback_t>
@@ -640,15 +640,15 @@ public:
       `message_writer::finalize_notify`. See additional instructions for
       `make_fragmented_notify`.
 
-      \return 1 on success */
+      \return true on success */
-  int send(byte_slice message)
+  bool send(byte_slice message)
   {
     if (!send_message(std::move(message)))
     {
       LOG_ERROR_CC(m_connection_context, "Failed to send message, dropping it");
-      return -1;
+      return false;
     }
-    return 1;
+    return true;
   }
   //------------------------------------------------------------------------------------------
   boost::uuids::uuid get_connection_id() {return m_connection_context.m_connection_id;}
@@ -799,10 +799,10 @@ void async_protocol_handler_config<t_connection_context>::set_handler(levin_comm
 }
 //------------------------------------------------------------------------------------------
 template<class t_connection_context>
-int async_protocol_handler_config<t_connection_context>::send(byte_slice message, const boost::uuids::uuid& connection_id)
+bool async_protocol_handler_config<t_connection_context>::send(byte_slice message, const boost::uuids::uuid& connection_id)
 {
   const std::shared_ptr<levin_endpoint> aph = find_and_lock_connection(connection_id);
-  return aph ? aph->m_protocol_handler.send(std::move(message)) : 0;
+  return aph ? aph->m_protocol_handler.send(std::move(message)) : false;
 }
 //------------------------------------------------------------------------------------------
 template<class t_connection_context>

contrib/epee/include/storages/levin_abstract_invoke2.h

@@ -110,10 +110,10 @@ namespace epee
       levin::message_writer to_send;
       stg.store_to_binary(to_send.buffer);
 
-      int res = transport.send(to_send.finalize_notify(command), conn_id);
+      bool res = transport.send(to_send.finalize_notify(command), conn_id);
-      if(res <=0 )
+      if(!res)
       {
-        MERROR("Failed to notify command " << command << " return code " << res);
+        MERROR("Failed to notify command " << command);
         return false;
       }
       return true;

src/p2p/net_node.inl

@@ -2503,8 +2503,8 @@ namespace nodetool
       return false;
 
     network_zone& zone = m_network_zones.at(context.m_remote_address.get_zone());
-    int res = zone.m_net_server.get_config_object().send(message.finalize_notify(command), context.m_connection_id);
+    bool res = zone.m_net_server.get_config_object().send(message.finalize_notify(command), context.m_connection_id);
-    return res > 0;
+    return res;
   }
   //-----------------------------------------------------------------------------------
   template<class t_payload_net_handler>

tests/unit_tests/levin.cpp

@@ -2470,8 +2470,8 @@ TEST_F(levin_notify, command_max_bytes)
         bytes = dest.finalize_notify(ping_command);
     }
 
-    EXPECT_EQ(1, get_connections().send(bytes.clone(), contexts_.front()->get_id()));
+    EXPECT_TRUE(get_connections().send(bytes.clone(), contexts_.front()->get_id()));
-    EXPECT_EQ(1u, contexts_.front()->process_send_queue(true));
+    EXPECT_TRUE(contexts_.front()->process_send_queue(true));
     EXPECT_EQ(1u, receiver_.notified_size());
 
     const received_message msg = receiver_.get_raw_notification();
@@ -2486,7 +2486,7 @@ TEST_F(levin_notify, command_max_bytes)
         bytes = dest.finalize_notify(ping_command);
     }
 
-    EXPECT_EQ(1, get_connections().send(std::move(bytes), contexts_.front()->get_id()));
+    EXPECT_TRUE(get_connections().send(std::move(bytes), contexts_.front()->get_id()));
-    EXPECT_EQ(1u, contexts_.front()->process_send_queue(false));
+    EXPECT_TRUE(contexts_.front()->process_send_queue(false));
     EXPECT_EQ(0u, receiver_.notified_size());
 }