github-wownero/wownero
1
0
Fork 0
mirror of https://github.com/wownero/wownero.git synced 2026-10-17 07:31:35 +02:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #467 from j-berman/fix-recipient-dests

Browse Source 
wallet: fix recipientAddress to return tx dests excl change
This commit is contained in:
Justin Berman
2026-09-22 20:03:46 -07:00
committed by GitHub
parent efa36c7c55 30d8d87c86
commit 6d10c4d07e
1 changed files with 5 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/wallet/api/unsigned_transaction.cpp
+5 -10
View File
@@ -302,20 +302,15 @@ std::vector<std::string> UnsignedTransactionImpl::paymentId() const
std::vector<std::string> UnsignedTransactionImpl::recipientAddress() const std::vector<std::string> UnsignedTransactionImpl::recipientAddress() const
{ {
const auto addr_dev = m_wallet.m_wallet->get_cryptonote_address_device(); const auto k_view_dev = this->m_wallet.m_wallet->get_view_incoming_key_device();
// TODO: return integrated address if short payment ID exists // TODO: return integrated address if short payment ID exists
std::vector<string> result; std::vector<string> result;
result.reserve(m_tx_proposals.size()); result.reserve(8 * m_tx_proposals.size()); // just a guess
for (const tools::wallet::tx_reconstruct_variant_t &tx_proposal: m_tx_proposals) { for (const tools::wallet::tx_reconstruct_variant_t &tx_proposal: m_tx_proposals) {
const auto dsts = finalized_destinations(tx_proposal, *addr_dev); const auto dsts = tools::wallet::user_destinations(tx_proposal, *k_view_dev);
if (dsts.empty()) { for (const cryptonote::tx_destination_entry &dst : dsts)
MERROR("empty destinations, skipped"); result.push_back(cryptonote::get_account_address_as_str(m_wallet.m_wallet->nettype(), dst.is_subaddress, dst.addr));
continue;
}
for (const auto &unsigned_dest : dsts) {
result.push_back(cryptonote::get_account_address_as_str(m_wallet.m_wallet->nettype(), unsigned_dest.is_subaddress, unsigned_dest.addr));
}
} }
return result; return result;
} }