github-wownero/wownero
1
0
Fork 0
mirror of https://github.com/wownero/wownero.git synced 2026-10-17 07:31:35 +02:00
Code Issues Packages Projects Releases Wiki Activity

wallet2: validate cached transfer indices

Browse Source 
Reported by hacksandhops

(cherry picked from commit 72d91039eb5c67c7912ef8328299e8e28d9effb0)
This commit is contained in:
selsta
2026-10-04 18:50:21 -04:00
committed by such-gitea
parent 255134738b
commit 2084879447
1 changed files with 14 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/wallet/wallet2.cpp
+14
View File
@@ -2702,6 +2702,9 @@ void wallet2::process_new_transaction(const crypto::hash &txid, const cryptonote
auto it = m_key_images.find(in_to_key.k_image); auto it = m_key_images.find(in_to_key.k_image);
if(it != m_key_images.end()) if(it != m_key_images.end())
{ {
THROW_WALLET_EXCEPTION_IF(it->second >= m_transfers.size(), error::wallet_internal_error,
std::string("Key images cache contains illegal transfer offset: ") + std::to_string(it->second)
+ " m_transfers.size() = " + std::to_string(m_transfers.size()));
transfer_details& td = m_transfers[it->second]; transfer_details& td = m_transfers[it->second];
uint64_t amount = in_to_key.amount; uint64_t amount = in_to_key.amount;
if (amount > 0) if (amount > 0)
@@ -6696,6 +6699,14 @@ void wallet2::load_wallet_cache(const bool use_fs, const std::string& cache_buf)
ar >> *this; ar >> *this;
} }
} }
for (const auto &key_image : m_key_images)
THROW_WALLET_EXCEPTION_IF(key_image.second >= m_transfers.size(), error::wallet_internal_error,
std::string("Key images cache contains illegal transfer offset: ") + std::to_string(key_image.second)
+ " m_transfers.size() = " + std::to_string(m_transfers.size()));
for (const auto &pub_key : m_pub_keys)
THROW_WALLET_EXCEPTION_IF(pub_key.second >= m_transfers.size(), error::wallet_internal_error,
std::string("Public keys cache contains illegal transfer offset: ") + std::to_string(pub_key.second)
+ " m_transfers.size() = " + std::to_string(m_transfers.size()));
THROW_WALLET_EXCEPTION_IF( THROW_WALLET_EXCEPTION_IF(
m_account_public_address.m_spend_public_key != m_account.get_keys().m_account_address.m_spend_public_key || m_account_public_address.m_spend_public_key != m_account.get_keys().m_account_address.m_spend_public_key ||
m_account_public_address.m_view_public_key != m_account.get_keys().m_account_address.m_view_public_key, m_account_public_address.m_view_public_key != m_account.get_keys().m_account_address.m_view_public_key,
@@ -12625,6 +12636,9 @@ std::string wallet2::get_spend_proof(const crypto::hash &txid, const std::string
} }
// derive the real output keypair // derive the real output keypair
THROW_WALLET_EXCEPTION_IF(found->second >= m_transfers.size(), error::wallet_internal_error,
std::string("Key images cache contains illegal transfer offset: ") + std::to_string(found->second)
+ " m_transfers.size() = " + std::to_string(m_transfers.size()));
const transfer_details& in_td = m_transfers[found->second]; const transfer_details& in_td = m_transfers[found->second];
crypto::public_key in_tx_out_pkey = in_td.get_public_key(); crypto::public_key in_tx_out_pkey = in_td.get_public_key();
const crypto::public_key in_tx_pub_key = get_tx_pub_key_from_extra(in_td.m_tx, in_td.m_pk_index); const crypto::public_key in_tx_pub_key = get_tx_pub_key_from_extra(in_td.m_tx, in_td.m_pk_index);