ringct & cryptonote_basic: detangle dependencies

mirror of https://github.com/wownero/wownero.git synced 2026-10-22 09:58:34 +02:00

`libringct` was linking against `libcryptonote_basic` for a single, one-line convenience function: `cryptonote::get_blob_hash`.
Since `cryptonote_basic.h` includes `rctTypes.h`, this one function effectively made an explicit circular dependency between
the two libraries. `cryptonote_format_utils.cpp` was including header `rctSigs.h` from `libringct`, when only `rctOps.h` from
`libringct_basic` needed to be included. `libcryptonote_basic` wasn't explictly linking against `libringct_basic` nor
`libringct` like it should have. And `libblockchain_db` wasn't linking against `libcryptonote_basic` like it should have. We
can also downgrade `libblockchain_db`'s dependency on `libringct` to `libringct_basic`.

This commit is contained in:

jeffro256

2025-05-07 19:52:24 -05:00

parent 3b01c49095

commit 06b74ae3f5

5 changed files with 10 additions and 6 deletions

									
										src/cryptonote_basic/cryptonote_format_utils.cpp
									
		+1
		-1
	
												View File
												
				@@ -38,7 +38,7 @@

				#include "cryptonote_config.h"

				#include "crypto/crypto.h"

				#include "crypto/hash.h"

				#include "ringct/rctSigs.h"

				#include "ringct/rctOps.h"

				using namespace epee;