From 7bb7f78349c833140be6e5186a9c28a62585e067 Mon Sep 17 00:00:00 2001 From: woodser Date: Mon, 15 Jul 2019 15:24:22 -0400 Subject: [PATCH] manually offset wallet2.get_payments() min_height by -1 per #5751, #5598 --- src/wallet/MoneroWallet.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/wallet/MoneroWallet.cpp b/src/wallet/MoneroWallet.cpp index e1337df..99552a2 100644 --- a/src/wallet/MoneroWallet.cpp +++ b/src/wallet/MoneroWallet.cpp @@ -1308,7 +1308,7 @@ namespace monero { // build parameters for wallet2->get_payments() uint64_t minHeight = txReq.minHeight == boost::none ? 0 : *txReq.minHeight; uint64_t maxHeight = txReq.maxHeight == boost::none ? CRYPTONOTE_MAX_BLOCK_NUMBER : min((uint64_t) CRYPTONOTE_MAX_BLOCK_NUMBER, *txReq.maxHeight); - if (minHeight > 0) minHeight--; // TODO monero core: wallet2::get_payments() min_height is exclusive, so manually offset to match intended range (https://github.com/monero-project/monero/issues/5751) + if (minHeight > 0) minHeight--; // TODO monero core: wallet2::get_payments() min_height is exclusive, so manually offset to match intended range (issues 5751, #5598) boost::optional accountIndex = boost::none; if (request.accountIndex != boost::none) accountIndex = *request.accountIndex; std::set subaddressIndices;