From 48aaa26083024f1a771df7f966c22ae43a04a90c Mon Sep 17 00:00:00 2001 From: woodser Date: Sun, 14 Jul 2019 10:44:56 -0400 Subject: [PATCH] offset wallet2 get_payments() min_height by -1 because it's exclusive --- src/wallet/MoneroWallet.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/wallet/MoneroWallet.cpp b/src/wallet/MoneroWallet.cpp index 2acf6df..e1337df 100644 --- a/src/wallet/MoneroWallet.cpp +++ b/src/wallet/MoneroWallet.cpp @@ -1308,6 +1308,7 @@ namespace monero { // build parameters for wallet2->get_payments() uint64_t minHeight = txReq.minHeight == boost::none ? 0 : *txReq.minHeight; uint64_t maxHeight = txReq.maxHeight == boost::none ? CRYPTONOTE_MAX_BLOCK_NUMBER : min((uint64_t) CRYPTONOTE_MAX_BLOCK_NUMBER, *txReq.maxHeight); + if (minHeight > 0) minHeight--; // TODO monero core: wallet2::get_payments() min_height is exclusive, so manually offset to match intended range (https://github.com/monero-project/monero/issues/5751) boost::optional accountIndex = boost::none; if (request.accountIndex != boost::none) accountIndex = *request.accountIndex; std::set subaddressIndices;