Commit Graph
13 Commits
Author SHA1 Message Date
oblivionsage d248417f2c fix: prevent integer underflow in amount() bounds check
The bounds check 'index > arr.size() - 1' has an edge case bug.
When arr.size() is 0, subtracting 1 from an unsigned size_t
underflows to SIZE_MAX, so 'index > SIZE_MAX' is always false.

This could theoretically allow out-of-bounds access, though it's
pretty hard to trigger in practice - would need a malformed/corrupted
unsigned_tx file that parses successfully but has no transactions.

Changed to 'arr.empty() || index >= arr.size()' which handles
the edge case properly.

Found with AddressSanitizer during fuzzing.
2025-11-13 01:52:38 +01:00
tobtoht 2c5f766a7b libwalletqt: cleanup 2025-03-12 11:23:03 +01:00
tobtoht 4f28d83ac3 History: cleanup 2025-03-12 10:04:33 +01:00
tobtoht dff4752e82 update copyright for 2025 2025-02-20 18:52:03 +01:00
tobtoht 8ab420b802 cleanup includes 2024-10-01 22:17:54 +02:00
tobtoht 4c7015f76f update copyright to 2024 2024-01-01 18:07:58 +01:00
tobtoht 51b0fcc19d airgapped signing with UR 2023-12-04 16:06:33 +01:00
tobtoht 64f425badf update copyright for 2023 2023-01-02 20:31:22 +01:00
tobtoht 938d2ddb4e Update copyright to 2022 2022-02-10 11:26:41 +01:00
tobtoht b758cc1918 Misc code cleanup 2020-12-28 05:39:20 +01:00
tobtoht b4fd07ff8b Update copyright for 2021 2020-12-26 20:56:06 +01:00
tobtoht 216b2e0c5e Offline transaction signing 2020-10-19 01:39:23 +02:00
dscandtobtoht 133700160a Feather, a free Monero desktop wallet
Co-Authored-By: tobtoht <thotbot@protonmail.com>
2020-10-08 04:31:22 +02:00