wownerogue/test/walletRPCService.test.js

const WalletRPCService = require('../src/payments/walletRPCService');

// Minimal debugManager mock
const debugManagerMock = { CONSOLE_LOGGING: false };

describe('WalletRPCService interface', () => {

  test('exposes expected methods', () => {
    const svc = new WalletRPCService(debugManagerMock);
    expect(typeof svc.initialize).toBe('function');
    expect(typeof svc.rpcCall).toBe('function');
    expect(typeof svc.createPaymentRequest).toBe('function');
    expect(typeof svc.checkPaymentStatus).toBe('function');
    expect(typeof svc.startPaymentMonitoring).toBe('function');
    expect(typeof svc.stopPaymentMonitoring).toBe('function');
    expect(typeof svc.processBatchPayouts).toBe('function'); // newly added stub
    expect(typeof svc.processPayout).toBe('function');
    expect(typeof svc.normalizeAtomicAmount).toBe('function');
    expect(typeof svc.cleanupUserPayments).toBe('function');
    expect(typeof svc.getHealthStatus).toBe('function');
  });

  test('processBatchPayouts stub returns processed:0', async () => {
    const svc = new WalletRPCService(debugManagerMock);
    const res = await svc.processBatchPayouts();
    expect(res).toEqual({ processed: 0 });
  });

  test('rpcCall wraps failures in ExternalServiceError', async () => {
    const svc = new WalletRPCService(debugManagerMock);
    svc.walletEndpoint = 'http://127.0.0.1:65535';

    await expect(svc.rpcCall('get_height')).rejects.toMatchObject({
      code: 'EXTERNAL_SERVICE_ERROR',
      safeMessage: 'Wallet RPC call failed.'
    });
  });

  test('createPaymentRequest rethrows wrapped errors', async () => {
    const svc = new WalletRPCService(debugManagerMock);
    svc.rpcCall = jest.fn().mockRejectedValue(new Error('rpc unavailable'));

    await expect(
      svc.createPaymentRequest(10, 'test payment', 'user-1', 'socket-1')
    ).rejects.toMatchObject({
      code: 'EXTERNAL_SERVICE_ERROR',
      safeMessage: 'Unable to create a payment address at this time.'
    });
  });
});

describe('WalletRPCService.normalizeAtomicAmount', () => {
  let svc;

  beforeEach(() => {
    svc = new WalletRPCService(debugManagerMock);
  });

  test('accepts valid positive number', () => {
    expect(svc.normalizeAtomicAmount(100)).toBe(100);
    expect(svc.normalizeAtomicAmount(1)).toBe(1);
    expect(svc.normalizeAtomicAmount(100000000000)).toBe(100000000000);
  });

  test('accepts valid positive bigint', () => {
    expect(svc.normalizeAtomicAmount(100n)).toBe(100);
    expect(svc.normalizeAtomicAmount(1n)).toBe(1);
  });

  test('converts large bigint to string when beyond safe integer', () => {
    const largeValue = BigInt(Number.MAX_SAFE_INTEGER) + 1000n;
    const result = svc.normalizeAtomicAmount(largeValue);
    expect(typeof result).toBe('string');
    expect(result).toBe(largeValue.toString());
  });

  test('truncates floating point numbers to integers', () => {
    expect(svc.normalizeAtomicAmount(100.9)).toBe(100);
    expect(svc.normalizeAtomicAmount(100.1)).toBe(100);
    expect(svc.normalizeAtomicAmount(99.9999)).toBe(99);
  });

  test('throws on zero amount', () => {
    expect(() => svc.normalizeAtomicAmount(0)).toThrow();
  });

  test('throws on negative amount', () => {
    expect(() => svc.normalizeAtomicAmount(-100)).toThrow();
    expect(() => svc.normalizeAtomicAmount(-1)).toThrow();
  });

  test('throws on zero bigint', () => {
    expect(() => svc.normalizeAtomicAmount(0n)).toThrow();
  });

  test('throws on negative bigint', () => {
    expect(() => svc.normalizeAtomicAmount(-100n)).toThrow();
  });

  test('throws on null/undefined', () => {
    expect(() => svc.normalizeAtomicAmount(null)).toThrow();
    expect(() => svc.normalizeAtomicAmount(undefined)).toThrow();
  });

  test('throws on NaN', () => {
    expect(() => svc.normalizeAtomicAmount(NaN)).toThrow();
  });

  test('throws on Infinity', () => {
    expect(() => svc.normalizeAtomicAmount(Infinity)).toThrow();
    expect(() => svc.normalizeAtomicAmount(-Infinity)).toThrow();
  });

  test('throws when truncated value is zero', () => {
    expect(() => svc.normalizeAtomicAmount(0.5)).toThrow();
    expect(() => svc.normalizeAtomicAmount(0.001)).toThrow();
  });
});

describe('WalletRPCService.processPayout', () => {
  let svc;

  beforeEach(() => {
    svc = new WalletRPCService(debugManagerMock);
  });

  test('validates address is provided', async () => {
    await expect(svc.processPayout({ amount: 100 }))
      .rejects.toThrow(/address/i);
    
    await expect(svc.processPayout({ address: '', amount: 100 }))
      .rejects.toThrow(/address/i);
    
    await expect(svc.processPayout({ address: 123, amount: 100 }))
      .rejects.toThrow(/address/i);
  });

  test('validates amount is positive', async () => {
    await expect(svc.processPayout({ 
      address: 'wow1addr', 
      amount: 0 
    })).rejects.toThrow(/amount/i);

    await expect(svc.processPayout({ 
      address: 'wow1addr', 
      amount: -100 
    })).rejects.toThrow(/amount/i);
  });

  test('calls transfer RPC with correct parameters', async () => {
    svc.rpcCall = jest.fn().mockResolvedValueOnce({
      result: {
        tx_hash: 'abc123def456',
        tx_key: 'key789',
        fee: 1000000
      }
    });

    const result = await svc.processPayout({
      address: 'wow1testaddress123456789',
      amount: 100000000000,
      userId: 'user1',
      gameId: 'game123'
    });
    
    expect(result.success).toBe(true);
    expect(result.txHash).toBe('abc123def456');
    expect(result.txKey).toBe('key789');
    expect(result.fee).toBe(1000000);
    expect(result.userId).toBe('user1');
    expect(result.gameId).toBe('game123');
    expect(result.amount).toBe(100000000000);
    
    expect(svc.rpcCall).toHaveBeenCalledWith('transfer', {
      destinations: [{
        amount: 100000000000,
        address: 'wow1testaddress123456789'
      }],
      account_index: 0,
      priority: 1,
      get_tx_key: true
    });
  });

  test('includes subaddr_indices when subaddressIndex specified', async () => {
    svc.rpcCall = jest.fn().mockResolvedValueOnce({
      result: { tx_hash: 'xyz', tx_key: 'key', fee: 100 }
    });

    await svc.processPayout({
      address: 'wow1addr',
      amount: 100,
      subaddressIndex: 5
    });
    
    expect(svc.rpcCall).toHaveBeenCalledWith('transfer', 
      expect.objectContaining({
        subaddr_indices: [5]
      })
    );
  });

  test('does not include subaddr_indices for invalid index values', async () => {
    svc.rpcCall = jest.fn().mockResolvedValueOnce({
      result: { tx_hash: 'xyz', tx_key: 'key', fee: 100 }
    });

    await svc.processPayout({
      address: 'wow1addr',
      amount: 100,
      subaddressIndex: -1
    });
    
    expect(svc.rpcCall).toHaveBeenCalledWith('transfer', 
      expect.not.objectContaining({
        subaddr_indices: expect.anything()
      })
    );
  });

  test('handles RPC failure and wraps error', async () => {
    svc.rpcCall = jest.fn().mockRejectedValueOnce(new Error('Insufficient balance'));

    await expect(svc.processPayout({
      address: 'wow1addr',
      amount: 100
    })).rejects.toMatchObject({
      code: 'EXTERNAL_SERVICE_ERROR',
      safeMessage: 'Unable to send payout at this time.'
    });
  });
});

describe('WalletRPCService.createPaymentRequest', () => {
  let svc;

  beforeEach(() => {
    svc = new WalletRPCService(debugManagerMock);
  });

  test('creates payment request with correct parameters', async () => {
    svc.rpcCall = jest.fn().mockResolvedValueOnce({
      result: {
        address: 'wow1subaddress123',
        address_index: 42
      }
    });

    const result = await svc.createPaymentRequest(
      100000000000,
      'Game entry payment',
      'user123',
      'socket456'
    );

    expect(result.success).toBe(true);
    expect(result.address).toBe('wow1subaddress123');
    expect(result.addressIndex).toBe(42);
    expect(result.amount).toBe(100000000000);
    expect(result.description).toBe('Game entry payment');
    expect(result.id).toBeDefined();
    expect(result.expiresAt).toBeInstanceOf(Date);

    expect(svc.rpcCall).toHaveBeenCalledWith('create_address', {
      account_index: 0,
      label: expect.stringContaining('game_user123_')
    });
  });

  test('stores payment info for monitoring', async () => {
    svc.rpcCall = jest.fn().mockResolvedValueOnce({
      result: {
        address: 'wow1subaddress123',
        address_index: 42
      }
    });

    await svc.createPaymentRequest(
      100000000000,
      'Test payment',
      'user123',
      'socket456'
    );

    expect(svc.addressToUser.has('wow1subaddress123')).toBe(true);
    expect(svc.addressToSocket.has('wow1subaddress123')).toBe(true);

    const userInfo = svc.addressToUser.get('wow1subaddress123');
    expect(userInfo.userId).toBe('user123');
    expect(userInfo.socketId).toBe('socket456');
    expect(userInfo.amount).toBe(100000000000);
    expect(userInfo.addressIndex).toBe(42);
    expect(userInfo.status).toBe('pending');
    expect(userInfo.detected).toBe(false);
    expect(userInfo.confirmed).toBe(false);
  });
});

describe('WalletRPCService Payment Monitoring', () => {
  let svc;

  beforeEach(() => {
    svc = new WalletRPCService(debugManagerMock);
    jest.useFakeTimers();
  });

  afterEach(() => {
    // Cleanup any watchers
    for (const [addr] of svc.paymentWatchers) {
      svc.stopPaymentMonitoring(addr);
    }
    jest.useRealTimers();
  });

  test('starts and stops payment monitoring', () => {
    const callback = jest.fn();
    const address = 'wow1testaddr';
    
    svc.checkPaymentStatus = jest.fn().mockResolvedValue({
      complete: false,
      in_mempool: false,
      confirmed: false
    });

    svc.startPaymentMonitoring(address, callback, 100);
    
    expect(svc.paymentWatchers.has(address)).toBe(true);
    
    svc.stopPaymentMonitoring(address);
    
    expect(svc.paymentWatchers.has(address)).toBe(false);
  });

  test('does not start duplicate monitors for same address', () => {
    const callback = jest.fn();
    const address = 'wow1testaddr';
    
    svc.checkPaymentStatus = jest.fn().mockResolvedValue({
      complete: false
    });

    svc.startPaymentMonitoring(address, callback, 100);
    const firstWatcher = svc.paymentWatchers.get(address);
    
    svc.startPaymentMonitoring(address, callback, 100); // Duplicate
    const secondWatcher = svc.paymentWatchers.get(address);
    
    // Should be the same watcher
    expect(firstWatcher).toBe(secondWatcher);
    expect(svc.paymentWatchers.size).toBe(1);
    
    svc.stopPaymentMonitoring(address);
  });

  test('cleanupUserPayments removes all monitors for user', () => {
    const userId = 'user123';
    const addr1 = 'wow1addr1';
    const addr2 = 'wow1addr2';
    const addr3 = 'wow1addr3'; // Different user
    
    svc.addressToUser.set(addr1, { userId, socketId: 'sock1' });
    svc.addressToUser.set(addr2, { userId, socketId: 'sock2' });
    svc.addressToUser.set(addr3, { userId: 'otherUser', socketId: 'sock3' });
    
    svc.paymentWatchers.set(addr1, setInterval(() => {}, 10000));
    svc.paymentWatchers.set(addr2, setInterval(() => {}, 10000));
    svc.paymentWatchers.set(addr3, setInterval(() => {}, 10000));

    svc.cleanupUserPayments(userId);
    
    expect(svc.paymentWatchers.has(addr1)).toBe(false);
    expect(svc.paymentWatchers.has(addr2)).toBe(false);
    expect(svc.paymentWatchers.has(addr3)).toBe(true); // Different user, not cleaned

    svc.stopPaymentMonitoring(addr3);
  });
});

describe('WalletRPCService.checkPaymentStatus', () => {
  let svc;

  beforeEach(() => {
    svc = new WalletRPCService(debugManagerMock);
  });

  test('returns default status for unknown address', async () => {
    const status = await svc.checkPaymentStatus('unknown_address');
    
    expect(status.complete).toBe(false);
    expect(status.in_mempool).toBe(false);
    expect(status.confirmed).toBe(false);
    expect(status.amount).toBe(0);
    expect(status.confirmations).toBe(0);
  });

  test('checks mempool and confirmed transfers', async () => {
    // Setup: create a payment first
    svc.addressToUser.set('wow1testaddr', {
      userId: 'user1',
      socketId: 'sock1',
      amount: 100000000000,
      addressIndex: 5,
      accountIndex: 0,
      detected: false,
      confirmed: false
    });

    // Mock RPC calls
    svc.rpcCall = jest.fn()
      .mockResolvedValueOnce({
        result: {
          pool: [],
          in: [{
            txid: 'txhash123',
            amount: 100000000000,
            height: 1000
          }]
        }
      })
      .mockResolvedValueOnce({
        result: { height: 1005 } // Current height for confirmations
      });

    const status = await svc.checkPaymentStatus('wow1testaddr');
    
    expect(status.complete).toBe(true);
    expect(status.confirmed).toBe(true);
    expect(status.amount).toBe(100000000000);
    expect(status.confirmations).toBe(5); // 1005 - 1000
    expect(status.txHash).toBe('txhash123');
  });
});

describe('WalletRPCService Health Status', () => {
  test('returns health status object with correct fields', () => {
    const svc = new WalletRPCService(debugManagerMock);
    svc.isHealthy = true;
    svc.paymentWatchers = new Map([['addr1', {}], ['addr2', {}]]);
    svc.addressToUser = new Map([['addr1', {}]]);

    const status = svc.getHealthStatus();
    
    expect(status.healthy).toBe(true);
    expect(status.endpoint).toBe(svc.walletEndpoint);
    expect(status.activeMonitors).toBe(2);
    expect(status.pendingPayments).toBe(1);
  });

  test('reflects unhealthy state', () => {
    const svc = new WalletRPCService(debugManagerMock);
    svc.isHealthy = false;

    const status = svc.getHealthStatus();
    
    expect(status.healthy).toBe(false);
  });
});