github-such-software/wownerogue
1
0
Fork 0
mirror of https://github.com/Such-Software/wownerogue.git synced 2026-10-18 06:41:27 +02:00
Code Issues Packages Projects Releases Wiki Activity

refactor: frontend de-spaghetti (dup declares, dead code, log gating)

Browse Source 
- Remove the duplicate _gameMode declaration in the client SocketHandlers
  object literal — it was declared twice, so the later `null` silently
  shadowed the earlier `'free'`. Now declared once with the effective value.
- Remove the dead SocketHandlers._appendMessage calls in smirkAuth.js; that
  method never existed, so the guard always fell through to the working
  .text() append. Keep the safe append.
- Gate broadcastManager's high-volume per-event logs (user count, chat message
  incl. message/socketId PII, game update, game start) behind debug mode;
  previously they logged on every event regardless of NODE_ENV.

Full suite: 21 suites / 155 tests.
This commit is contained in:
jwinterm
2026-05-31 14:39:12 -04:00
parent d5df5dbd12
commit 7581ba79cb
4 changed files with 25 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/network/broadcastManager.js
+17 -10
View File
@@ -30,8 +30,10 @@ class BroadcastManager {
count = this.io.engine.clientsCount || 0;
}
console.log(`👥 Broadcasting user count: ${count} (last was ${this._lastUserCount})`);
if (this.debugManager?.CONSOLE_LOGGING) {
console.log(`👥 Broadcasting user count: ${count} (last was ${this._lastUserCount})`);
}
// Always broadcast to ensure new clients get the count
this._lastUserCount = count;
this.io.emit('user_count', { count });
@@ -60,8 +62,10 @@ class BroadcastManager {
* @param {string} socketId - Socket ID of the sender
*/
broadcastChatMessage(username, message, timestamp, socketId) {
console.log(`💬 Broadcasting chat message from ${socketId}: "${message}"`);
if (this.debugManager?.CONSOLE_LOGGING) {
console.log(`💬 Broadcasting chat message from ${socketId}: "${message}"`);
}
this.io.emit('chat_broadcast', {
username: username,
message: message,
@@ -100,11 +104,12 @@ class BroadcastManager {
* @param {object} gameState - The game state to broadcast
*/
sendGameUpdate(playerSocketId, gameState) {
// Debug logging for lighting data in updates
console.log(`📡 sendGameUpdate to ${playerSocketId}:`);
console.log(` - Lighting data: ${!!gameState.lighting} (${gameState.lighting ? Object.keys(gameState.lighting).length : 0} rows)`);
console.log(` - Torch data: ${!!gameState.torches} (${gameState.torches ? gameState.torches.length : 0} torches)`);
if (this.debugManager?.CONSOLE_LOGGING) {
console.log(`📡 sendGameUpdate to ${playerSocketId}:`);
console.log(` - Lighting data: ${!!gameState.lighting} (${gameState.lighting ? Object.keys(gameState.lighting).length : 0} rows)`);
console.log(` - Torch data: ${!!gameState.torches} (${gameState.torches ? gameState.torches.length : 0} torches)`);
}
// Send to the player
this.io.to(playerSocketId).emit('game_update', gameState);
@@ -125,7 +130,9 @@ class BroadcastManager {
* @param {object} gameState - Initial game state
*/
sendGameStart(socketId, gameState) {
console.log(`🎮 SENDING GAME_START to ${socketId}`);
if (this.debugManager?.CONSOLE_LOGGING) {
console.log(`🎮 SENDING GAME_START to ${socketId}`);
}
this.io.to(socketId).emit('game_start', gameState);
}