github-such-software/wowcheckout
1
0
Fork 0
mirror of https://github.com/Such-Software/wowcheckout.git synced 2026-10-17 05:51:45 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix(ui): wowcheckout login-form was checking XMR address shape

Browse Source 
isLikelyPrimaryAddress() required exactly 95 chars starting with "4"
— that's the Monero primary-address shape. Wownero primaries are 97
chars starting with "Wo". This was inherited from the xmrcheckout
fork and never updated.

Effect: pasting a valid Wownero address into the login form silently
failed isLikelyPrimaryAddress(), the validate API was never called,
no green VALID indicator rendered, canSubmit stayed false, the Sign
in button stayed greyed out. Suchshop sidestepped this because that
tenant was provisioned via direct SQL/API, not through this form.

Fix: 95 → 97, "4" → "Wo". One file, two lines.

The backend cryptographic validation in routes.py:
_validate_payment_address_and_view_key() was correct all along — it
checks the 2-byte Wownero varint prefix (byte 0 == 178). The UI just
wasn't asking it.
This commit is contained in:
jwinterm
2026-05-18 12:07:01 -04:00
parent f7a39c0bdc
commit 3a8d87e9c9
1 changed files with 9 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ui/app/(app)/login/login-form.tsx
+9 -2
View File
@@ -13,12 +13,19 @@ const base58Pattern = /^[123456789ABCDEFGHJKLMNPQRSTUVWXYZabcdefghijkmnopqrstuvw
const viewKeyPattern = /^[0-9a-fA-F]{64}$/; const viewKeyPattern = /^[0-9a-fA-F]{64}$/;
const validationDelayMs = 450; const validationDelayMs = 450;
// Wownero primary addresses are 97 base58 chars starting with "Wo".
// This guard was inherited from the xmrcheckout fork — XMR addresses
// are 95 chars starting with "4". The xmrcheckout-shape check
// silently rejected every Wownero address, leaving the Sign in
// button greyed out and the validate API never called. Suchshop
// avoided this because that tenant was provisioned via direct SQL,
// not via this form.
const isLikelyPrimaryAddress = (value: string) => { const isLikelyPrimaryAddress = (value: string) => {
const trimmed = value.trim(); const trimmed = value.trim();
if (trimmed.length !== 95) { if (trimmed.length !== 97) {
return false; return false;
} }
if (!trimmed.startsWith("4")) { if (!trimmed.startsWith("Wo")) {
return false; return false;
} }
return base58Pattern.test(trimmed); return base58Pattern.test(trimmed);