Files
smirk-backend-core/tests/erasure.rs
T
jwinterm 8120d93fb8 fix(erasure): harden per adversarial review (Subsystem 5)
6 confirmed findings (review wqrd2gka3), 3 root-cause fixes:

- HIGH: execute_erasure had no status recheck and the sweeper's SKIP LOCKED row
  lock was released before execution (separate connection), so (a) a request
  CANCELLED after the sweep's SELECT was still executed, and (b) a fleet could
  double-execute one erasure (duplicate hash-chained audit row, double count).
  Fixed by making execution atomically CLAIM the row as its first statement —
  `UPDATE ... SET status='completed' WHERE id=$1 AND status='confirmed'
  RETURNING user_id` — and skipping (returns false) when 0 rows match. Only the
  first executor of a still-confirmed request proceeds; a cancelled/already-done
  row is a no-op; on any later failure the whole tx (claim included) rolls back.
- account-existence oracle: the absent-user request path returned a FRESH random
  erasure_id + advancing scheduled_for each call, while a real account returned a
  STABLE get-or-create id — a re-call distinguisher. The request response is now
  constant-shape: a STABLE id (real, or a deterministic integrity-secret-keyed
  synthetic for the absent path), a fixed "pending" status, and NO scheduled_for
  (it's meaningful only at confirm, where grace starts, and is returned there).
- config: ERASURE_GRACE_PERIOD_HOURS is bounded (<= 10 years) in validate(), so
  the u64->i64 cast can't wrap negative (defeating grace) and Duration::hours
  can't panic.

Dismissed after verification: ERASURE_ENABLED without FEATURE_NOSTR_IDENTITY
(validate already requires PUBLIC_API_URL; the nostr_identity coupling is a
nicety). Tests extended: cancelled-request-not-executed (HIGH regression),
double-execute no-op. 140 lib + 140 integration green, no drift, scans clean.
2026-06-28 07:59:52 -04:00

291 lines
8.8 KiB
Rust

//! L1 integration: self-service erasure (operator §5) — the full action-bound
//! two-phase flow (export, request -> confirm -> execute) plus the absent-user
//! constant-shape path. One sequential test (it toggles process env to enable
//! erasure with a zero grace window so the sweeper executes immediately).
mod common;
use axum::http::StatusCode;
use base64::Engine;
use k256::schnorr::SigningKey;
use rand::rngs::OsRng;
use rand::RngCore;
use sha2::{Digest, Sha256};
use smirk_backend_core::core::crypto::nip98::{descriptor_sha256, request_descriptor};
use smirk_backend_core::models::db::NewUser;
const KIND: u32 = 27235;
fn random_signer() -> SigningKey {
loop {
let mut b = [0u8; 32];
OsRng.fill_bytes(&mut b);
if let Ok(sk) = SigningKey::from_bytes(&b) {
return sk;
}
}
}
async fn mk_user(db: &smirk_backend_core::infra::db::Database, nostr_pubkey: &str) -> uuid::Uuid {
db.create_user(NewUser {
username: None,
pubkey_hash: Some(format!("pk-{}", uuid::Uuid::new_v4())),
nostr_pubkey: Some(nostr_pubkey.to_string()),
wallet_birthday: None,
seed_fingerprint: None,
xmr_start_height: None,
wow_start_height: None,
})
.await
.unwrap()
.id
}
/// Build a `Nostr <base64(event)>` signed-action token for an erasure purpose.
fn sign(
sk: &SigningKey,
url: &str,
purpose: &str,
nonce: &str,
descriptor_path: &str,
target: Option<(&str, &str)>,
) -> String {
let pk = hex::encode(sk.verifying_key().to_bytes());
let payload = descriptor_sha256(&request_descriptor("POST", descriptor_path, "", b""));
let mut tags = vec![
vec!["u".to_string(), url.to_string()],
vec!["method".to_string(), "POST".to_string()],
vec!["purpose".to_string(), purpose.to_string()],
vec!["challenge".to_string(), nonce.to_string()],
vec!["payload".to_string(), payload],
];
if let Some((k, v)) = target {
tags.push(vec![k.to_string(), v.to_string()]);
}
let created_at = chrono::Utc::now().timestamp();
let serial =
serde_json::to_string(&serde_json::json!([0, pk, created_at, KIND, tags, ""])).unwrap();
let id = hex::encode(Sha256::digest(serial.as_bytes()));
let sig = sk.sign_raw(&hex::decode(&id).unwrap(), &[0u8; 32]).unwrap();
let ev = serde_json::json!({
"id": id, "pubkey": pk, "created_at": created_at,
"kind": KIND, "tags": tags, "content": "", "sig": hex::encode(sig.to_bytes())
});
format!(
"Nostr {}",
base64::engine::general_purpose::STANDARD.encode(serde_json::to_vec(&ev).unwrap())
)
}
#[tokio::test]
async fn erasure_request_confirm_execute_flow() {
std::env::set_var("ERASURE_ENABLED", "true");
std::env::set_var(
"ADMIN_KEY_INTEGRITY_SECRET",
"erasure-integrity-secret-at-least-32-bytes!",
);
std::env::set_var("ERASURE_GRACE_PERIOD_HOURS", "0"); // execute immediately
let app = require_app!();
let base = app
.state
.config
.identity
.public_api_url
.clone()
.expect("PUBLIC_API_URL");
// A user with a linked nostr identity that we control the key for.
let sk = random_signer();
let pk = hex::encode(sk.verifying_key().to_bytes());
mk_user(&app.state.db, &pk).await;
let challenge = |purpose: &'static str| {
let app = &app;
async move {
let (st, body) = app
.request(
"POST",
"/api/v1/account/erasure/challenge",
None,
Some(serde_json::json!({ "purpose": purpose })),
)
.await;
assert_eq!(st, StatusCode::OK, "challenge {purpose}");
body["challenge"].as_str().unwrap().to_string()
}
};
// Export (see-before-delete): proof-gated, returns no view keys.
let nonce = challenge("erasure_export").await;
let token = sign(
&sk,
&format!("{base}/account/export"),
"erasure_export",
&nonce,
"/api/v1/account/export",
None,
);
let (st, body) = app
.request(
"POST",
"/api/v1/account/export",
None,
Some(serde_json::json!({ "token": token, "nonce": nonce })),
)
.await;
assert_eq!(st, StatusCode::OK, "export: {body:?}");
assert_eq!(body["nostr_pubkey"].as_str().unwrap(), pk);
// Phase 1: request.
let nonce = challenge("erasure_request").await;
let token = sign(
&sk,
&format!("{base}/account/erasure"),
"erasure_request",
&nonce,
"/api/v1/account/erasure",
None,
);
let (st, body) = app
.request(
"POST",
"/api/v1/account/erasure",
None,
Some(serde_json::json!({ "token": token, "nonce": nonce })),
)
.await;
assert_eq!(st, StatusCode::OK, "request: {body:?}");
let erasure_id = body["erasure_id"].as_str().unwrap().to_string();
assert_eq!(body["status"], "pending");
// Phase 2: confirm (bound to the erasure_id).
let nonce = challenge("erasure_confirm").await;
let confirm_path = format!("/account/erasure/{erasure_id}/confirm");
let token = sign(
&sk,
&format!("{base}{confirm_path}"),
"erasure_confirm",
&nonce,
&format!("/api/v1{confirm_path}"),
Some(("erasure_id", &erasure_id)),
);
let (st, body) = app
.request(
"POST",
&format!("/api/v1{confirm_path}"),
None,
Some(serde_json::json!({ "token": token, "nonce": nonce })),
)
.await;
assert_eq!(st, StatusCode::OK, "confirm: {body:?}");
assert_eq!(body["status"], "confirmed");
// Execute (grace = 0, so it is due now).
let n = smirk_backend_core::api::erasure::run_erasure_sweep(&app.state, 50)
.await
.unwrap();
assert!(n >= 1, "at least our request executed");
// The user is gone.
assert!(
app.state
.db
.find_user_by_nostr_pubkey(&pk)
.await
.unwrap()
.is_none(),
"account erased"
);
// Absent user: a proof from an unlinked key returns the SAME shape (no oracle).
let stranger = random_signer();
let nonce = challenge("erasure_request").await;
let token = sign(
&stranger,
&format!("{base}/account/erasure"),
"erasure_request",
&nonce,
"/api/v1/account/erasure",
None,
);
let (st, body) = app
.request(
"POST",
"/api/v1/account/erasure",
None,
Some(serde_json::json!({ "token": token, "nonce": nonce })),
)
.await;
assert_eq!(st, StatusCode::OK, "absent-user request is constant-shape");
assert!(body["erasure_id"].as_str().is_some());
assert_eq!(body["status"], "pending");
let secret = app.state.config.admin.key_integrity_secret.clone();
// [HIGH regression] a request CANCELLED after confirmation is NOT executed:
// execute claims `WHERE status='confirmed'`, so a cancelled row is skipped.
let pk_c = hex::encode(random_signer().verifying_key().to_bytes());
let uc = mk_user(&app.state.db, &pk_c).await;
let rc = app.state.db.request_erasure(uc, "h", 0).await.unwrap();
app.state
.db
.confirm_erasure_request(rc.id, uc, 0)
.await
.unwrap();
app.state
.db
.cancel_erasure_request(rc.id, uc)
.await
.unwrap();
assert!(
!app.state
.db
.execute_erasure(rc.id, true, &secret)
.await
.unwrap(),
"cancelled request is not executed"
);
assert!(
app.state
.db
.find_user_by_nostr_pubkey(&pk_c)
.await
.unwrap()
.is_some(),
"cancelled user survives"
);
// Double-execution is a no-op (idempotent claim): the second call returns false.
let pk_d = hex::encode(random_signer().verifying_key().to_bytes());
let ud = mk_user(&app.state.db, &pk_d).await;
let rd = app.state.db.request_erasure(ud, "h", 0).await.unwrap();
app.state
.db
.confirm_erasure_request(rd.id, ud, 0)
.await
.unwrap();
assert!(app
.state
.db
.execute_erasure(rd.id, true, &secret)
.await
.unwrap());
assert!(
!app.state
.db
.execute_erasure(rd.id, true, &secret)
.await
.unwrap(),
"second execute is a no-op"
);
for k in [
"ERASURE_ENABLED",
"ADMIN_KEY_INTEGRITY_SECRET",
"ERASURE_GRACE_PERIOD_HOURS",
] {
std::env::remove_var(k);
}
}