mirror of
https://github.com/Such-Software/hash-wallet.git
synced 2026-11-07 08:04:04 +01:00
jwinterm
f08ae897e6
The 1.0.5 build 15 macOS test crashed with SIGSEGV in WOWNERO_TransactionInfo_amount on the main thread, near the end of a restore sync. TransactionHistory_refresh runs on a background isolate under txHistoryMutex and frees the TransactionInfo objects it replaces; getAllSubaddresses() and getTransaction() read those objects without the mutex, so a read that overlaps a refresh dereferences freed memory. The wallet cache had not been stored, so the next launch synced again. Upstream fixed the same race for Monero in #3188 and in the v6.4.5 coin-control change; this ports both to cw_wownero. getAllSubaddresses() and getTransaction() take the mutex and become async, which carries through the subaddress list, its app proxy and the configure interface. The subaddress list now fetches before clearing, so the observable list is never empty while the fetch is pending, and addSubaddress and setLabelSubaddress await the update before callers read the new address. The coin-control change check compared a Transaction with 1 and was always false; it now uses the transaction's direction, as Monero does.