CW-596-Solana-Bug-Fixes (#1340)

* fix: Generic bug fixes across solana

* fix: Remove back and forth parsing

* fix: Add check to cut flow when estimated fee is higher than wallet balance

* Update error message for fees exception

* Remove logs

---------

Co-authored-by: Omar Hatem <omarh.ismail1@gmail.com>

cw_solana/lib/solana_wallet.dart

@@ -75,6 +75,9 @@ abstract class SolanaWalletBase
 
   late SolanaWalletClient _client;
 
+  @observable
+  double? estimatedFee;
+
   Timer? _transactionsUpdateTimer;
 
   late final Box<SPLToken> splTokensBox;
@@ -171,6 +174,14 @@ abstract class SolanaWalletBase
     }
   }
 
+  Future<void> _getEstimatedFees() async {
+    try {
+      estimatedFee = await _client.getEstimatedFee(_walletKeyPair!);
+    } catch (e) {
+      estimatedFee = 0.0;
+    }
+  }
+
   @override
   Future<PendingTransaction> createTransaction(Object credentials) async {
     final solCredentials = credentials as SolanaTransactionCredentials;
@@ -188,6 +199,8 @@ abstract class SolanaWalletBase
 
     double totalAmount = 0.0;
 
+    bool isSendAll = false;
+
     if (hasMultiDestination) {
       if (outputs.any((item) => item.sendAll || (item.formattedCryptoAmount ?? 0) <= 0)) {
         throw SolanaTransactionWrongBalanceException(transactionCurrency);
@@ -204,9 +217,15 @@ abstract class SolanaWalletBase
     } else {
       final output = outputs.first;
 
-      final totalOriginalAmount = double.parse(output.cryptoAmount ?? '0.0');
+      isSendAll = output.sendAll;
 
-      totalAmount = output.sendAll ? walletBalanceForCurrency : totalOriginalAmount;
+      if (isSendAll) {
+        totalAmount = walletBalanceForCurrency;
+      } else {
+        final totalOriginalAmount = double.parse(output.cryptoAmount ?? '0.0');
+
+        totalAmount = totalOriginalAmount;
+      }
 
       if (walletBalanceForCurrency < totalAmount) {
         throw SolanaTransactionWrongBalanceException(transactionCurrency);
@@ -228,6 +247,7 @@ abstract class SolanaWalletBase
       destinationAddress: solCredentials.outputs.first.isParsedAddress
           ? solCredentials.outputs.first.extractedAddress!
           : solCredentials.outputs.first.address,
+      isSendAll: isSendAll,
     );
 
     return pendingSolanaTransaction;
@@ -269,7 +289,10 @@ abstract class SolanaWalletBase
   Future<void> _updateSPLTokenTransactions() async {
     List<SolanaTransactionModel> splTokenTransactions = [];
 
-    for (var token in balance.keys) {
+    // Make a copy of keys to avoid concurrent modification
+    var tokenKeys = List<CryptoCurrency>.from(balance.keys);
+
+    for (var token in tokenKeys) {
       if (token is SPLToken) {
         final tokenTxs = await _client.getSPLTokenTransfers(
           token.mintAddress,
@@ -326,6 +349,7 @@ abstract class SolanaWalletBase
         _updateBalance(),
         _updateNativeSOLTransactions(),
         _updateSPLTokenTransactions(),
+        _getEstimatedFees(),
       ]);
 
       syncStatus = SyncedSyncStatus();
@@ -433,18 +457,22 @@ abstract class SolanaWalletBase
     final mintPublicKey = Ed25519HDPublicKey.fromBase58(mintAddress);
 
     // Fetch token's metadata account
-    final token = await solanaClient!.rpcClient.getMetadata(mint: mintPublicKey);
+    try {
+      final token = await solanaClient!.rpcClient.getMetadata(mint: mintPublicKey);
 
-    if (token == null) {
+      if (token == null) {
+        return null;
+      }
+
+      return SPLToken.fromMetadata(
+        name: token.name,
+        mint: token.mint,
+        symbol: token.symbol,
+        mintAddress: mintAddress,
+      );
+    } catch (e) {
       return null;
     }
-
-    return SPLToken.fromMetadata(
-      name: token.name,
-      mint: token.mint,
-      symbol: token.symbol,
-      mintAddress: mintAddress,
-    );
   }
 
   @override
@@ -475,9 +503,9 @@ abstract class SolanaWalletBase
     }
 
     _transactionsUpdateTimer = Timer.periodic(const Duration(seconds: 20), (_) {
-      _updateSPLTokenTransactions();
-      _updateNativeSOLTransactions();
       _updateBalance();
+      _updateNativeSOLTransactions();
+      _updateSPLTokenTransactions();
     });
   }