CW-520-Enable-user-to-choose-12-or-24-seed-words-for-BCH-and-ETH (#1181)

* seed phrase option UI

* bch seed length option

* eth seed lengh option

* update preseed info

* update localization files

lib/core/wallet_creation_service.dart

@@ -1,4 +1,5 @@
 import 'package:cake_wallet/di.dart';
+import 'package:cake_wallet/store/settings_store.dart';
 import 'package:cw_core/wallet_info.dart';
 import 'package:cake_wallet/entities/preferences_key.dart';
 import 'package:flutter/foundation.dart';
@@ -18,6 +19,7 @@ class WalletCreationService {
       required this.secureStorage,
       required this.keyService,
       required this.sharedPreferences,
+      required this.settingsStore,
       required this.walletInfoSource})
       : type = initialType {
     changeWalletType(type: type);
@@ -26,6 +28,7 @@ class WalletCreationService {
   WalletType type;
   final FlutterSecureStorage secureStorage;
   final SharedPreferences sharedPreferences;
+  final SettingsStore settingsStore;
   final KeyService keyService;
   final Box<WalletInfo> walletInfoSource;
   WalletService? _service;
@@ -56,6 +59,9 @@ class WalletCreationService {
     checkIfExists(credentials.name);
     final password = generateWalletPassword();
     credentials.password = password;
+    if (type == WalletType.bitcoinCash || type == WalletType.ethereum) {
+      credentials.seedPhraseLength = settingsStore.seedPhraseLength.value;
+    }
     await keyService.saveWalletPassword(password: password, walletName: credentials.name);
     final wallet = await _service!.create(credentials);
 

lib/di.dart

@@ -333,6 +333,7 @@ Future<void> setup({
           keyService: getIt.get<KeyService>(),
           secureStorage: getIt.get<FlutterSecureStorage>(),
           sharedPreferences: getIt.get<SharedPreferences>(),
+          settingsStore: getIt.get<SettingsStore>(),
           walletInfoSource: _walletInfoSource));
 
   getIt.registerFactory<WalletLoadingService>(() => WalletLoadingService(
@@ -340,9 +341,10 @@ Future<void> setup({
       getIt.get<KeyService>(),
       (WalletType type) => getIt.get<WalletService>(param1: type)));
 
-  getIt.registerFactoryParam<WalletNewVM, WalletType, void>((type, _) => WalletNewVM(
-      getIt.get<AppStore>(), getIt.get<WalletCreationService>(param1: type), _walletInfoSource,
-      type: type));
+  getIt.registerFactoryParam<WalletNewVM, WalletType, void>((type, _) =>
+      WalletNewVM(getIt.get<AppStore>(),
+          getIt.get<WalletCreationService>(param1: type), _walletInfoSource,
+          type: type));
 
   getIt.registerFactoryParam<WalletRestorationFromQRVM, WalletType, void>((WalletType type, _) {
     return WalletRestorationFromQRVM(getIt.get<AppStore>(),
@@ -894,8 +896,9 @@ Future<void> setup({
   getIt.registerFactoryParam<NewWalletTypePage, void Function(BuildContext, WalletType), bool?>(
       (param1, isCreate) => NewWalletTypePage(onTypeSelected: param1, isCreate: isCreate ?? true));
 
-  getIt.registerFactoryParam<PreSeedPage, WalletType, void>(
-      (WalletType type, _) => PreSeedPage(type));
+  getIt.registerFactoryParam<PreSeedPage, WalletType, AdvancedPrivacySettingsViewModel>(
+      (WalletType type, AdvancedPrivacySettingsViewModel advancedPrivacySettingsViewModel)
+      => PreSeedPage(type, advancedPrivacySettingsViewModel));
 
   getIt.registerFactoryParam<TradeDetailsViewModel, Trade, void>((trade, _) =>
       TradeDetailsViewModel(

lib/entities/preferences_key.dart

@@ -87,4 +87,5 @@ class PreferencesKey {
       'should_require_totp_2fa_for_all_security_and_backup_settings';
   static const selectedCake2FAPreset = 'selected_cake_2fa_preset';
   static const totpSecretKey = 'totp_secret_key';
+  static const currentSeedPhraseLength = 'current_seed_phrase_length';
 }

lib/entities/seed_phrase_length.dart

@@ -0,0 +1,26 @@
+import 'package:cake_wallet/generated/i18n.dart';
+
+enum SeedPhraseLength {
+  twelveWords(12),
+  twentyFourWords(24);
+
+  const SeedPhraseLength(this.value);
+  final int value;
+
+  static SeedPhraseLength deserialize({required int raw}) =>
+      SeedPhraseLength.values.firstWhere((e) => e.value == raw);
+
+  @override
+  String toString() {
+    String label = '';
+    switch (this) {
+      case SeedPhraseLength.twelveWords:
+        label = '12 Words';
+        break;
+      case SeedPhraseLength.twentyFourWords:
+        label = '24 Words';
+        break;
+    }
+    return label;
+  }
+}

lib/router.dart

@@ -418,7 +418,10 @@ Route<dynamic> createRoute(RouteSettings settings) {
 
     case Routes.preSeed:
       return MaterialPageRoute<void>(
-          builder: (_) => getIt.get<PreSeedPage>(param1: settings.arguments as WalletType));
+          builder: (_) => getIt.get<PreSeedPage>(
+              param1: settings.arguments as WalletType,
+              param2: getIt.get<AdvancedPrivacySettingsViewModel>(
+                  param1: settings.arguments as WalletType)));
 
     case Routes.backup:
       return CupertinoPageRoute<void>(

lib/src/screens/new_wallet/advanced_privacy_settings_page.dart

@@ -1,7 +1,9 @@
 import 'package:cake_wallet/entities/exchange_api_mode.dart';
 import 'package:cake_wallet/entities/fiat_api_mode.dart';
+import 'package:cake_wallet/entities/seed_phrase_length.dart';
 import 'package:cake_wallet/src/screens/nodes/widgets/node_form.dart';
 import 'package:cake_wallet/src/screens/settings/widgets/settings_choices_cell.dart';
+import 'package:cake_wallet/src/screens/settings/widgets/settings_picker_cell.dart';
 import 'package:cake_wallet/src/screens/settings/widgets/settings_switcher_cell.dart';
 import 'package:cake_wallet/themes/extensions/new_wallet_theme.dart';
 import 'package:cake_wallet/view_model/node_list/node_create_or_edit_view_model.dart';
@@ -94,6 +96,17 @@ class _AdvancedPrivacySettingsBodyState extends State<AdvancedPrivacySettingsBod
                 ],
               );
             }),
+            if (widget.privacySettingsViewModel.hasSeedPhraseLengthOption)
+            Observer(builder: (_) {
+              return SettingsPickerCell<SeedPhraseLength>(
+                title: S.current.seed_phrase_length,
+                items: SeedPhraseLength.values,
+                selectedItem: widget.privacySettingsViewModel.seedPhraseLength,
+                onItemSelected: (SeedPhraseLength length) {
+                  widget.privacySettingsViewModel.setSeedPhraseLength(length);
+                },
+              );
+            }),
           ],
         ),
         bottomSectionPadding: EdgeInsets.all(24),

lib/src/screens/seed/pre_seed_page.dart

@@ -1,5 +1,6 @@
 import 'package:cake_wallet/utils/responsive_layout_util.dart';
 import 'package:cake_wallet/themes/extensions/cake_text_theme.dart';
+import 'package:cake_wallet/view_model/advanced_privacy_settings_view_model.dart';
 import 'package:cw_core/wallet_type.dart';
 import 'package:cake_wallet/src/screens/base_page.dart';
 import 'package:cake_wallet/src/widgets/primary_button.dart';
@@ -9,15 +10,19 @@ import 'package:cake_wallet/themes/theme_base.dart';
 import 'package:flutter/material.dart';
 
 class PreSeedPage extends BasePage {
-  PreSeedPage(this.type)
+  PreSeedPage(this.type, this.advancedPrivacySettingsViewModel)
       : imageLight = Image.asset('assets/images/pre_seed_light.png'),
         imageDark = Image.asset('assets/images/pre_seed_dark.png'),
-        wordsCount = _wordsCount(type);
+        seedPhraseLength = advancedPrivacySettingsViewModel.seedPhraseLength.value {
+    wordsCount = _wordsCount(type, seedPhraseLength);
+  }
 
   final Image imageDark;
   final Image imageLight;
   final WalletType type;
-  final int wordsCount;
+  final AdvancedPrivacySettingsViewModel advancedPrivacySettingsViewModel;
+  final int seedPhraseLength;
+  late final int wordsCount;
 
   @override
   Widget? leading(BuildContext context) => null;
@@ -68,13 +73,13 @@ class PreSeedPage extends BasePage {
         ));
   }
 
-  static int _wordsCount(WalletType type) {
+  static int _wordsCount(WalletType type, int seedPhraseLength) {
     switch (type) {
       case WalletType.monero:
         return 25;
       case WalletType.ethereum:
       case WalletType.bitcoinCash:
-        return 12;
+        return seedPhraseLength;
       default:
         return 24;
     }

lib/store/settings_store.dart

@@ -9,6 +9,7 @@ import 'package:cake_wallet/entities/background_tasks.dart';
 import 'package:cake_wallet/entities/exchange_api_mode.dart';
 import 'package:cake_wallet/entities/pin_code_required_duration.dart';
 import 'package:cake_wallet/entities/preferences_key.dart';
+import 'package:cake_wallet/entities/seed_phrase_length.dart';
 import 'package:cake_wallet/entities/sort_balance_types.dart';
 import 'package:cake_wallet/exchange/provider/trocador_exchange_provider.dart';
 import 'package:cake_wallet/view_model/settings/sync_mode.dart';
@@ -71,6 +72,7 @@ abstract class SettingsStoreBase with Store {
       required this.isBitcoinBuyEnabled,
       required this.actionlistDisplayMode,
       required this.pinTimeOutDuration,
+      required this.seedPhraseLength,
       required Cake2FAPresetsOptions initialCake2FAPresetOptions,
       required bool initialShouldRequireTOTP2FAForAccessingWallet,
       required bool initialShouldRequireTOTP2FAForSendsToContact,
@@ -329,6 +331,11 @@ abstract class SettingsStoreBase with Store {
         (String languageCode) =>
             sharedPreferences.setString(PreferencesKey.currentLanguageCode, languageCode));
 
+    reaction(
+            (_) => seedPhraseLength,
+            (SeedPhraseLength seedPhraseWordCount) =>
+            sharedPreferences.setInt(PreferencesKey.currentSeedPhraseLength, seedPhraseWordCount.value));
+
     reaction(
         (_) => pinTimeOutDuration,
         (PinCodeRequiredDuration pinCodeInterval) =>
@@ -418,6 +425,7 @@ abstract class SettingsStoreBase with Store {
   static const defaultActionsMode = 11;
   static const defaultPinCodeTimeOutDuration = PinCodeRequiredDuration.tenminutes;
   static const defaultAutoGenerateSubaddressStatus = AutoGenerateSubaddressStatus.initialized;
+  static const defaultSeedPhraseLength = SeedPhraseLength.twelveWords;
 
   @observable
   FiatCurrency fiatCurrency;
@@ -509,6 +517,9 @@ abstract class SettingsStoreBase with Store {
   @observable
   PinCodeRequiredDuration pinTimeOutDuration;
 
+  @observable
+  SeedPhraseLength seedPhraseLength;
+
   @computed
   ThemeData get theme => currentTheme.themeData;
 
@@ -699,9 +710,13 @@ abstract class SettingsStoreBase with Store {
         sharedPreferences.getInt(PreferencesKey.displayActionListModeKey) ?? defaultActionsMode));
     var pinLength = sharedPreferences.getInt(PreferencesKey.currentPinLength);
     final timeOutDuration = sharedPreferences.getInt(PreferencesKey.pinTimeOutDuration);
+    final seedPhraseCount = sharedPreferences.getInt(PreferencesKey.currentSeedPhraseLength);
     final pinCodeTimeOutDuration = timeOutDuration != null
         ? PinCodeRequiredDuration.deserialize(raw: timeOutDuration)
         : defaultPinCodeTimeOutDuration;
+    final seedPhraseWordCount = seedPhraseCount != null
+        ? SeedPhraseLength.deserialize(raw: seedPhraseCount)
+        : defaultSeedPhraseLength;
     final sortBalanceBy =
     SortBalanceBy.values[sharedPreferences.getInt(PreferencesKey.sortBalanceBy) ?? 0];
     final pinNativeTokenAtTop =
@@ -816,6 +831,7 @@ abstract class SettingsStoreBase with Store {
           actionlistDisplayMode: actionListDisplayMode,
           initialPinLength: pinLength,
           pinTimeOutDuration: pinCodeTimeOutDuration,
+          seedPhraseLength: seedPhraseWordCount,
           initialLanguageCode: savedLanguageCode,
           sortBalanceBy: sortBalanceBy,
           pinNativeTokenAtTop: pinNativeTokenAtTop,

lib/view_model/advanced_privacy_settings_view_model.dart

@@ -1,5 +1,6 @@
 import 'package:cake_wallet/entities/exchange_api_mode.dart';
 import 'package:cake_wallet/entities/fiat_api_mode.dart';
+import 'package:cake_wallet/entities/seed_phrase_length.dart';
 import 'package:cake_wallet/store/settings_store.dart';
 import 'package:cw_core/wallet_type.dart';
 import 'package:mobx/mobx.dart';
@@ -25,9 +26,15 @@ abstract class AdvancedPrivacySettingsViewModelBase with Store {
 
   final SettingsStore _settingsStore;
 
+  bool get hasSeedPhraseLengthOption =>
+      type == WalletType.bitcoinCash || type == WalletType.ethereum;
+
   @computed
   bool get addCustomNode => _addCustomNode;
 
+  @computed
+  SeedPhraseLength get seedPhraseLength => _settingsStore.seedPhraseLength;
+
   @action
   void setFiatApiMode(FiatApiMode fiatApiMode) => _settingsStore.fiatApiMode = fiatApiMode;
 
@@ -36,4 +43,7 @@ abstract class AdvancedPrivacySettingsViewModelBase with Store {
 
   @action
   void toggleAddCustomNode() => _addCustomNode = !_addCustomNode;
+
+  @action
+  void setSeedPhraseLength(SeedPhraseLength length) => _settingsStore.seedPhraseLength = length;
 }