github-such-software/hash-wallet
1
0
Fork 1
mirror of https://github.com/Such-Software/hash-wallet.git synced 2026-10-17 05:41:29 +02:00
Code Issues Packages Projects Releases Wiki Activity

Cw 1118 silent payment fixes (#2373)

Browse Source 
* fix: hive box error

* fix: address validator

* fix: guarantee save on sp scanned

* fix: too many saves

* feat: network based address validation

* fix: sp testnet

* feat: ltc validator

* fix: use general sp regex on address getter and remove print
This commit is contained in:
rafael_xmr
2025-07-12 00:19:35 +03:00
committed by GitHub
parent 4009f64ee9
commit 8207eed466
6 changed files with 71 additions and 48 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/core/address_validator_test.dart
+22 -27
View File
@@ -24,17 +24,14 @@ void main() {
test('returns correct pattern for Monero', () {
final pattern = AddressValidator.getPattern(CryptoCurrency.xmr);
expect(pattern, isNotEmpty);
expect(pattern,
contains('4[0-9a-zA-Z]{94}|8[0-9a-zA-Z]{94}|[0-9a-zA-Z]{106}'));
expect(pattern, contains('4[0-9a-zA-Z]{94}|8[0-9a-zA-Z]{94}|[0-9a-zA-Z]{106}'));
});
test('returns correct pattern for Litecoin', () {
final pattern = AddressValidator.getPattern(CryptoCurrency.ltc);
expect(pattern, isNotEmpty);
expect(
pattern,
contains(
'(bc|tb|ltc)1q[ac-hj-np-z02-9]{25,39}|(ltc|t)mweb1q[ac-hj-np-z02-9]{90,120}'));
expect(pattern,
contains('(bc|tb|ltc)1q[ac-hj-np-z02-9]{25,39}|(ltc|t)mweb1q[ac-hj-np-z02-9]{90,120}'));
});
test('returns empty string for unknown currency', () {
@@ -67,29 +64,25 @@ void main() {
group('getAddressFromStringPattern', () {
test('returns correct pattern for Bitcoin', () {
final pattern =
AddressValidator.getAddressFromStringPattern(CryptoCurrency.btc);
final pattern = AddressValidator.getAddressFromStringPattern(CryptoCurrency.btc);
expect(pattern, isNotNull);
expect(pattern, contains('(bc|tb)1q'));
});
test('returns correct pattern for Ethereum', () {
final pattern =
AddressValidator.getAddressFromStringPattern(CryptoCurrency.eth);
final pattern = AddressValidator.getAddressFromStringPattern(CryptoCurrency.eth);
expect(pattern, isNotNull);
expect(pattern, contains('0x[0-9a-zA-Z]+'));
});
test('returns correct pattern for Monero', () {
final pattern =
AddressValidator.getAddressFromStringPattern(CryptoCurrency.xmr);
final pattern = AddressValidator.getAddressFromStringPattern(CryptoCurrency.xmr);
expect(pattern, isNotNull);
expect(pattern, contains('(4[0-9a-zA-Z]{94})'));
});
test('returns null for unsupported currency', () {
final pattern =
AddressValidator.getAddressFromStringPattern(CryptoCurrency.dash);
final pattern = AddressValidator.getAddressFromStringPattern(CryptoCurrency.dash);
expect(pattern, isNull);
});
});
@@ -97,8 +90,7 @@ void main() {
group('validation', () {
test('validates valid Bitcoin address', () {
final validator = AddressValidator(type: CryptoCurrency.btc);
expect(validator.isValid('bc1qhg4l43pmq5v5atmtlr7gnwyuxs043cvrut5hkq'),
isTrue);
expect(validator.isValid('bc1qhg4l43pmq5v5atmtlr7gnwyuxs043cvrut5hkq'), isTrue);
expect(validator.isValid('3AD1Btx1MzYGmdpNpeujCfuvU5SsU2LX88'), isTrue);
expect(validator.isValid('1HARAhFcvz8ZQp5MhnLFeUynC4bkha3Hv8'), isTrue);
});
@@ -106,8 +98,7 @@ void main() {
test('rejects invalid Bitcoin address', () {
final validator = AddressValidator(type: CryptoCurrency.btc);
expect(validator.isValid('invalid_address'), isFalse);
expect(validator.isValid('bc1qhg4l43pmq5v5atmtlr7gnwyuxs043CakeWallet'),
isFalse);
expect(validator.isValid('bc1qhg4l43pmq5v5atmtlr7gnwyuxs043CakeWallet'), isFalse);
});
test('validates valid Ethereum address', () {
@@ -119,8 +110,8 @@ void main() {
test('rejects invalid Ethereum address', () {
final validator = AddressValidator(type: CryptoCurrency.eth);
expect(validator.isValid('invalid_address'), isFalse);
expect(validator.isValid('0xC02aaA39b223FE8D0A0e5C4F27eAD9083C756Cc'),
isFalse); // Too short
expect(
validator.isValid('0xC02aaA39b223FE8D0A0e5C4F27eAD9083C756Cc'), isFalse); // Too short
expect(validator.isValid('C02aaA39b223FE8D0A0e5C4F27eAD9083C756Cc2'),
isFalse); // Missing 0x prefix
});
@@ -144,8 +135,7 @@ void main() {
test('validates valid Litecoin address', () {
final validator = AddressValidator(type: CryptoCurrency.ltc);
expect(validator.isValid('ltc1qzvxlvlk8wsmue0np20eh3d3qxsusx9jstf8qw8'),
isTrue);
expect(validator.isValid('ltc1qzvxlvlk8wsmue0np20eh3d3qxsusx9jstf8qw8'), isTrue);
expect(
validator.isValid(
'ltcmweb1qqt9hqch2d0vfdsvt4tf27gullem2tcd57xxrvta9xwvfmwdkn4927q6d8sq6ftw7lkqdkr5g36eqn7w06edgq8tz7gy0nv5d4lhajctkzuath23a'),
@@ -155,15 +145,20 @@ void main() {
test('rejects invalid Litecoin address', () {
final validator = AddressValidator(type: CryptoCurrency.ltc);
expect(validator.isValid('invalid_address'), isFalse);
expect(
validator.isValid('ltc1qzvxlvlk8wsmue0np20eh3d3qxsusxCakeWallet'),
isFalse);
expect(validator.isValid('ltc1qzvxlvlk8wsmue0np20eh3d3qxsusxCakeWallet'), isFalse);
});
});
group('silentPaymentAddressPattern', () {
group('silentPaymentAddressPatternMainnet', () {
test('returns a non-empty pattern', () {
final pattern = AddressValidator.silentPaymentAddressPattern;
final pattern = AddressValidator.silentPaymentAddressPatternMainnet;
expect(pattern, isNotEmpty);
});
});
group('silentPaymentAddressPatternTestnet', () {
test('returns a non-empty pattern', () {
final pattern = AddressValidator.silentPaymentAddressPatternTestnet;
expect(pattern, isNotEmpty);
});
});