From 6bd8f64ed78310da35e3080ab269e0bd19ba76ec Mon Sep 17 00:00:00 2001 From: jwinterm Date: Mon, 26 Oct 2026 23:41:33 -0400 Subject: [PATCH] ci(macos): honour app_store_upload=false on a Gitea dispatch Gitea passes a dispatch boolean as a real false, so `inputs.app_store_upload || 'true'` read it as true and a rebuild would have re-uploaded a build number App Store Connect already holds. format() keeps it as the string 'false'; a tag push still uploads. --- .github/workflows/build-macos.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/build-macos.yml b/.github/workflows/build-macos.yml index a0556c08a..fda25d95b 100644 --- a/.github/workflows/build-macos.yml +++ b/.github/workflows/build-macos.yml @@ -67,7 +67,9 @@ jobs: APP_MACOS_TYPE: cakewallet # A tag push builds both lanes and uploads; a dispatch says what it wants. LANES: ${{ github.event.inputs.lanes || 'both' }} - APP_STORE_UPLOAD: ${{ github.event.inputs.app_store_upload || 'true' }} + # Gitea hands a dispatch boolean over as a real false, which `|| 'true'` + # would turn back into true; format() keeps it as the string 'false'. + APP_STORE_UPLOAD: ${{ github.event_name == 'workflow_dispatch' && format('{0}', github.event.inputs.app_store_upload) || 'true' }} KEYCHAIN: ${{ github.workspace }}/../hashbags-macos.keychain-db LANG: en_US.UTF-8 LC_ALL: en_US.UTF-8