mirror of
https://github.com/Such-Software/hash-wallet.git
synced 2026-10-17 05:41:29 +02:00
Rbf fixes issues op return data plus ThorChain (#1648)
* total out amount issue * fix empty inputs and outputs addresses for new tx * fix sum value of utxo not spending * Update configure.dart * Update electrum_wallet.dart * receiving address * review fixes * add op_return data * fix rbf transaction with a memo * add memo check for ThorChain trade * code enhancement [skip ci] * code enhancement [skip ci] * directly use fromElectrumBundle function to update transaction info --------- Co-authored-by: Omar Hatem <omarh.ismail1@gmail.com>
This commit is contained in:
@@ -845,6 +845,13 @@ abstract class ExchangeViewModelBase extends WalletChangeListenerViewModel with
|
||||
);
|
||||
}
|
||||
|
||||
if ((trade.memo == null || trade.memo!.isEmpty)) {
|
||||
return CreateTradeResult(
|
||||
result: false,
|
||||
errorMessage: 'Memo is required for Thorchain trade',
|
||||
);
|
||||
}
|
||||
|
||||
final currenciesToCheckPattern = RegExp('0x[0-9a-zA-Z]');
|
||||
|
||||
// Perform checks for payOutAddress
|
||||
|
||||
@@ -392,8 +392,15 @@ abstract class TransactionDetailsViewModelBase with Store {
|
||||
}
|
||||
|
||||
if (transactionInfo.outputAddresses != null && transactionInfo.outputAddresses!.isNotEmpty) {
|
||||
RBFListItems.add(StandardExpandableListItem(
|
||||
title: S.current.outputs, expandableItems: transactionInfo.outputAddresses!));
|
||||
final outputAddresses = transactionInfo.outputAddresses!.map((element) {
|
||||
if (element.contains('OP_RETURN:') && element.length > 40) {
|
||||
return element.substring(0, 40) + '...';
|
||||
}
|
||||
return element;
|
||||
}).toList();
|
||||
|
||||
RBFListItems.add(
|
||||
StandardExpandableListItem(title: S.current.outputs, expandableItems: outputAddresses));
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user