CAKE-222 | applied adaptive picker to send and settings pages

lib/src/screens/send/send_page.dart

@@ -751,7 +751,6 @@ class SendPage extends BasePage {
               mainAxisAlignment: MainAxisAlignment.center,
               onItemSelected: (TransactionPriority priority) =>
                   sendViewModel.setTransactionPriority(priority),
-              isAlwaysShowScrollThumb: isShowScrollThumb,
             ),
         context: context);
   }

lib/src/screens/settings/settings.dart

@@ -43,7 +43,6 @@ class SettingsPage extends BasePage {
               return SettingsPickerCell<dynamic>(
                 title: item.title,
                 selectedItem: item.selectedItem(),
-                isAlwaysShowScrollThumb: item.isAlwaysShowScrollThumb,
                 items: item.items,
                 onItemSelected: (dynamic value) => item.onItemSelected(value),
               );

lib/src/screens/settings/widgets/settings_picker_cell.dart

@@ -9,8 +9,7 @@ class SettingsPickerCell<ItemType> extends StandardListRow {
       {@required String title,
       this.selectedItem,
       this.items,
-      this.onItemSelected,
-      this.isAlwaysShowScrollThumb})
+      this.onItemSelected})
       : super(
             title: title,
             isSelected: false,
@@ -24,7 +23,6 @@ class SettingsPickerCell<ItemType> extends StandardListRow {
                       selectedAtIndex: selectedAtIndex,
                       title: S.current.please_select,
                       mainAxisAlignment: MainAxisAlignment.center,
-                      isAlwaysShowScrollThumb: isAlwaysShowScrollThumb,
                       onItemSelected: (ItemType item) =>
                           onItemSelected?.call(item)));
             });
@@ -32,7 +30,6 @@ class SettingsPickerCell<ItemType> extends StandardListRow {
   final ItemType selectedItem;
   final List<ItemType> items;
   final void Function(ItemType item) onItemSelected;
-  final bool isAlwaysShowScrollThumb;
 
   @override
   Widget buildTrailing(BuildContext context) {

lib/src/widgets/picker.dart

@@ -15,7 +15,6 @@ class Picker<Item extends Object> extends StatefulWidget {
     this.description,
     @required this.onItemSelected,
     this.mainAxisAlignment = MainAxisAlignment.start,
-    this.isAlwaysShowScrollThumb = false
   });
 
   final int selectedAtIndex;
@@ -25,7 +24,6 @@ class Picker<Item extends Object> extends StatefulWidget {
   final String description;
   final Function(Item) onItemSelected;
   final MainAxisAlignment mainAxisAlignment;
-  final bool isAlwaysShowScrollThumb;
 
   @override
   PickerState createState() => PickerState<Item>(items, images, onItemSelected);
@@ -56,6 +54,8 @@ class PickerState<Item> extends State<Picker> {
       setState(() {});
     });
 
+    final isShowScrollThumb = items != null ? items.length > 3 : false;
+
     return AlertBackground(
         child: Stack(
           alignment: Alignment.center,
@@ -168,13 +168,13 @@ class PickerState<Item> extends State<Picker> {
                                 )
                               )
                               : Offstage(),
-                              widget.isAlwaysShowScrollThumb
-                                  ? CakeScrollbar(
+                              isShowScrollThumb
+                              ? CakeScrollbar(
                                   backgroundHeight: backgroundHeight,
                                   thumbHeight: thumbHeight,
                                   fromTop: fromTop
                               )
-                                  : Offstage(),
+                              : Offstage(),
                             ],
                           )
                       ),