Cw 1539 lightning enhancements (#3400)

* feat: add Lightning transaction URL support in transaction details view model

* fix: update currency selection logic in WalletAddressListViewModel and ReceivePage

* feat: integrate computed transaction amount and fee getters in TransactionDetailsViewModel, refactor CopyWrapper logic in TransactionDetailsModal

* refactor: apply lint rules

* refactor: apply lint rules and improve LNURL handling with new methods for withdrawal requests and error checks

* auto-reformat

* fix: receive_page regression

* fix: Withdraw lightning to other btc wallet gives LN address

* chore: update .lock files [skip ci]

---------

Co-authored-by: Robert Malikowski <malikowskirobert@gmail.com>
Co-authored-by: Omar Hatem <omarh.ismail1@gmail.com>
This commit is contained in:
Konstantin Ullrich
2026-07-17 17:49:17 +03:00
committed by GitHub
co-authored by Robert Malikowski Omar Hatem
parent 28c2cc152e
commit 03edd658a5
18 changed files with 1193 additions and 1003 deletions
+140 -37
View File
@@ -1,19 +1,20 @@
import 'dart:convert';
import "dart:convert";
import 'package:bech32/bech32.dart';
import 'package:cw_core/amount/money.dart';
import 'package:cw_core/crypto_currency.dart';
import 'package:cw_core/utils/proxy_wrapper.dart';
import "package:bech32/bech32.dart";
import "package:cw_core/amount/money.dart";
import "package:cw_core/crypto_currency.dart";
import "package:cw_core/utils/proxy_wrapper.dart";
const _BOLT_PREFIXES = ["lnbcrt", "lntbs", "lnbc", "lntb"];
const _LUD17_PREFIXES = ['lnurlw', 'lnurlc', 'lnurlp', 'keyauth'];
const _LUD17_PREFIXES = ["lnurlw", "lnurlc", "lnurlp", "keyauth"];
bool isBolt11ZeroInvoice(String invoice) {
try {
final request = Bech32Codec().decode(invoice.replaceFirst("lightning:", ""), invoice.length);
final request =
const Bech32Codec().decode(invoice.replaceFirst("lightning:", ""), invoice.length);
final prefix =
_BOLT_PREFIXES.firstWhere((prefix) => request.hrp.startsWith(prefix), orElse: () => "");
_BOLT_PREFIXES.firstWhere(request.hrp.startsWith, orElse: () => "");
return request.hrp.length == prefix.length;
} catch (e) {
@@ -23,48 +24,56 @@ bool isBolt11ZeroInvoice(String invoice) {
/// Get the amount of a Bolt 11 Invoice in
int? _getAmountBolt11Msat(String invoice) {
final request = Bech32Codec().decode(invoice.replaceFirst("lightning:", ""), invoice.length);
final request =
const Bech32Codec().decode(invoice.replaceFirst("lightning:", ""), invoice.length);
final prefix = _BOLT_PREFIXES.firstWhere(
(prefix) => request.hrp.startsWith(prefix),
orElse: () => throw FormatException('Invalid BOLT11 invoice: unknown HRP prefix.'),
request.hrp.startsWith,
orElse: () => throw const FormatException("Invalid BOLT11 invoice: unknown HRP prefix."),
);
final amountPart = request.hrp.substring(prefix.length);
if (amountPart.isEmpty) return null; // zero-amount invoice
if (amountPart.isEmpty) {
return null; // zero-amount invoice
}
final hasMultiplier = RegExp(r'[munp]$').hasMatch(amountPart);
final multiplier = hasMultiplier ? amountPart[amountPart.length - 1] : '';
final hasMultiplier = RegExp(r"[munp]$").hasMatch(amountPart);
final multiplier = hasMultiplier ? amountPart[amountPart.length - 1] : "";
final numberStr = hasMultiplier ? amountPart.substring(0, amountPart.length - 1) : amountPart;
if (numberStr.isEmpty || !RegExp(r'^\d+$').hasMatch(numberStr)) {
throw FormatException('Invalid BOLT11 invoice: invalid amount number in HRP.');
if (numberStr.isEmpty || !RegExp(r"^\d+$").hasMatch(numberStr)) {
throw const FormatException("Invalid BOLT11 invoice: invalid amount number in HRP.");
}
final amount = int.parse(numberStr);
switch (multiplier) {
case '': // bitcoin
case "": // bitcoin
return amount * 100000000000;
case 'm': // milli-bitcoin
case "m": // milli-bitcoin
return amount * 100000000;
case 'u': // micro-bitcoin
case "u": // micro-bitcoin
return amount * 100000;
case 'n': // nano-bitcoin
case "n": // nano-bitcoin
return amount * 100;
case 'p':
case "p":
if (amount % 10 != 0) {
throw FormatException('Invalid BOLT11 invoice: amount not representable in whole msat.');
throw const FormatException(
"Invalid BOLT11 invoice: amount not representable in whole msat.",
);
}
return amount ~/ 10;
default:
throw FormatException('Invalid BOLT11 invoice: unknown amount multiplier.');
throw const FormatException("Invalid BOLT11 invoice: unknown amount multiplier.");
}
}
Money? getBolt11Amount(String invoice) {
final msat = _getAmountBolt11Msat(invoice);
if (msat == null || msat % 1000 != 0) return null;
if (msat == null || msat % 1000 != 0) {
return null;
}
return Money.fromInt(msat ~/ 1000, CryptoCurrency.btcln);
}
@@ -73,30 +82,99 @@ class LNURL {
final url = decode(lnurl);
final response = await ProxyWrapper().get(clearnetUri: url);
if (response.statusCode != 200) return null;
if (response.statusCode != 200) {
return null;
}
try {
final body = jsonDecode(response.body) as Map;
final tag = body["tag"] as String?;
if (tag != "payRequest") return null;
if (tag != "payRequest") {
return null;
}
final msat = body["minSendable"] as int?;
final maxSendable = body["maxSendable"] as int?;
// if minSendable and maxSendable are the same we assume a specific payment request
if (msat != maxSendable) return null;
if (msat != maxSendable) {
return null;
}
if (msat == null || msat % 1000 != 0) return null;
if (msat == null || msat % 1000 != 0) {
return null;
}
return Money.fromInt(msat ~/ 1000, CryptoCurrency.btcln);
} catch (_) {
return null;
}
}
static Future<LNURLWithdrawRequest?> getWithdrawRequest(String lnurl) async {
final url = decode(lnurl);
final response = await ProxyWrapper().get(clearnetUri: url);
if (response.statusCode != 200) {
return null;
}
try {
final body = jsonDecode(response.body) as Map;
final tag = body["tag"] as String?;
if (tag != "withdrawRequest") {
return null;
}
final minWithdrawable = body["minWithdrawable"] as int?;
final maxWithdrawable = body["maxWithdrawable"] as int?;
if ((minWithdrawable == null || minWithdrawable % 1000 != 0) ||
(maxWithdrawable == null || maxWithdrawable % 1000 != 0)) {
return null;
}
return LNURLWithdrawRequest(
callback: body["callback"] as String,
k1: body["k1"] as String,
description: body["defaultDescription"] as String,
minAmount: Money.fromInt(minWithdrawable ~/ 1000, CryptoCurrency.btcln),
maxAmount: Money.fromInt(maxWithdrawable ~/ 1000, CryptoCurrency.btcln),
);
} catch (_) {
return null;
}
}
Future<bool> commitWithdrawRequest(LNURLWithdrawRequest request, String invoice) async {
try {
final url = Uri.parse(request.callback);
url.queryParameters["k1"] = request.k1;
url.queryParameters["pr"] = invoice;
final response = await ProxyWrapper().get(clearnetUri: url);
if (response.statusCode != 200) {
return false;
}
final body = jsonDecode(response.body) as Map;
final status = body["status"] as String?;
if (status == "OK") {
return true;
}
return false;
} catch (_) {
return false;
}
}
static String encode(String url) {
final raw = _convert(utf8.encode(url), 8, 5, true);
return const Bech32Codec().encode(Bech32('lnurl', raw), 999);
return const Bech32Codec().encode(Bech32("lnurl", raw), 999);
}
static Uri decode(String encodedUrl) {
@@ -114,9 +192,10 @@ class LNURL {
if (_LUD17_PREFIXES.contains(decodedUri.scheme)) {
/// If the non-bech32 LNURL is a Tor address, the port has to be http instead of https for the clearnet LNURL so check if the host ends with '.onion' or '.onion.'
decodedUri = decodedUri.replace(
scheme: decodedUri.host.endsWith('onion') || decodedUri.host.endsWith('onion.')
? 'http'
: 'https');
scheme: decodedUri.host.endsWith("onion") || decodedUri.host.endsWith("onion.")
? "http"
: "https",
);
} else {
/// Try to parse the input as a lnUrl. Will throw an error if it fails.
final lnUrl = _findLnUrl(encodedUrl);
@@ -129,12 +208,30 @@ class LNURL {
}
}
class LNURLWithdrawRequest {
const LNURLWithdrawRequest({
required this.callback,
required this.k1,
required this.description,
required this.minAmount,
required this.maxAmount,
});
final String callback;
final String k1;
final String description;
final Money minAmount;
final Money maxAmount;
}
/// Parse and return a given lnurl string if it's valid. Will remove
/// `lightning:` from the beginning of it if present.
String _findLnUrl(String input) {
final res = RegExp(r',*?((lnurl)([0-9]+[a-z0-9]+))').allMatches(input.toLowerCase());
final res = RegExp(r",*?((lnurl)([0-9]+[a-z0-9]+))").allMatches(input.toLowerCase());
if (res.length != 1) throw ArgumentError('Not a valid lnurl string');
if (res.length != 1) {
throw ArgumentError("Not a valid lnurl string");
}
return res.first.group(0)!;
}
@@ -156,10 +253,16 @@ List<int> _convert(List<int> data, int inBits, int outBits, bool pad) {
}
if (pad) {
if (bits > 0) result.add((value << (outBits - bits)) & maxV);
if (bits > 0) {
result.add((value << (outBits - bits)) & maxV);
}
} else {
if (bits >= inBits) throw Exception('[BECH32] Excess padding');
if ((value << (outBits - bits)) & maxV > 0) throw Exception('[BECH32] Non-zero padding');
if (bits >= inBits) {
throw Exception("[BECH32] Excess padding");
}
if ((value << (outBits - bits)) & maxV > 0) {
throw Exception("[BECH32] Non-zero padding");
}
}
return result;
+5 -5
View File
@@ -394,10 +394,10 @@ packages:
dependency: transitive
description:
name: meta
sha256: "1741988757a65eb6b36abe716829688cf01910bbf91c34354ff7ec1c3de2b349"
sha256: "23f08335362185a5ea2ad3a4e597f1375e78bce8a040df5c600c8d3552ef2394"
url: "https://pub.dev"
source: hosted
version: "1.18.0"
version: "1.17.0"
mime:
dependency: transitive
description:
@@ -738,10 +738,10 @@ packages:
dependency: transitive
description:
name: test_api
sha256: "949a932224383300f01be9221c39180316445ecb8e7547f70a41a35bf421fb9e"
sha256: "8161c84903fd860b26bfdefb7963b3f0b68fee7adea0f59ef805ecca346f0c7a"
url: "https://pub.dev"
source: hosted
version: "0.7.11"
version: "0.7.10"
torch_dart:
dependency: "direct main"
description:
@@ -838,5 +838,5 @@ packages:
source: hosted
version: "3.1.3"
sdks:
dart: ">=3.10.0-0 <4.0.0"
dart: ">=3.9.0 <4.0.0"
flutter: ">=3.27.0"