From dcfbfd4db5fec4a78728f3fa408ab44d65eb5984 Mon Sep 17 00:00:00 2001
From: Antoine Nguyen <tonio@ngyn.org>
Date: Wed, 27 Aug 2025 11:55:50 +0200
Subject: [PATCH] Removed All option from tables using server-side pagination.

---
 .../src/components/admin/alarms/AlarmList.vue |   9 +-
 .../components/admin/domains/DomainList.vue   | 224 ++++++++----------
 .../admin/identities/IdentityList.vue         |   8 +
 .../components/admin/logs/AuditTrailList.vue  |   7 +
 .../src/components/admin/logs/MessageList.vue |   7 +
 .../src/views/admin/domains/DomainsView.vue   |   2 +-
 6 files changed, 131 insertions(+), 126 deletions(-)

diff --git a/frontend/src/components/admin/alarms/AlarmList.vue b/frontend/src/components/admin/alarms/AlarmList.vue
index 86a78e101..c3114072a 100644
--- a/frontend/src/components/admin/alarms/AlarmList.vue
+++ b/frontend/src/components/admin/alarms/AlarmList.vue
@@ -7,6 +7,7 @@
       :search="search"
       item-value="id"
       :items-length="totalAlarms"
+      :items-per-page-options="itemsPerPageOptions"
       :loading="loading"
       elevation="0"
       show-select
@@ -101,6 +102,12 @@ const headers = [
     align: 'right',
   },
 ]
+const itemsPerPageOptions = [
+  { value: 10, title: '10' },
+  { value: 25, title: '25' },
+  { value: 50, title: '50' },
+  { value: 100, title: '100' },
+]
 
 function getActionMenuItems() {
   const result = []
@@ -176,7 +183,7 @@ async function deleteAlarm(alarm, single = true) {
   })
 }
 async function deleteAlarms() {
-  await alarmsApi.bulkDelete(selected.value.map((alarm) => alarm.id))
+  await alarmsApi.bulkDelete(selected.value)
   busStore.displayNotification({ msg: $gettext('Alarms deleted') })
   selected.value = []
   fetchAlarms({})
diff --git a/frontend/src/components/admin/domains/DomainList.vue b/frontend/src/components/admin/domains/DomainList.vue
index e3ca76f72..077c2ccf5 100644
--- a/frontend/src/components/admin/domains/DomainList.vue
+++ b/frontend/src/components/admin/domains/DomainList.vue
@@ -5,7 +5,7 @@
       :expanded="expanded"
       :headers="domainHeaders"
       :items="domains"
-      item-value="name"
+      item-value="pk"
       :search="search"
       show-select
       expand-on-click
@@ -44,121 +44,103 @@
           ></v-btn>
         </v-toolbar>
       </template>
+      <template #[`item.name`]="{ item }">
+        <router-link
+          :to="{
+            name: 'DomainDetail',
+            params: { id: item.pk },
+          }"
+        >
+          {{ item.name }}
+        </router-link>
+        <v-chip
+          v-if="item.type === 'relaydomain'"
+          size="small"
+          color="primary"
+          class="ml-2"
+        >
+          {{ $gettext('Relay') }}
+        </v-chip>
+      </template>
+
+      <template #[`item.enabled`]="{ item }">
+        <BooleanIcon :value="item.enabled" />
+      </template>
+
       <template
-        #item="{
+        #[`item.data-table-expand`]="{
           item,
           internalItem,
           isExpanded,
           toggleExpand,
-          isSelected,
-          toggleSelect,
         }"
       >
-        <tr>
-          <td
-            class="v-data-table__td v-data-table-column--no-padding v-data-table-column--align-start"
-          >
-            <v-checkbox-btn
-              :value="!isSelected(internalItem)"
-              @click="toggleSelect(internalItem)"
-            />
-          </td>
-          <td>
-            <router-link
-              :to="{
-                name: 'DomainDetail',
-                params: { id: item.pk },
-              }"
-            >
-              {{ item.name }}
-            </router-link>
-            <v-chip
-              v-if="item.type === 'relaydomain'"
-              size="small"
-              color="primary"
-              class="ml-2"
-            >
-              {{ $gettext('Relay') }}
-            </v-chip>
-          </td>
-          <td>
-            <v-icon
-              :color="item.enabled ? 'success' : 'error'"
-              :icon="item.enabled ? 'mdi-check-circle' : 'mdi-close-circle'"
-              variant="flat"
-            />
-          </td>
-          <td>
-            {{ item.domainalias_count }} aliases
-            <v-btn
-              v-if="item.domainalias_count"
-              variant="text"
-              :icon="
-                isExpanded(internalItem) ? 'mdi-chevron-up' : 'mdi-chevron-down'
-              "
-              @click="loadAliases(item, internalItem, isExpanded, toggleExpand)"
-            >
-            </v-btn>
-          </td>
-          <td>
-            <DNSStatusChip :status="item.dns_global_status" />
-          </td>
-          <td>
-            <v-progress-linear
-              v-if="item.message_limit"
-              :color="
-                item.sent_messages_in_percent < 80 ? 'primary' : 'warning'
-              "
-              :model-value="item.sent_messages_in_percent"
-            />
-            <span v-else>
-              {{ $gettext('Unlimited') }}
-            </span>
-          </td>
-          <td>
-            <v-progress-linear
-              v-if="item.quota !== '0'"
-              :color="
-                item.allocated_quota_in_percent < 80 ? 'primary' : 'warning'
-              "
-              :model-value="item.allocated_quota_in_percent"
-            />
-            <span v-else>
-              {{ $gettext('Unlimited') }}
-            </span>
-          </td>
-          <td v-if="canSetRole">
-            <div class="text-right">
-              <v-menu offset-y>
-                <template #activator="{ props }">
-                  <v-badge
-                    v-if="item.opened_alarms_count"
-                    bordered
-                    color="error"
-                    icon="mdi-bell"
-                    overlap
-                  >
-                    <v-btn
-                      icon="mdi-dots-horizontal"
-                      variant="text"
-                      v-bind="props"
-                    >
-                    </v-btn>
-                  </v-badge>
-                  <v-btn
-                    v-else
-                    icon="mdi-dots-horizontal"
-                    variant="text"
-                    v-bind="props"
-                  >
-                  </v-btn>
-                </template>
-                <MenuItems :items="getDomainMenuItems(item)" :obj="item" />
-              </v-menu>
-            </div>
-          </td>
-        </tr>
+        {{ item.domainalias_count }} aliases
+        <v-btn
+          v-if="item.domainalias_count"
+          variant="text"
+          size="small"
+          :icon="
+            isExpanded(internalItem) ? 'mdi-chevron-up' : 'mdi-chevron-down'
+          "
+          @click="loadAliases(item, internalItem, isExpanded, toggleExpand)"
+        >
+        </v-btn>
       </template>
+
+      <template #[`item.dns_global_status`]="{ item }">
+        <DNSStatusChip :status="item.dns_global_status" />
+      </template>
+
+      <template #[`item.message_limit`]="{ item }">
+        <v-progress-linear
+          v-if="item.message_limit"
+          :color="item.sent_messages_in_percent < 80 ? 'primary' : 'warning'"
+          :model-value="item.sent_messages_in_percent"
+        />
+        <span v-else>
+          {{ $gettext('Unlimited') }}
+        </span>
+      </template>
+
+      <template #[`item.allocated_quota_in_percent`]="{ item }">
+        <v-progress-linear
+          v-if="item.quota !== '0'"
+          :color="item.allocated_quota_in_percent < 80 ? 'primary' : 'warning'"
+          :model-value="item.allocated_quota_in_percent"
+        />
+        <span v-else>
+          {{ $gettext('Unlimited') }}
+        </span>
+      </template>
+
+      <template #[`item.actions`]="{ item }">
+        <div class="text-right">
+          <v-menu offset-y>
+            <template #activator="{ props }">
+              <v-badge
+                v-if="item.opened_alarms_count"
+                bordered
+                color="error"
+                icon="mdi-bell"
+                overlap
+              >
+                <v-btn icon="mdi-dots-horizontal" variant="text" v-bind="props">
+                </v-btn>
+              </v-badge>
+              <v-btn
+                v-else
+                icon="mdi-dots-horizontal"
+                variant="text"
+                v-bind="props"
+              >
+              </v-btn>
+            </template>
+            <MenuItems :items="getDomainMenuItems(item)" :obj="item" />
+          </v-menu>
+        </div>
+      </template>
+
       <template #expanded-row="{ item, columns }">
         <tr class="grey lighten-4">
           <td :colspan="columns.length">
@@ -167,12 +149,9 @@
               :key="alias.name"
               class="mr-4"
             >
-              <a href="#" class="mr-2" @click="editDomainAlias(item, alias)">{{
-                alias.name
-              }}</a>
-              <v-chip variant="flat" size="x-small" color="success"
-                >DNS OK</v-chip
-              >
+              <v-chip class="mr-2" @click="editDomainAlias(item, alias)">
+                {{ alias.name }}
+              </v-chip>
             </span>
           </td>
         </tr>
@@ -206,6 +185,7 @@ import { useBusStore } from '@/stores'
 import { useGettext } from 'vue3-gettext'
 import { useRouter } from 'vue-router'
 import { usePermissions } from '@/composables/permissions'
+import BooleanIcon from '@/components/tools/BooleanIcon.vue'
 import DomainAdminList from './DomainAdminList.vue'
 import ConfirmDialog from '@/components/tools/ConfirmDialog.vue'
 import DNSStatusChip from './DNSStatusChip.vue'
@@ -224,7 +204,7 @@ const busStore = useBusStore()
 const domainHeaders = [
   { title: $gettext('Name'), key: 'name' },
   { title: $gettext('Enabled'), key: 'enabled', width: '5%' },
-  { title: $gettext('Aliases'), key: 'domainalias_count' },
+  { title: $gettext('Aliases'), key: 'data-table-expand', width: '10%' },
   {
     title: $gettext('DNS status'),
     key: 'dns_global_status',
@@ -310,16 +290,12 @@ function editDomainAlias(domain, alias) {
   showAliasForm.value = true
 }
 
-function loadAliases(item, internalItem, isItemExpanded, toggleExpand) {
-  const isExpand = isItemExpanded(internalItem)
-  if (isExpand) {
-    toggleExpand(internalItem)
-    return
-  }
-  domainsApi.getDomainAliases(item.name).then((resp) => {
+async function loadAliases(item, internalItem, isItemExpanded, toggleExpand) {
+  const isExpanded = isItemExpanded(internalItem)
+  if (!isExpanded) {
+    const resp = await domainsApi.getDomainAliases(item.name)
     aliases.value[item.name] = resp.data
-    toggleExpand(internalItem)
-  })
+  }
 }
 
 function openAdminList(domain) {
diff --git a/frontend/src/components/admin/identities/IdentityList.vue b/frontend/src/components/admin/identities/IdentityList.vue
index 85acbdd22..ada3855a0 100644
--- a/frontend/src/components/admin/identities/IdentityList.vue
+++ b/frontend/src/components/admin/identities/IdentityList.vue
@@ -9,6 +9,7 @@
       :items-length="totalIdentities"
       :page="currentPage"
       :items-per-page="itemsPerPageR"
+      :items-per-page-options="itemsPerPageOptions"
       item-value="pk"
       elevation="0"
       show-select
@@ -310,6 +311,13 @@ const defaultAccountsColumns = [
   availableAccountsColumns.quota,
 ]
 
+const itemsPerPageOptions = [
+  { value: 10, title: '10' },
+  { value: 25, title: '25' },
+  { value: 50, title: '50' },
+  { value: 100, title: '100' },
+]
+
 const identityType = ref('account')
 const totalIdentities = ref(0)
 const identities = ref([])
diff --git a/frontend/src/components/admin/logs/AuditTrailList.vue b/frontend/src/components/admin/logs/AuditTrailList.vue
index 9c24b8382..d7eba2bcc 100644
--- a/frontend/src/components/admin/logs/AuditTrailList.vue
+++ b/frontend/src/components/admin/logs/AuditTrailList.vue
@@ -6,6 +6,7 @@
       :search="search"
       class="elevation-0"
       :items-length="total"
+      :items-per-page-options="itemsPerPageOptions"
       @update:options="fetchLogs"
     >
       <template #top>
@@ -52,6 +53,12 @@ const headers = [
   { title: $gettext('Logger'), key: 'logger' },
   { title: $gettext('Message'), key: 'message' },
 ]
+const itemsPerPageOptions = [
+  { value: 10, title: '10' },
+  { value: 25, title: '25' },
+  { value: 50, title: '50' },
+  { value: 100, title: '100' },
+]
 
 function getLevelColor(level) {
   if (level === 'INFO') {
diff --git a/frontend/src/components/admin/logs/MessageList.vue b/frontend/src/components/admin/logs/MessageList.vue
index ddcfa6782..869fef0ad 100644
--- a/frontend/src/components/admin/logs/MessageList.vue
+++ b/frontend/src/components/admin/logs/MessageList.vue
@@ -6,6 +6,7 @@
       :search="search"
       class="elevation-0"
       :items-length="total"
+      :items-per-page-options="itemsPerPageOptions"
       @update:options="fetchMessages"
     >
       <template #top>
@@ -48,6 +49,12 @@ const headers = [
   { title: $gettext('To'), key: 'rcpt' },
   { title: $gettext('From'), key: 'sender' },
 ]
+const itemsPerPageOptions = [
+  { value: 10, title: '10' },
+  { value: 25, title: '25' },
+  { value: 50, title: '50' },
+  { value: 100, title: '100' },
+]
 
 const loading = ref(true)
 const messages = ref([])
diff --git a/frontend/src/views/admin/domains/DomainsView.vue b/frontend/src/views/admin/domains/DomainsView.vue
index 6b0994b25..dedff4bdc 100644
--- a/frontend/src/views/admin/domains/DomainsView.vue
+++ b/frontend/src/views/admin/domains/DomainsView.vue
@@ -15,7 +15,7 @@
               prepend-icon="mdi-plus"
               class="mr-4"
             >
-              {{ $gettext('New') }}
+              {{ $pgettext('male', 'New') }}
             </v-btn>
           </template>
           <v-list density="compact">