Valid MXs field must contain only IPs.

see #1664
This commit is contained in:
Antoine Nguyen
2022-05-05 15:19:28 +02:00
parent 2f3174e27f
commit ea41ccd44e
4 changed files with 78 additions and 3 deletions
+16
View File
@@ -1,5 +1,6 @@
"""Admin API v2 serializers."""
import ipaddress
import os
from django.conf import settings
@@ -230,6 +231,21 @@ class AdminGlobalParametersSerializer(serializers.Serializer):
)
return value
def validate_valid_mxs(self, value):
"""Make sure it only contains IP addresses."""
if not value:
return value
try:
ip_addresses = [
ipaddress.ip_network(v.strip())
for v in value.split() if v.strip()
]
except ValueError:
raise serializers.ValidationError(
_("This field only allows valid IP addresses (or networks)")
)
return value
def validate(self, data):
"""Check MX options."""
condition = (